Replace parameterized test with standard one

Author: psx95

api/test/trace/propagation/detail/string_test.cc

@@ -14,21 +14,6 @@ struct SplitStringTestData
   size_t max_count;
   std::vector<opentelemetry::nostd::string_view> splits;
   size_t expected_number_strings;
-
-  // When googletest registers parameterized tests, it uses this method to format the parameters.
-  // The default implementation prints hex dump of all bytes in the object. If there is any padding
-  // in these bytes, valgrind reports this as a warning - "Use of uninitialized bytes".
-  // See https://github.com/google/googletest/issues/3805.
-  friend void PrintTo(const SplitStringTestData& data, std::ostream* os) {
-    std::stringstream ss;
-    for (auto it = data.splits.begin(); it != data.splits.end(); it++) {
-      if (it != data.splits.begin()) {
-        ss << ",";
-      }
-      ss << *it;
-    }
-    *os << "(" << data.input << "," << data.separator << "," << data.max_count << "," << ss.str() << "," << data.expected_number_strings << ")";
-  }
 };
 
 const SplitStringTestData split_string_test_cases[] = {
@@ -50,27 +35,22 @@ const SplitStringTestData split_string_test_cases[] = {
      4},
 };
 
-// Test fixture
-class SplitStringTestFixture : public ::testing::TestWithParam<SplitStringTestData>
-{};
 
-TEST_P(SplitStringTestFixture, SplitsAsExpected)
+TEST(StringTest, SplitStringTest)
 {
-  SplitStringTestData test_param = GetParam();
-  std::vector<opentelemetry::nostd::string_view> fields{};
-  fields.reserve(test_param.expected_number_strings);
-  size_t got_splits_num = opentelemetry::trace::propagation::detail::SplitString(
-      test_param.input, test_param.separator, fields.data(), test_param.max_count);
-
-  // Assert on the output
-  EXPECT_EQ(got_splits_num, test_param.expected_number_strings);
-  for (size_t i = 0; i < got_splits_num; i++)
-  {
-    // Checks for resulting strings in-order
-    EXPECT_EQ(fields[i], test_param.splits[i]);
+  for (auto &test_param : split_string_test_cases) {
+    std::vector<opentelemetry::nostd::string_view> fields{};
+    fields.reserve(test_param.expected_number_strings);
+    size_t got_splits_num = opentelemetry::trace::propagation::detail::SplitString(
+        test_param.input, test_param.separator, fields.data(), test_param.max_count);
+
+    // Assert on the output
+    EXPECT_EQ(got_splits_num, test_param.expected_number_strings);
+    for (size_t i = 0; i < got_splits_num; i++)
+    {
+      // Checks for resulting strings in-order
+      EXPECT_EQ(fields[i], test_param.splits[i]);
+    }
   }
 }
 
-INSTANTIATE_TEST_SUITE_P(SplitStringTestCases,
-                         SplitStringTestFixture,
-                         ::testing::ValuesIn(split_string_test_cases));