Second pass

chusitoo · chusitoo · commit b89fbdee85d6 · 2024-11-17T22:34:56.000-05:00
diff --git a/api/include/opentelemetry/metrics/provider.h b/api/include/opentelemetry/metrics/provider.h
@@ -38,7 +38,7 @@ class Provider
   /**
    * Changes the singleton MeterProvider.
    */
-  static void SetMeterProvider(nostd::shared_ptr<MeterProvider> tp) noexcept
+  static void SetMeterProvider(const nostd::shared_ptr<MeterProvider>& tp) noexcept
   {
     std::lock_guard<common::SpinLockMutex> guard(GetLock());
     GetProvider() = tp;
diff --git a/api/include/opentelemetry/nostd/internal/absl/types/internal/variant.h b/api/include/opentelemetry/nostd/internal/absl/types/internal/variant.h
@@ -221,6 +221,7 @@ template <class ReturnType, class FunctionObject, std::size_t... BoundIndices>
 struct MakeVisitationMatrix<ReturnType, FunctionObject, index_sequence<>,
                             index_sequence<BoundIndices...>> {
   using ResultType = ReturnType (*)(FunctionObject&&);
+  // cppcheck-suppress [duplInheritedMember]
   static constexpr ResultType Run() {
     return &call_with_indices<ReturnType, FunctionObject,
                               (BoundIndices - 1)...>;
@@ -722,6 +723,7 @@ struct VariantCoreAccess {
       Self* self, Args&&... args) {
     Destroy(*self);
     using New = typename absl::variant_alternative<NewIndex, Self>::type;
+    // cppcheck-suppress [legacyUninitvar]
     New* const result = ::new (static_cast<void*>(&self->state_))
         New(absl::forward<Args>(args)...);
     self->index_ = NewIndex;
@@ -1310,6 +1312,7 @@ class VariantStateBaseDestructorNontrivial : protected VariantStateBase<T...> {
     VariantStateBaseDestructorNontrivial* self;
   };
 
+  // cppcheck-suppress [duplInheritedMember]
   void destroy() { VisitIndices<sizeof...(T)>::Run(Destroyer{this}, index_); }
 
   ~VariantStateBaseDestructorNontrivial() { destroy(); }
diff --git a/api/include/opentelemetry/nostd/shared_ptr.h b/api/include/opentelemetry/nostd/shared_ptr.h
@@ -37,7 +37,7 @@ class shared_ptr
 
   struct alignas(kAlignment) PlacementBuffer
   {
-    char data[kMaxSize];
+    char data[kMaxSize]{};
   };
 
   class shared_ptr_wrapper
diff --git a/api/include/opentelemetry/plugin/tracer.h b/api/include/opentelemetry/plugin/tracer.h
@@ -20,7 +20,7 @@ class DynamicLibraryHandle;
 class Span final : public trace::Span
 {
 public:
-  Span(std::shared_ptr<trace::Tracer> &&tracer, nostd::shared_ptr<trace::Span> span) noexcept
+  Span(std::shared_ptr<trace::Tracer> &&tracer, const nostd::shared_ptr<trace::Span>& span) noexcept
       : tracer_{std::move(tracer)}, span_{span}
   {}
 
diff --git a/examples/http/server.h b/examples/http/server.h
@@ -19,13 +19,13 @@ class HttpServer : public HTTP_SERVER_NS::HttpRequestCallback
   std::atomic<bool> is_running_{false};
 
 public:
-  HttpServer(std::string server_name = "test_server", uint16_t port = 8800) : port_(port)
+  HttpServer(const std::string &server_name = "test_server", uint16_t port = 8800) : port_(port)
   {
     server_.setServerName(server_name);
     server_.setKeepalive(false);
   }
 
-  void AddHandler(std::string path, HTTP_SERVER_NS::HttpRequestCallback *request_handler)
+  void AddHandler(const std::string &path, HTTP_SERVER_NS::HttpRequestCallback *request_handler)
   {
     server_.addHandler(path, *request_handler);
   }
diff --git a/exporters/elasticsearch/include/opentelemetry/exporters/elasticsearch/es_log_record_exporter.h b/exporters/elasticsearch/include/opentelemetry/exporters/elasticsearch/es_log_record_exporter.h
@@ -52,12 +52,12 @@ struct ElasticsearchExporterOptions
    * from elasticsearch
    * @param console_debug If true, print the status of the exporter methods in the console
    */
-  ElasticsearchExporterOptions(std::string host         = "localhost",
-                               int port                 = 9200,
-                               std::string index        = "logs",
-                               int response_timeout     = 30,
-                               bool console_debug       = false,
-                               HttpHeaders http_headers = {})
+  ElasticsearchExporterOptions(const std::string &host         = "localhost",
+                               int port                        = 9200,
+                               const std::string &index        = "logs",
+                               int response_timeout            = 30,
+                               bool console_debug              = false,
+                               const HttpHeaders &http_headers = {})
       : host_{host},
         port_{port},
         index_{index},
diff --git a/exporters/otlp/src/otlp_http_client.cc b/exporters/otlp/src/otlp_http_client.cc
@@ -898,7 +898,7 @@ OtlpHttpClient::createSession(
       {
         std::cerr << error_message << '\n';
       }
-      OTEL_INTERNAL_LOG_ERROR(error_message.c_str());
+      OTEL_INTERNAL_LOG_ERROR(error_message);
 
       const auto result = opentelemetry::sdk::common::ExportResult::kFailure;
       result_callback(result);
diff --git a/exporters/otlp/src/otlp_http_exporter_options.cc b/exporters/otlp/src/otlp_http_exporter_options.cc
@@ -16,35 +16,30 @@ namespace otlp
 {
 
 OtlpHttpExporterOptions::OtlpHttpExporterOptions()
-    : json_bytes_mapping(JsonBytesMappingKind::kHexId),
+    : url(GetOtlpDefaultHttpTracesEndpoint()),
+      content_type(GetOtlpHttpProtocolFromString(GetOtlpDefaultHttpTracesProtocol())),
+      json_bytes_mapping(JsonBytesMappingKind::kHexId),
       use_json_name(false),
       console_debug(false),
-      ssl_insecure_skip_verify(false)
+      timeout(GetOtlpDefaultTracesTimeout()),
+      http_headers(GetOtlpDefaultTracesHeaders()),
+      ssl_insecure_skip_verify(false),
+      ssl_ca_cert_path(GetOtlpDefaultTracesSslCertificatePath()),
+      ssl_ca_cert_string(GetOtlpDefaultTracesSslCertificateString()),
+      ssl_client_key_path(GetOtlpDefaultTracesSslClientKeyPath()),
+      ssl_client_key_string(GetOtlpDefaultTracesSslClientKeyString()),
+      ssl_client_cert_path(GetOtlpDefaultTracesSslClientCertificatePath()),
+      ssl_client_cert_string(GetOtlpDefaultTracesSslClientCertificateString()),
+      ssl_min_tls(GetOtlpDefaultTracesSslTlsMinVersion()),
+      ssl_max_tls(GetOtlpDefaultTracesSslTlsMaxVersion()),
+      ssl_cipher(GetOtlpDefaultTracesSslTlsCipher()),
+      ssl_cipher_suite(GetOtlpDefaultTracesSslTlsCipherSuite()),
+      compression(GetOtlpDefaultTracesCompression())
 {
-  url          = GetOtlpDefaultHttpTracesEndpoint();
-  content_type = GetOtlpHttpProtocolFromString(GetOtlpDefaultHttpTracesProtocol());
-
-  timeout      = GetOtlpDefaultTracesTimeout();
-  http_headers = GetOtlpDefaultTracesHeaders();
-
 #ifdef ENABLE_ASYNC_EXPORT
   max_concurrent_requests     = 64;
   max_requests_per_connection = 8;
 #endif /* ENABLE_ASYNC_EXPORT */
-
-  ssl_ca_cert_path       = GetOtlpDefaultTracesSslCertificatePath();
-  ssl_ca_cert_string     = GetOtlpDefaultTracesSslCertificateString();
-  ssl_client_key_path    = GetOtlpDefaultTracesSslClientKeyPath();
-  ssl_client_key_string  = GetOtlpDefaultTracesSslClientKeyString();
-  ssl_client_cert_path   = GetOtlpDefaultTracesSslClientCertificatePath();
-  ssl_client_cert_string = GetOtlpDefaultTracesSslClientCertificateString();
-
-  ssl_min_tls      = GetOtlpDefaultTracesSslTlsMinVersion();
-  ssl_max_tls      = GetOtlpDefaultTracesSslTlsMaxVersion();
-  ssl_cipher       = GetOtlpDefaultTracesSslTlsCipher();
-  ssl_cipher_suite = GetOtlpDefaultTracesSslTlsCipherSuite();
-
-  compression = GetOtlpDefaultTracesCompression();
 }
 
 OtlpHttpExporterOptions::~OtlpHttpExporterOptions() {}
diff --git a/exporters/otlp/src/otlp_http_log_record_exporter_options.cc b/exporters/otlp/src/otlp_http_log_record_exporter_options.cc
@@ -16,35 +16,30 @@ namespace otlp
 {
 
 OtlpHttpLogRecordExporterOptions::OtlpHttpLogRecordExporterOptions()
-    : json_bytes_mapping(JsonBytesMappingKind::kHexId),
+    : url(GetOtlpDefaultHttpLogsEndpoint()),
+      content_type(GetOtlpHttpProtocolFromString(GetOtlpDefaultHttpLogsProtocol())),
+      json_bytes_mapping(JsonBytesMappingKind::kHexId),
       use_json_name(false),
       console_debug(false),
-      ssl_insecure_skip_verify(false)
+      timeout(GetOtlpDefaultLogsTimeout()),
+      http_headers(GetOtlpDefaultLogsHeaders()),
+      ssl_insecure_skip_verify(false),
+      ssl_ca_cert_path(GetOtlpDefaultLogsSslCertificatePath()),
+      ssl_ca_cert_string(GetOtlpDefaultLogsSslCertificateString()),
+      ssl_client_key_path(GetOtlpDefaultLogsSslClientKeyPath()),
+      ssl_client_key_string(GetOtlpDefaultLogsSslClientKeyString()),
+      ssl_client_cert_path(GetOtlpDefaultLogsSslClientCertificatePath()),
+      ssl_client_cert_string(GetOtlpDefaultLogsSslClientCertificateString()),
+      ssl_min_tls(GetOtlpDefaultLogsSslTlsMinVersion()),
+      ssl_max_tls(GetOtlpDefaultLogsSslTlsMaxVersion()),
+      ssl_cipher(GetOtlpDefaultLogsSslTlsCipher()),
+      ssl_cipher_suite(GetOtlpDefaultLogsSslTlsCipherSuite()),
+      compression(GetOtlpDefaultLogsCompression())
 {
-  url          = GetOtlpDefaultHttpLogsEndpoint();
-  content_type = GetOtlpHttpProtocolFromString(GetOtlpDefaultHttpLogsProtocol());
-
-  timeout      = GetOtlpDefaultLogsTimeout();
-  http_headers = GetOtlpDefaultLogsHeaders();
-
 #ifdef ENABLE_ASYNC_EXPORT
   max_concurrent_requests     = 64;
   max_requests_per_connection = 8;
 #endif
-
-  ssl_ca_cert_path       = GetOtlpDefaultLogsSslCertificatePath();
-  ssl_ca_cert_string     = GetOtlpDefaultLogsSslCertificateString();
-  ssl_client_key_path    = GetOtlpDefaultLogsSslClientKeyPath();
-  ssl_client_key_string  = GetOtlpDefaultLogsSslClientKeyString();
-  ssl_client_cert_path   = GetOtlpDefaultLogsSslClientCertificatePath();
-  ssl_client_cert_string = GetOtlpDefaultLogsSslClientCertificateString();
-
-  ssl_min_tls      = GetOtlpDefaultLogsSslTlsMinVersion();
-  ssl_max_tls      = GetOtlpDefaultLogsSslTlsMaxVersion();
-  ssl_cipher       = GetOtlpDefaultLogsSslTlsCipher();
-  ssl_cipher_suite = GetOtlpDefaultLogsSslTlsCipherSuite();
-
-  compression = GetOtlpDefaultLogsCompression();
 }
 
 OtlpHttpLogRecordExporterOptions::~OtlpHttpLogRecordExporterOptions() {}
diff --git a/exporters/otlp/src/otlp_http_metric_exporter_options.cc b/exporters/otlp/src/otlp_http_metric_exporter_options.cc
@@ -17,36 +17,31 @@ namespace otlp
 {
 
 OtlpHttpMetricExporterOptions::OtlpHttpMetricExporterOptions()
-    : json_bytes_mapping(JsonBytesMappingKind::kHexId),
+    : url(GetOtlpDefaultMetricsEndpoint()),
+      content_type(GetOtlpHttpProtocolFromString(GetOtlpDefaultHttpMetricsProtocol())),
+      json_bytes_mapping(JsonBytesMappingKind::kHexId),
       use_json_name(false),
       console_debug(false),
+      timeout(GetOtlpDefaultMetricsTimeout()),
+      http_headers(GetOtlpDefaultMetricsHeaders()),
       aggregation_temporality(PreferredAggregationTemporality::kCumulative),
-      ssl_insecure_skip_verify(false)
+      ssl_insecure_skip_verify(false),
+      ssl_ca_cert_path(GetOtlpDefaultMetricsSslCertificatePath()),
+      ssl_ca_cert_string(GetOtlpDefaultMetricsSslCertificateString()),
+      ssl_client_key_path(GetOtlpDefaultMetricsSslClientKeyPath()),
+      ssl_client_key_string(GetOtlpDefaultMetricsSslClientKeyString()),
+      ssl_client_cert_path(GetOtlpDefaultMetricsSslClientCertificatePath()),
+      ssl_client_cert_string(GetOtlpDefaultMetricsSslClientCertificateString()),
+      ssl_min_tls(GetOtlpDefaultMetricsSslTlsMinVersion()),
+      ssl_max_tls(GetOtlpDefaultMetricsSslTlsMaxVersion()),
+      ssl_cipher(GetOtlpDefaultMetricsSslTlsCipher()),
+      ssl_cipher_suite(GetOtlpDefaultMetricsSslTlsCipherSuite()),
+      compression(GetOtlpDefaultMetricsCompression())
 {
-  url          = GetOtlpDefaultMetricsEndpoint();
-  content_type = GetOtlpHttpProtocolFromString(GetOtlpDefaultHttpMetricsProtocol());
-
-  timeout      = GetOtlpDefaultMetricsTimeout();
-  http_headers = GetOtlpDefaultMetricsHeaders();
-
 #ifdef ENABLE_ASYNC_EXPORT
   max_concurrent_requests     = 64;
   max_requests_per_connection = 8;
 #endif
-
-  ssl_ca_cert_path       = GetOtlpDefaultMetricsSslCertificatePath();
-  ssl_ca_cert_string     = GetOtlpDefaultMetricsSslCertificateString();
-  ssl_client_key_path    = GetOtlpDefaultMetricsSslClientKeyPath();
-  ssl_client_key_string  = GetOtlpDefaultMetricsSslClientKeyString();
-  ssl_client_cert_path   = GetOtlpDefaultMetricsSslClientCertificatePath();
-  ssl_client_cert_string = GetOtlpDefaultMetricsSslClientCertificateString();
-
-  ssl_min_tls      = GetOtlpDefaultMetricsSslTlsMinVersion();
-  ssl_max_tls      = GetOtlpDefaultMetricsSslTlsMaxVersion();
-  ssl_cipher       = GetOtlpDefaultMetricsSslTlsCipher();
-  ssl_cipher_suite = GetOtlpDefaultMetricsSslTlsCipherSuite();
-
-  compression = GetOtlpDefaultMetricsCompression();
 }
 
 OtlpHttpMetricExporterOptions::~OtlpHttpMetricExporterOptions() {}
diff --git a/exporters/prometheus/include/opentelemetry/exporters/prometheus/exporter_utils.h b/exporters/prometheus/include/opentelemetry/exporters/prometheus/exporter_utils.h
@@ -204,7 +204,7 @@ class PrometheusExporterUtils
    * Handle Counter and Gauge.
    */
   template <typename T>
-  static void SetValue(std::vector<T> values,
+  static void SetValue(const std::vector<T> &values,
                        ::prometheus::MetricType type,
                        ::prometheus::ClientMetric *metric);
 
@@ -217,7 +217,7 @@ class PrometheusExporterUtils
    * Handle Histogram
    */
   template <typename T>
-  static void SetValue(std::vector<T> values,
+  static void SetValue(const std::vector<T> &values,
                        const std::vector<double> &boundaries,
                        const std::vector<uint64_t> &counts,
                        ::prometheus::ClientMetric *metric);
diff --git a/exporters/prometheus/src/exporter_utils.cc b/exporters/prometheus/src/exporter_utils.cc
@@ -769,7 +769,7 @@ std::string PrometheusExporterUtils::AttributeValueToString(
  * Handle Counter.
  */
 template <typename T>
-void PrometheusExporterUtils::SetValue(std::vector<T> values,
+void PrometheusExporterUtils::SetValue(const std::vector<T> &values,
                                        prometheus_client::MetricType type,
                                        prometheus_client::ClientMetric *metric)
 {
@@ -807,7 +807,7 @@ void PrometheusExporterUtils::SetValue(std::vector<T> values,
  * Handle Histogram
  */
 template <typename T>
-void PrometheusExporterUtils::SetValue(std::vector<T> values,
+void PrometheusExporterUtils::SetValue(const std::vector<T> &values,
                                        const std::vector<double> &boundaries,
                                        const std::vector<uint64_t> &counts,
                                        prometheus_client::ClientMetric *metric)
diff --git a/exporters/zipkin/src/zipkin_exporter.cc b/exporters/zipkin/src/zipkin_exporter.cc
@@ -37,15 +37,18 @@ namespace zipkin
 // -------------------------------- Constructors --------------------------------
 
 ZipkinExporter::ZipkinExporter(const ZipkinExporterOptions &options)
-    : options_(options), url_parser_(options_.endpoint)
+    : options_(options),
+      http_client_(ext::http::client::HttpClientFactory::CreateSync()),
+      url_parser_(options_.endpoint)
 {
-  http_client_ = ext::http::client::HttpClientFactory::CreateSync();
   InitializeLocalEndpoint();
 }
 
-ZipkinExporter::ZipkinExporter() : options_(ZipkinExporterOptions()), url_parser_(options_.endpoint)
+ZipkinExporter::ZipkinExporter()
+    : options_(ZipkinExporterOptions()),
+      http_client_(ext::http::client::HttpClientFactory::CreateSync()),
+      url_parser_(options_.endpoint)
 {
-  http_client_ = ext::http::client::HttpClientFactory::CreateSync();
   InitializeLocalEndpoint();
 }
 
diff --git a/ext/include/opentelemetry/ext/http/client/curl/http_client_curl.h b/ext/include/opentelemetry/ext/http/client/curl/http_client_curl.h
@@ -307,6 +307,7 @@ class HttpClient : public opentelemetry::ext::http::client::HttpClient
   std::shared_ptr<opentelemetry::ext::http::client::Session> CreateSession(
       nostd::string_view url) noexcept override;
 
+  // cppcheck-suppress [virtualCallInConstructor]
   bool CancelAllSessions() noexcept override;
 
   bool FinishAllSessions() noexcept override;
diff --git a/ext/include/opentelemetry/ext/http/server/http_server.h b/ext/include/opentelemetry/ext/http/server/http_server.h
@@ -120,7 +120,7 @@ class HttpServer : private SocketTools::Reactor::SocketCallback
   class HttpRequestHandler : public std::pair<std::string, HttpRequestCallback *>
   {
   public:
-    HttpRequestHandler(std::string key, HttpRequestCallback *value)
+    HttpRequestHandler(const std::string &key, HttpRequestCallback *value)
     {
       first  = key;
       second = value;
@@ -168,7 +168,7 @@ class HttpServer : private SocketTools::Reactor::SocketCallback
         m_maxRequestContentSize(2 * 1024 * 1024)
   {}
 
-  HttpServer(std::string serverHost, int port = 30000) : HttpServer()
+  HttpServer(const std::string &serverHost, int port = 30000) : HttpServer()
   {
     std::ostringstream os;
     os << serverHost << ":" << port;
diff --git a/ext/include/opentelemetry/ext/http/server/socket_tools.h b/ext/include/opentelemetry/ext/http/server/socket_tools.h
@@ -270,7 +270,7 @@ struct Socket
 
   Socket(Type sock = Invalid) : m_sock(sock) {}
 
-  Socket(int af, int type, int proto) { m_sock = ::socket(af, type, proto); }
+  Socket(int af, int type, int proto) : m_sock(::socket(af, type, proto)) {}
 
   ~Socket() {}
 
diff --git a/sdk/include/opentelemetry/sdk/common/circular_buffer.h b/sdk/include/opentelemetry/sdk/common/circular_buffer.h
@@ -185,8 +185,10 @@ class CircularBuffer
     if (tail_index < head_index)
     {
       return CircularBufferRange<AtomicUniquePtr<T>>{nostd::span<AtomicUniquePtr<T>>{
+          // cppcheck-suppress [arithOperationsOnVoidPointer]
           data + tail_index, static_cast<std::size_t>(head_index - tail_index)}};
     }
+    // cppcheck-suppress [arithOperationsOnVoidPointer]
     return {nostd::span<AtomicUniquePtr<T>>{data + tail_index,
                                             static_cast<std::size_t>(capacity_ - tail_index)},
             nostd::span<AtomicUniquePtr<T>>{data, static_cast<std::size_t>(head_index)}};
diff --git a/sdk/include/opentelemetry/sdk/logs/batch_log_record_processor.h b/sdk/include/opentelemetry/sdk/logs/batch_log_record_processor.h
@@ -85,6 +85,7 @@ class BatchLogRecordProcessor : public LogRecordProcessor
    *
    * NOTE: Timeout functionality not supported yet.
    */
+  // cppcheck-suppress [virtualCallInConstructor]
   bool Shutdown(
       std::chrono::microseconds timeout = (std::chrono::microseconds::max)()) noexcept override;
 
diff --git a/sdk/include/opentelemetry/sdk/logs/multi_log_record_processor.h b/sdk/include/opentelemetry/sdk/logs/multi_log_record_processor.h
@@ -43,6 +43,7 @@ class MultiLogRecordProcessor : public LogRecordProcessor
    * @param timeout that the forceflush is required to finish within.
    * @return a result code indicating whether it succeeded, failed or timed out
    */
+  // cppcheck-suppress [virtualCallInConstructor]
   bool ForceFlush(
       std::chrono::microseconds timeout = (std::chrono::microseconds::max)()) noexcept override;
 
@@ -53,6 +54,7 @@ class MultiLogRecordProcessor : public LogRecordProcessor
    * shutdown before giving up and returning failure.
    * @return true if the shutdown succeeded, false otherwise
    */
+  // cppcheck-suppress [virtualCallInConstructor]
   bool Shutdown(
       std::chrono::microseconds timeout = (std::chrono::microseconds::max)()) noexcept override;
 
diff --git a/sdk/include/opentelemetry/sdk/trace/batch_span_processor.h b/sdk/include/opentelemetry/sdk/trace/batch_span_processor.h
@@ -83,6 +83,7 @@ class BatchSpanProcessor : public SpanProcessor
    *
    * NOTE: Timeout functionality not supported yet.
    */
+  // cppcheck-suppress [virtualCallInConstructor]
   bool Shutdown(
       std::chrono::microseconds timeout = (std::chrono::microseconds::max)()) noexcept override;
 
diff --git a/sdk/include/opentelemetry/sdk/trace/multi_span_processor.h b/sdk/include/opentelemetry/sdk/trace/multi_span_processor.h
@@ -121,6 +121,7 @@ class MultiSpanProcessor : public SpanProcessor
     return result;
   }
 
+  // cppcheck-suppress [virtualCallInConstructor]
   bool Shutdown(
       std::chrono::microseconds timeout = (std::chrono::microseconds::max)()) noexcept override
   {
diff --git a/sdk/include/opentelemetry/sdk/trace/simple_processor.h b/sdk/include/opentelemetry/sdk/trace/simple_processor.h
diff --git a/sdk/src/trace/tracer_provider.cc b/sdk/src/trace/tracer_provider.cc

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ class Provider`
`38`	`38`	`/**`
`39`	`39`	`* Changes the singleton MeterProvider.`
`40`	`40`	`*/`
`41`		`- static void SetMeterProvider(nostd::shared_ptr<MeterProvider> tp) noexcept`
	`41`	`+ static void SetMeterProvider(const nostd::shared_ptr<MeterProvider>& tp) noexcept`
`42`	`42`	`{`
`43`	`43`	`std::lock_guard<common::SpinLockMutex> guard(GetLock());`
`44`	`44`	`GetProvider() = tp;`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ class shared_ptr`
`37`	`37`
`38`	`38`	`struct alignas(kAlignment) PlacementBuffer`
`39`	`39`	`{`
`40`		`- char data[kMaxSize];`
	`40`	`+ char data[kMaxSize]{};`
`41`	`41`	`};`
`42`	`42`
`43`	`43`	`class shared_ptr_wrapper`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ class DynamicLibraryHandle;`
`20`	`20`	`class Span final : public trace::Span`
`21`	`21`	`{`
`22`	`22`	`public:`
`23`		`- Span(std::shared_ptr<trace::Tracer> &&tracer, nostd::shared_ptr<trace::Span> span) noexcept`
	`23`	`+ Span(std::shared_ptr<trace::Tracer> &&tracer, const nostd::shared_ptr<trace::Span>& span) noexcept`
`24`	`24`	`: tracer_{std::move(tracer)}, span_{span}`
`25`	`25`	`{}`
`26`	`26`
Original file line number	Diff line number	Diff line change
`@@ -19,13 +19,13 @@ class HttpServer : public HTTP_SERVER_NS::HttpRequestCallback`
`19`	`19`	`std::atomic<bool> is_running_{false};`
`20`	`20`
`21`	`21`	`public:`
`22`		`- HttpServer(std::string server_name = "test_server", uint16_t port = 8800) : port_(port)`
	`22`	`+ HttpServer(const std::string &server_name = "test_server", uint16_t port = 8800) : port_(port)`
`23`	`23`	`{`
`24`	`24`	`server_.setServerName(server_name);`
`25`	`25`	`server_.setKeepalive(false);`
`26`	`26`	`}`
`27`	`27`
`28`		`- void AddHandler(std::string path, HTTP_SERVER_NS::HttpRequestCallback *request_handler)`
	`28`	`+ void AddHandler(const std::string &path, HTTP_SERVER_NS::HttpRequestCallback *request_handler)`
`29`	`29`	`{`
`30`	`30`	`server_.addHandler(path, *request_handler);`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -898,7 +898,7 @@ OtlpHttpClient::createSession(`
`898`	`898`	`{`
`899`	`899`	`std::cerr << error_message << '\n';`
`900`	`900`	`}`
`901`		`- OTEL_INTERNAL_LOG_ERROR(error_message.c_str());`
	`901`	`+ OTEL_INTERNAL_LOG_ERROR(error_message);`
`902`	`902`
`903`	`903`	`const auto result = opentelemetry::sdk::common::ExportResult::kFailure;`
`904`	`904`	`result_callback(result);`