Skip to content

Commit ba05982

Browse files
authored
[TEST] Remove workaround for metrics cardinality limit test (#3663)
1 parent 116f438 commit ba05982

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ Increment the:
1515

1616
## [Unreleased]
1717

18+
* [TEST] Remove workaround for metrics cardinality limit test
19+
[#3663](https://github.com/open-telemetry/opentelemetry-cpp/pull/3663)
20+
1821
## [1.23 2025-09-25]
1922

2023
* [CodeHealth] Fix clang-tidy warnings part 6

sdk/test/metrics/sum_aggregation_test.cc

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -194,11 +194,7 @@ TEST(HistogramToSumFilterAttributesWithCardinalityLimit, Double)
194194
{
195195
for (const MetricData &md : smd.metric_data_)
196196
{
197-
// Something weird about attributes hashmap. If cardinality is setup to n, it emits n-1
198-
// including overflow. Just making the logic generic here to succeed for n or n-1 total
199-
// cardinality.
200-
EXPECT_GE(cardinality_limit, md.point_data_attr_.size());
201-
EXPECT_LT(cardinality_limit / 2, md.point_data_attr_.size());
197+
EXPECT_EQ(cardinality_limit, md.point_data_attr_.size());
202198
for (size_t i = 0; i < md.point_data_attr_.size(); i++)
203199
{
204200
EXPECT_EQ(1, md.point_data_attr_[i].attributes.size());
@@ -380,8 +376,7 @@ TEST(CounterToSumFilterAttributesWithCardinalityLimit, Double)
380376
// resulting in a total of cardinality_limit sets. This test checks that the number of
381377
// emitted attribute sets is within the expected range, accounting for the overflow
382378
// behavior.
383-
EXPECT_GE(cardinality_limit, md.point_data_attr_.size());
384-
EXPECT_LT(cardinality_limit / 2, md.point_data_attr_.size());
379+
EXPECT_EQ(cardinality_limit, md.point_data_attr_.size());
385380
for (size_t i = 0; i < md.point_data_attr_.size(); i++)
386381
{
387382
EXPECT_EQ(1, md.point_data_attr_[i].attributes.size());

0 commit comments

Comments
 (0)