Skip to content

Commit bce4aab

Browse files
committed
Refresh code from PR #2518, to fix review comments.
1 parent 26f2e52 commit bce4aab

10 files changed

+1
-41
lines changed

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_log_record_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpFileLogRecordBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpFileLogRecordBuilder() = default;
27-
~OtlpFileLogRecordBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::logs::LogRecordExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpFileLogRecordExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_push_metric_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpFilePushMetricBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpFilePushMetricBuilder() = default;
27-
~OtlpFilePushMetricBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::metrics::PushMetricExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpFilePushMetricExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_span_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpFileSpanBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpFileSpanBuilder() = default;
27-
~OtlpFileSpanBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::trace::SpanExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpFileSpanExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpGrpcLogRecordBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpGrpcLogRecordBuilder() = default;
27-
~OtlpGrpcLogRecordBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::logs::LogRecordExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpGrpcLogRecordExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_push_metric_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpGrpcPushMetricBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpGrpcPushMetricBuilder() = default;
27-
~OtlpGrpcPushMetricBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::metrics::PushMetricExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpGrpcPushMetricExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_span_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpGrpcSpanBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpGrpcSpanBuilder() = default;
27-
~OtlpGrpcSpanBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::trace::SpanExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpGrpcSpanExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpHttpLogRecordBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpHttpLogRecordBuilder() = default;
27-
~OtlpHttpLogRecordBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::logs::LogRecordExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpHttpLogRecordExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_push_metric_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpHttpPushMetricBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpHttpPushMetricBuilder() = default;
27-
~OtlpHttpPushMetricBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::metrics::PushMetricExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpHttpPushMetricExporterConfiguration *model)
3128
const override;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_span_builder.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class OPENTELEMETRY_EXPORT OtlpHttpSpanBuilder
2323
public:
2424
static void Register(opentelemetry::sdk::configuration::Registry *registry);
2525

26-
OtlpHttpSpanBuilder() = default;
27-
~OtlpHttpSpanBuilder() override = default;
28-
2926
std::unique_ptr<opentelemetry::sdk::trace::SpanExporter> Build(
3027
const opentelemetry::sdk::configuration::OtlpHttpSpanExporterConfiguration *model)
3128
const override;

exporters/otlp/src/otlp_http_exporter_options.cc

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -49,24 +49,11 @@ OtlpHttpExporterOptions::OtlpHttpExporterOptions(void *)
4949
json_bytes_mapping(JsonBytesMappingKind::kHexId),
5050
use_json_name(false),
5151
console_debug(false),
52-
timeout(0),
53-
http_headers(),
5452
#ifdef ENABLE_ASYNC_EXPORT
5553
max_concurrent_requests{64},
5654
max_requests_per_connection{8},
5755
#endif
58-
ssl_insecure_skip_verify(false),
59-
ssl_ca_cert_path(),
60-
ssl_ca_cert_string(),
61-
ssl_client_key_path(),
62-
ssl_client_key_string(),
63-
ssl_client_cert_path(),
64-
ssl_client_cert_string(),
65-
ssl_min_tls(),
66-
ssl_max_tls(),
67-
ssl_cipher(),
68-
ssl_cipher_suite(),
69-
compression()
56+
ssl_insecure_skip_verify(false)
7057
{}
7158

7259
OtlpHttpExporterOptions::~OtlpHttpExporterOptions() {}

0 commit comments

Comments
 (0)