Merge branch 'main' into process_detector_attr

Author: nikhilbhatia08

.github/workflows/ci.yml

@@ -58,7 +58,7 @@ jobs:
     runs-on: ubuntu-24.04
     env:
       CXX_STANDARD: '17'
-      CMAKE_VERSION: '3.14.0'
+      CMAKE_VERSION: '3.16.0'
       BUILD_TYPE: 'Debug'
     steps:
     - name: Harden the runner (Audit all outbound calls)
@@ -1046,7 +1046,7 @@ jobs:
         CXX: /usr/bin/g++-10
       run: ./ci/do_ci.sh code.coverage
     - name: upload report
-      uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
+      uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
       with:
         files: /home/runner/build/coverage.info
 

.github/workflows/cmake_install.yml

@@ -153,7 +153,7 @@ jobs:
     env:
       INSTALL_TEST_DIR: '/home/runner/install_test'
       # Set to the current minimum version of cmake
-      CMAKE_VERSION: '3.14.0'
+      CMAKE_VERSION: '3.16.0'
       # cxx14 is the default for Ubuntu 22.04
       CXX_STANDARD: '14'
       BUILD_TYPE: 'Debug'

.github/workflows/codeql-analysis.yml

@@ -37,10 +37,10 @@ jobs:
       run: |
         sudo -E ./ci/setup_ci_environment.sh
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@96f518a34f7a870018057716cc4d7a5c014bd61c # v3.29.10
+      uses: github/codeql-action/init@3c3833e0f8c1c83d449a7478aa59c036a9165498 # v3.29.11
       with:
        languages: cpp
     - name: Autobuild
-      uses: github/codeql-action/autobuild@96f518a34f7a870018057716cc4d7a5c014bd61c # v3.29.10
+      uses: github/codeql-action/autobuild@3c3833e0f8c1c83d449a7478aa59c036a9165498 # v3.29.11
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@96f518a34f7a870018057716cc4d7a5c014bd61c # v3.29.10
+      uses: github/codeql-action/analyze@3c3833e0f8c1c83d449a7478aa59c036a9165498 # v3.29.11

.github/workflows/ossf-scorecard.yml

@@ -47,6 +47,6 @@ jobs:
       # Upload the results to GitHub's code scanning dashboard (optional).
       # Commenting out will disable upload of results to your repo's Code Scanning dashboard
       - name: "Upload to code-scanning"
-        uses: github/codeql-action/upload-sarif@96f518a34f7a870018057716cc4d7a5c014bd61c # v3.29.10
+        uses: github/codeql-action/upload-sarif@3c3833e0f8c1c83d449a7478aa59c036a9165498 # v3.29.11
         with:
           sarif_file: results.sarif

CHANGELOG.md

@@ -30,6 +30,11 @@ Increment the:
 * [SDK] View should not have a unit
   [#3552](https://github.com/open-telemetry/opentelemetry-cpp/pull/3552)
 
+Important changes:
+
+* [CMAKE] Upgrade CMake minimum version to 3.16
+  [#3599](https://github.com/open-telemetry/opentelemetry-cpp/pull/3599)
+
 Breaking changes:
 
 * [SDK] View should not have a unit

CMakeLists.txt

@@ -1,31 +1,15 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-cmake_minimum_required(VERSION 3.14)
-
-# See https://cmake.org/cmake/help/latest/policy/CMP0074.html required by
-# certain version of zlib which CURL depends on.
-if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.12")
-  cmake_policy(SET CMP0074 NEW)
-endif()
-
-# Allow to use normal variable for option()
-if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.13")
-  cmake_policy(SET CMP0077 NEW)
-endif()
-
-# Prefer CMAKE_MSVC_RUNTIME_LIBRARY if possible
-if(POLICY CMP0091)
-  cmake_policy(SET CMP0091 NEW)
-endif()
+cmake_minimum_required(VERSION 3.16)
 
 if(POLICY CMP0092)
   # https://cmake.org/cmake/help/latest/policy/CMP0092.html#policy:CMP0092 Make
   # sure the /W3 is not removed from CMAKE_CXX_FLAGS since CMake 3.15
   cmake_policy(SET CMP0092 OLD)
 endif()
 
-# MSVC RTTI flag /GR should not be not added to CMAKE_CXX_FLAGS by default. @see
+# MSVC RTTI flag /GR should not be added to CMAKE_CXX_FLAGS by default. @see
 # https://cmake.org/cmake/help/latest/policy/CMP0117.html
 if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.20.0")
   cmake_policy(SET CMP0117 NEW)
@@ -36,11 +20,6 @@ project(opentelemetry-cpp)
 # Mark variables as used so cmake doesn't complain about them
 mark_as_advanced(CMAKE_TOOLCHAIN_FILE)
 
-# Don't use customized cmake modules if vcpkg is used to resolve dependence.
-if(NOT DEFINED CMAKE_TOOLCHAIN_FILE)
-  list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/modules/")
-endif()
-
 # Set the third-party release git tags.
 if(EXISTS "${opentelemetry-cpp_SOURCE_DIR}/third_party_release")
   file(STRINGS "${opentelemetry-cpp_SOURCE_DIR}/third_party_release"

INSTALL.md

@@ -23,8 +23,7 @@ You can link OpenTelemetry C++ SDK with libraries provided in
   repository. To install Git, consult the [Set up
   Git](https://help.github.com/articles/set-up-git/) guide on GitHub.
 - [CMake](https://cmake.org/) for building opentelemetry-cpp API, SDK with their
-  unittests. The minimum CMake version is 3.14.
-  CMake 3.15+ is recommended on Windows due to known CI test failures with 3.14.
+  unittests. The minimum CMake version is 3.16.
   To install CMake,
   consult the [Installing CMake](https://cmake.org/install/) guide.
 - [GoogleTest](https://github.com/google/googletest) framework to build and run

bazel/extra_deps.bzl

@@ -5,9 +5,7 @@
 
 load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
 load("@com_github_jupp0r_prometheus_cpp//bazel:repositories.bzl", "prometheus_cpp_repositories")
-load("@rules_foreign_cc//foreign_cc:repositories.bzl", "rules_foreign_cc_dependencies")
 
 def opentelemetry_extra_deps():
     prometheus_cpp_repositories()
     bazel_skylib_workspace()
-    rules_foreign_cc_dependencies()

bazel/repository.bzl

@@ -141,15 +141,6 @@ def opentelemetry_cpp_deps():
         ],
     )
 
-    # rules foreign cc
-    maybe(
-        http_archive,
-        name = "rules_foreign_cc",
-        sha256 = "69023642d5781c68911beda769f91fcbc8ca48711db935a75da7f6536b65047f",
-        strip_prefix = "rules_foreign_cc-0.6.0",
-        url = "https://github.com/bazelbuild/rules_foreign_cc/archive/0.6.0.tar.gz",
-    )
-
     # bazel skylib
     maybe(
         http_archive,

install/cmake/CMakeLists.txt

@@ -22,7 +22,7 @@
 # CMAKE_CXX_STANDARD: The C++ standard to use for all third-party packages.
 # Defaults to 14 if not set.
 
-cmake_minimum_required(VERSION 3.14)
+cmake_minimum_required(VERSION 3.16)
 project(opentelemetry-cpp-thirdparty-install LANGUAGES CXX)
 
 # Added in CMake 3.16. ExternalProject_Add() with GIT_SUBMODULES "" initializes