File tree Expand file tree Collapse file tree 3 files changed +10
-1
lines changed Expand file tree Collapse file tree 3 files changed +10
-1
lines changed Original file line number Diff line number Diff line change @@ -15,6 +15,9 @@ Increment the:
15
15
16
16
## [ Unreleased]
17
17
18
+ * [ BUILD] Error out when building DLL without MSVC
19
+ [ #3438 ] ( https://github.com/open-telemetry/opentelemetry-cpp/pull/3438 )
20
+
18
21
* [ Metrics SDK] Use nostd::function_ref in AttributesHashMap
19
22
[ #3393 ] ( https://github.com/open-telemetry/opentelemetry-cpp/pull/3393 )
20
23
Original file line number Diff line number Diff line change @@ -5,6 +5,6 @@ if(WITH_HTTP_CLIENT_CURL)
5
5
add_subdirectory (http/client/curl )
6
6
endif ()
7
7
8
- if (MSVC AND DEFINED OPENTELEMETRY_BUILD_DLL )
8
+ if (DEFINED OPENTELEMETRY_BUILD_DLL )
9
9
add_subdirectory (dll )
10
10
endif ()
Original file line number Diff line number Diff line change 1
1
# Copyright The OpenTelemetry Authors
2
2
# SPDX-License-Identifier: Apache-2.0
3
3
4
+ if (NOT MSVC )
5
+ message (
6
+ FATAL_ERROR
7
+ "The OpenTelemetry C++ SDK for Windows DLL is only supported on MSVC." )
8
+ endif ()
9
+
4
10
set (OPENTELEMETRY_EXPORT_DEF
5
11
"${CMAKE_CURRENT_BINARY_DIR} /opentelemetry_cpp.def" )
6
12
You can’t perform that action at this time.
0 commit comments