File tree Expand file tree Collapse file tree 3 files changed +10
-1
lines changed Expand file tree Collapse file tree 3 files changed +10
-1
lines changed Original file line number Diff line number Diff line change @@ -15,6 +15,9 @@ Increment the:
1515
1616## [ Unreleased]
1717
18+ * [ BUILD] Error out when building DLL without MSVC
19+ [ #3438 ] ( https://github.com/open-telemetry/opentelemetry-cpp/pull/3438 )
20+
1821* [ Metrics SDK] Use nostd::function_ref in AttributesHashMap
1922 [ #3393 ] ( https://github.com/open-telemetry/opentelemetry-cpp/pull/3393 )
2023
Original file line number Diff line number Diff line change @@ -5,6 +5,6 @@ if(WITH_HTTP_CLIENT_CURL)
55 add_subdirectory (http/client/curl)
66endif ()
77
8- if (MSVC AND DEFINED OPENTELEMETRY_BUILD_DLL)
8+ if (DEFINED OPENTELEMETRY_BUILD_DLL)
99 add_subdirectory (dll)
1010endif ()
Original file line number Diff line number Diff line change 11# Copyright The OpenTelemetry Authors
22# SPDX-License-Identifier: Apache-2.0
33
4+ if (NOT MSVC )
5+ message (
6+ FATAL_ERROR
7+ "The OpenTelemetry C++ SDK for Windows DLL is only supported on MSVC." )
8+ endif ()
9+
410set (OPENTELEMETRY_EXPORT_DEF
511 "${CMAKE_CURRENT_BINARY_DIR} /opentelemetry_cpp.def" )
612
You can’t perform that action at this time.
0 commit comments