Fix valgrind issues with gtest

psx95 · psx95 · commit c6a86334c135 · 2024-10-31T20:03:52.000Z
diff --git a/api/test/trace/propagation/detail/string_test.cc b/api/test/trace/propagation/detail/string_test.cc
@@ -7,6 +7,10 @@
 
 #include "opentelemetry/nostd/string_view.h"
 
+// There is an issue with using googletest and valgrind where if a struct used as a parameter has
+// any padding, it causes valgrind to report it as "use of uninitialized value".
+// pragma pack instructs compilers not to insert additional padding
+#pragma pack(1)
 struct SplitStringTestData
 {
   opentelemetry::nostd::string_view input;

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,10 @@`
`7`	`7`
`8`	`8`	`#include "opentelemetry/nostd/string_view.h"`
`9`	`9`
	`10`	`+// There is an issue with using googletest and valgrind where if a struct used as a parameter has`
	`11`	`+// any padding, it causes valgrind to report it as "use of uninitialized value".`
	`12`	`+// pragma pack instructs compilers not to insert additional padding`
	`13`	`+#pragma pack(1)`
`10`	`14`	`struct SplitStringTestData`
`11`	`15`	`{`
`12`	`16`	`opentelemetry::nostd::string_view input;`