fix clang-tidy cppcoreguidelines-special-member-functions warnings in otlp http

Author: dbarker

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_client.h

@@ -159,6 +159,10 @@ class OtlpHttpClient
   explicit OtlpHttpClient(OtlpHttpClientOptions &&options);
 
   ~OtlpHttpClient();
+  OtlpHttpClient(const OtlpHttpClient &)            = delete;
+  OtlpHttpClient &operator=(const OtlpHttpClient &) = delete;
+  OtlpHttpClient(OtlpHttpClient &&)                 = delete;
+  OtlpHttpClient &operator=(OtlpHttpClient &&)      = delete;
 
   /**
    * Sync export
@@ -230,28 +234,13 @@ class OtlpHttpClient
     std::shared_ptr<opentelemetry::ext::http::client::Session> session;
     std::shared_ptr<opentelemetry::ext::http::client::EventHandler> event_handle;
 
-    inline HttpSessionData() = default;
-
-    inline explicit HttpSessionData(
-        std::shared_ptr<opentelemetry::ext::http::client::Session> &&input_session,
-        std::shared_ptr<opentelemetry::ext::http::client::EventHandler> &&input_handle)
+    explicit HttpSessionData(
+        std::shared_ptr<opentelemetry::ext::http::client::Session> input_session,
+        std::shared_ptr<opentelemetry::ext::http::client::EventHandler> input_handle)
     {
       session.swap(input_session);
       event_handle.swap(input_handle);
     }
-
-    inline HttpSessionData(HttpSessionData &&other)
-    {
-      session.swap(other.session);
-      event_handle.swap(other.event_handle);
-    }
-
-    inline HttpSessionData &operator=(HttpSessionData &&other) noexcept
-    {
-      session.swap(other.session);
-      event_handle.swap(other.event_handle);
-      return *this;
-    }
   };
 
   /**

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter_options.h

@@ -33,7 +33,6 @@ namespace otlp
 struct OPENTELEMETRY_EXPORT OtlpHttpExporterOptions
 {
   OtlpHttpExporterOptions();
-  ~OtlpHttpExporterOptions();
 
   /** The endpoint to export to. */
   std::string url;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter_runtime_options.h

@@ -19,8 +19,7 @@ namespace otlp
  */
 struct OPENTELEMETRY_EXPORT OtlpHttpExporterRuntimeOptions
 {
-  OtlpHttpExporterRuntimeOptions()  = default;
-  ~OtlpHttpExporterRuntimeOptions() = default;
+  OtlpHttpExporterRuntimeOptions() = default;
 
   std::shared_ptr<sdk::common::ThreadInstrumentation> thread_instrumentation =
       std::shared_ptr<sdk::common::ThreadInstrumentation>(nullptr);

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_exporter_options.h

@@ -33,7 +33,6 @@ namespace otlp
 struct OPENTELEMETRY_EXPORT OtlpHttpLogRecordExporterOptions
 {
   OtlpHttpLogRecordExporterOptions();
-  ~OtlpHttpLogRecordExporterOptions();
 
   /** The endpoint to export to. */
   std::string url;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_exporter_runtime_options.h

@@ -19,8 +19,7 @@ namespace otlp
  */
 struct OPENTELEMETRY_EXPORT OtlpHttpLogRecordExporterRuntimeOptions
 {
-  OtlpHttpLogRecordExporterRuntimeOptions()  = default;
-  ~OtlpHttpLogRecordExporterRuntimeOptions() = default;
+  OtlpHttpLogRecordExporterRuntimeOptions() = default;
 
   std::shared_ptr<sdk::common::ThreadInstrumentation> thread_instrumentation =
       std::shared_ptr<sdk::common::ThreadInstrumentation>(nullptr);

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter_options.h

@@ -34,7 +34,6 @@ namespace otlp
 struct OPENTELEMETRY_EXPORT OtlpHttpMetricExporterOptions
 {
   OtlpHttpMetricExporterOptions();
-  ~OtlpHttpMetricExporterOptions();
 
   /** The endpoint to export to. */
   std::string url;

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter_runtime_options.h

@@ -19,8 +19,7 @@ namespace otlp
  */
 struct OPENTELEMETRY_EXPORT OtlpHttpMetricExporterRuntimeOptions
 {
-  OtlpHttpMetricExporterRuntimeOptions()  = default;
-  ~OtlpHttpMetricExporterRuntimeOptions() = default;
+  OtlpHttpMetricExporterRuntimeOptions() = default;
 
   std::shared_ptr<sdk::common::ThreadInstrumentation> thread_instrumentation =
       std::shared_ptr<sdk::common::ThreadInstrumentation>(nullptr);

exporters/otlp/src/otlp_http_client.cc

@@ -1000,9 +1000,8 @@ OtlpHttpClient::createSession(
 
   // Returns the created session data
   return HttpSessionData{
-      std::move(session),
-      std::shared_ptr<opentelemetry::ext::http::client::EventHandler>{
-          new ResponseHandler(std::move(result_callback), options_.console_debug)}};
+      session, std::shared_ptr<opentelemetry::ext::http::client::EventHandler>{
+                   new ResponseHandler(std::move(result_callback), options_.console_debug)}};
 }
 
 void OtlpHttpClient::addSession(HttpSessionData &&session_data) noexcept

exporters/otlp/src/otlp_http_exporter_options.cc

@@ -43,8 +43,6 @@ OtlpHttpExporterOptions::OtlpHttpExporterOptions()
       retry_policy_backoff_multiplier(GetOtlpDefaultTracesRetryBackoffMultiplier())
 {}
 
-OtlpHttpExporterOptions::~OtlpHttpExporterOptions() {}
-
 }  // namespace otlp
 }  // namespace exporter
 OPENTELEMETRY_END_NAMESPACE

exporters/otlp/src/otlp_http_log_record_exporter_options.cc

@@ -43,8 +43,6 @@ OtlpHttpLogRecordExporterOptions::OtlpHttpLogRecordExporterOptions()
       retry_policy_backoff_multiplier(GetOtlpDefaultLogsRetryBackoffMultiplier())
 {}
 
-OtlpHttpLogRecordExporterOptions::~OtlpHttpLogRecordExporterOptions() {}
-
 }  // namespace otlp
 }  // namespace exporter
 OPENTELEMETRY_END_NAMESPACE