Apply suggestions from code review

marcalff · web-flow · commit d4531beda9b3 · 2024-10-17T09:05:43.000+02:00
diff --git a/exporters/memory/src/in_memory_metric_data.cc b/exporters/memory/src/in_memory_metric_data.cc
@@ -31,6 +31,7 @@ void SimpleAggregateInMemoryMetricData::Add(std::unique_ptr<ResourceMetrics> res
       const auto &metric = m.instrument_descriptor.name_;
       for (const auto &pda : m.point_data_attr_)
       {
+        // NOTE: Explicit type conversion added for C++11 (gcc 4.8)
         data_[std::tuple<std::string, std::string>{scope, metric}].insert(
             {pda.attributes, pda.point_data});
       }
@@ -42,6 +43,7 @@ const SimpleAggregateInMemoryMetricData::AttributeToPoint &SimpleAggregateInMemo
     const std::string &scope,
     const std::string &metric)
 {
+  // NOTE: Explicit type conversion added for C++11 (gcc 4.8)
   return data_[std::tuple<std::string, std::string>{scope, metric}];
 }
 

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ void SimpleAggregateInMemoryMetricData::Add(std::unique_ptr<ResourceMetrics> res`
`31`	`31`	`const auto &metric = m.instrument_descriptor.name_;`
`32`	`32`	`for (const auto &pda : m.point_data_attr_)`
`33`	`33`	`{`
	`34`	`+ // NOTE: Explicit type conversion added for C++11 (gcc 4.8)`
`34`	`35`	`data_[std::tuple<std::string, std::string>{scope, metric}].insert(`
`35`	`36`	`{pda.attributes, pda.point_data});`
`36`	`37`	`}`
`@@ -42,6 +43,7 @@ const SimpleAggregateInMemoryMetricData::AttributeToPoint &SimpleAggregateInMemo`
`42`	`43`	`const std::string &scope,`
`43`	`44`	`const std::string &metric)`
`44`	`45`	`{`
	`46`	`+ // NOTE: Explicit type conversion added for C++11 (gcc 4.8)`
`45`	`47`	`return data_[std::tuple<std::string, std::string>{scope, metric}];`
`46`	`48`	`}`
`47`	`49`