Fix test_tracestate_member_count_limit

psx95 · psx95 · commit ff8d0fa9d5b7 · 2024-10-30T17:01:24.000Z
diff --git a/api/include/opentelemetry/trace/trace_state.h b/api/include/opentelemetry/trace/trace_state.h
@@ -59,7 +59,8 @@ class OPENTELEMETRY_EXPORT TraceState
     size_t cnt = kv_str_tokenizer.NumTokens();  // upper bound on number of kv pairs
     if (cnt > kMaxKeyValuePairs)
     {
-      cnt = kMaxKeyValuePairs;
+      // trace state should be discarded if count exceeds
+      return GetDefault();
     }
 
     nostd::shared_ptr<TraceState> ts(new TraceState(cnt));

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,8 @@ class OPENTELEMETRY_EXPORT TraceState`
`59`	`59`	`size_t cnt = kv_str_tokenizer.NumTokens(); // upper bound on number of kv pairs`
`60`	`60`	`if (cnt > kMaxKeyValuePairs)`
`61`	`61`	`{`
`62`		`- cnt = kMaxKeyValuePairs;`
	`62`	`+ // trace state should be discarded if count exceeds`
	`63`	`+ return GetDefault();`
`63`	`64`	`}`
`64`	`65`
`65`	`66`	`nostd::shared_ptr<TraceState> ts(new TraceState(cnt));`