nlohmann_json not found when used opentelemetry-cpp as external project

[chuandew]

Describe your environment

chuande@dingo11 ~ » gcc --version
gcc (GCC) 13.1.1 20230614 (Red Hat 13.1.1-4)
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

chuande@dingo11 ~ » uname -a
Linux dingo11.com 4.18.0-513.9.1.el8_9.x86_64 #1 SMP Wed Nov 29 18:55:19 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
chuande@dingo11 ~ » cat /etc/redhat-release 
Rocky Linux release 8.9 (Green Obsidian)

opentelemetry-cpp v1.18.0

Steps to reproduce

git clone https://github.com/chuandew/dingofs.git

git checkout add_opentele

git submodule update --init --recursive

cd third-party

mkdir build

cd build 

cmake ..

make -j 64 VERBOSE=1

What is the expected behavior?
cmake configue success
What is the actual behavior?
error message

CMake Error at /home/chuande/workspace/dingofs/third-party/installed/lib/cmake/opentelemetry-cpp/opentelemetry-cpp-target.cmake:142 (set_target_properties):                                                                         
  The link interface of target "opentelemetry-cpp::otlp_http_client"
  contains:

    nlohmann_json::nlohmann_json

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /home/chuande/workspace/dingofs/third-party/installed/lib/cmake/opentelemetry-cpp/opentelemetry-cpp-config.cmake:131 (include)                                                                                                     
  cmake/external_dependencies.cmake:114 (find_package)
  CMakeLists.txt:199 (include)

Additional context

[zurex]

Hi @chuandew, would you mind double check the command that you provide? It failed in my side when compile target: rocksdb

[chuandew]

Hi @zurex , sorry for wrong step for produce, the right step, and make sure in the right branch : add_opentele

git clone https://github.com/chuandew/dingofs.git

git checkout add_opentele

git submodule update --init --recursive

cd third-party

mkdir build

cd build 

cmake ..

make -j 64 VERBOSE=1

or you can use our dev docker images, first download dinogfs and it's third party, then

docker run -ti --rm -v $(pwd)/dingofs:/dingofs  dingodatabase/dingofs-base:rocky9 /bin/bash

cd /dingofs

cd third-party

mkdir build

cd build 

cmake ..

make -j 64 VERBOSE=1

dingodatabase/dingofs-base:rocky9 docker file is https://github.com/chuandew/dingofs/blob/add_opentele/docker/base/Dockerfile

[chuandew]

I found it's configure ok if I call find_package(nlohmann_json REQUIRED) in project.

[chuandew]

Maybe aws sdk should call find_package(nlohmann_json REQUIRED)
Related issue: aws/aws-sdk-cpp#3213

[zurex]

@chuandew good to hear that, feel free to close this issue.

[chuandew]

@chuandew good to hear that, feel free to close this issue.

Aws has no plan to call find_package(nlohmann_json REQUIRED)
aws/aws-sdk-cpp#3213 (comment)

Maybe in opentelemetry-cpp cmake should trigger this?

[dbarker]

#3220 makes nlohmann_json a build time only dependency of opentelemetry-cpp::otlp_http_client and will address this issue.