Skip to content

SDK's MetricProducer API needs cleanupΒ #3412

@yashykt

Description

@yashykt

#3235 added an optional parameter to the constructor of an interface.

This added parameter is unused, and doesn't seem useful in the interface. It should be the responsibility of the implementations of this class to accept a metric filter as a parameter.

In its current form, both the child class MetricCollector and the interface MetricProducer have a member metric_filter_ which seems to be an oversight.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtriage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions