-
Notifications
You must be signed in to change notification settings - Fork 501
Closed
Labels
bugSomething isn't workingSomething isn't workingtriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
#3235 added an optional parameter to the constructor of an interface.
This added parameter is unused, and doesn't seem useful in the interface. It should be the responsibility of the implementations of this class to accept a metric filter as a parameter.
In its current form, both the child class MetricCollector
and the interface MetricProducer
have a member metric_filter_
which seems to be an oversight.
ThomsonTan and psx95
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingtriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.