-
Notifications
You must be signed in to change notification settings - Fork 509
Closed
Labels
bugSomething isn't workingSomething isn't workingtriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
It seems the PR #3421 change target_link_libraries(common_foo_library PUBLIC opentelemetry_api) to target_link_libraries(common_foo_library PRIVATE opentelemetry-cpp::api), but the dependency should be PUBLIC because the compile definitions on opentelemtry-cpp::api target (like OPENTELEMETRY_STL_VERSION) should be propagated from API to the final executable target which configures the SDK, or the API header file will be inconsistent in the executable and the common library.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingtriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.