-
Notifications
You must be signed in to change notification settings - Fork 509
Open
Labels
bugSomething isn't workingSomething isn't workingtriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
Hi, while going through the getting started docs I noticed that the example code listed there for how to register a custom global log handler is outdated and does not compile anymore. Specifically the SetLogHandler signature seems to have changed to use nostd::shared_ptr instead of non-pointer value. Here's the offending line:
opentelemetry::sdk::common::internal_log::GlobalLogHandler::SetLogHandler(CustomLogHandler());Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingtriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.