v1.25 regression: Build break on Windows with Visual Studio 2022 #3861
Description
Below PR, released with v1.25, breaks existing applications on Windows.
[EXPORTER] Add support for otlp exporter collection limits
#3816
Steps to Reproduce
-
Follow this article to integrate vcpkg with MSBuild/VisualStudio.
Tutorial: Install and use packages with MSBuild in Visual Studio
https://learn.microsoft.com/en-us/vcpkg/get_started/get-started-msbuild.\vcpkg.exe integrate install -
Create a C++ console application in Visual Studio 2022.
-
In Visual Studio, open Tools → Command Line → Developer Command Prompt.
-
Run:
vcpkg new --application vcpkg add port opentelemetry-cpp[geneva]
Ensure the commit hash in your vcpkg-configuration.json file includes v1.25 release.
-
In the project Property Pages, set: vcpkg → Use Vcpkg Manifest = Yes
-
Include the following code in your .cpp file: https://github.com/lukeina2z/playground/blob/main/cpp/OTelTestAppLite/main.cpp
You can use that project for this repro. -
Build the project.
Expected Result
The project builds successfully with no errors.
Actual Result
The build fails with error C2589:
'(': illegal token on right side of '::'
Note: The problem does not exist in v1.24. For quick testing, switch the vcpkg baseline in the config file:
1.25 build break:
"baseline": "0a434205c521ca43d66921271ae2a1d051e718a5",
1.24 good build:
"baseline": "de51e6bfa96e1245f2a969a8cde249baac89f7be",