From b7ba5179d718cf75537a7d3eeb16ed0be6c5fd14 Mon Sep 17 00:00:00 2001 From: Ehsan Saei <71217171+esigo@users.noreply.github.com> Date: Fri, 18 Apr 2025 22:22:39 +0200 Subject: [PATCH 1/3] [CI] Benchmark upload broken after action link hardening --- .github/workflows/benchmark.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 75caf3a402..6188af016a 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -1,6 +1,6 @@ name: OpenTelemetry-cpp benchmarks on: - push: + pull_request: branches: - main @@ -48,7 +48,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - - uses: actions/download-artifact@2a5974104b6d5dbdb2f9468a3e54da3bdd241578 # v4.2.1 + - uses: actions/download-artifact@95815c38cf2ff2164869cbab79da8d1f422bc89e # main March 2025 with: name: benchmark_results path: benchmarks From 529d13052574992904b1b9d921e5c8539ffc70fa Mon Sep 17 00:00:00 2001 From: Ehsan Saei <71217171+esigo@users.noreply.github.com> Date: Fri, 18 Apr 2025 22:42:09 +0200 Subject: [PATCH 2/3] bump upload --- .github/workflows/benchmark.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 6188af016a..cf5a9a9807 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -35,7 +35,7 @@ jobs: mv api-benchmark_result.json benchmarks mv sdk-benchmark_result.json benchmarks mv exporters-benchmark_result.json benchmarks - - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + - uses: actions/upload-artifact@6027e3dd177782cd8ab9af838c04fd81a07f1d47 # main March 2025 with: name: benchmark_results path: benchmarks From 5a8c1e4222215bf6618c36f6718d60f1788805bd Mon Sep 17 00:00:00 2001 From: Ehsan Saei <71217171+esigo@users.noreply.github.com> Date: Sat, 19 Apr 2025 18:06:40 +0200 Subject: [PATCH 3/3] revert on --- .github/workflows/benchmark.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index cf5a9a9807..77bf0719c1 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -1,6 +1,6 @@ name: OpenTelemetry-cpp benchmarks on: - pull_request: + push: branches: - main