Skip to content

[SDK] Fix Base2ExponentialHistogramAggregation Merge with empty buckets #3425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2025
Merged

[SDK] Fix Base2ExponentialHistogramAggregation Merge with empty buckets #3425

merged 3 commits into from
May 20, 2025

Conversation

@dbarker
Copy link
Member

@dbarker dbarker commented May 19, 2025 •
edited
Loading

Fixes #3424

Changes

  • Add a test to cover merging two Base2ExponentialHistogramAggregation instances where one has empty buckets
  • Update Base2ExponentialHistogramAggregation::Merge to shortcut if merging a histogram with no counts
  • Check if buckets are empty before down scaling

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify
Copy link

netlify bot commented May 19, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 0832409
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/682b8c5a08204b0008158314

@dbarker dbarker mentioned this pull request May 19, 2025
Closed
@codecov
Copy link

codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (82ec2a5) to head (0832409).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3425      +/-   ##
==========================================
+ Coverage   90.05%   90.06%   +0.02%     
==========================================
  Files         212      212              
  Lines        6932     6939       +7     
==========================================
+ Hits         6242     6249       +7     
  Misses        690      690
Files with missing lines Coverage Δ
...egation/base2_exponential_histogram_aggregation.cc 90.91% <100.00%> (+0.28%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff mentioned this pull request May 19, 2025
Closed
@dbarker dbarker marked this pull request as ready for review May 19, 2025 20:51
@dbarker dbarker requested a review from a team as a code owner May 19, 2025 20:51
@dbarker
Copy link
Member Author

dbarker commented May 19, 2025

Hi @ethandmd, Could you help review this PR? Thanks!

@ethandmd
Copy link
Contributor

lgtm, thanks @dbarker!

lalitb
lalitb approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@marcalff marcalff merged commit 2faa400 into open-telemetry:main May 20, 2025
67 checks passed
@malkia malkia mentioned this pull request May 20, 2025
Merged
3 tasks
@dbarker dbarker deleted the fix_exponential_histogram_merge_with_empty branch May 20, 2025 17:25
@BrewTestBot BrewTestBot mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitb lalitb lalitb approved these changes

@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Base2ExponentialHistogramAggregation Merge fails with empty bucket aggregations

4 participants

@dbarker @ethandmd @lalitb @marcalff