diff --git a/.github/workflows/clang-tidy.yaml b/.github/workflows/clang-tidy.yaml index 9e976c4a54..11011be89c 100644 --- a/.github/workflows/clang-tidy.yaml +++ b/.github/workflows/clang-tidy.yaml @@ -17,9 +17,9 @@ jobs: matrix: include: - cmake_options: all-options-abiv1-preview - warning_limit: 62 + warning_limit: 61 - cmake_options: all-options-abiv2-preview - warning_limit: 62 + warning_limit: 61 steps: - name: Harden the runner (Audit all outbound calls) uses: step-security/harden-runner@6c439dc8bdf85cadbbce9ed30d1c7b959517bc49 # v2.12.2 diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_exporter_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_exporter_options.h index 1dd2ebfd7f..b4c4f36c01 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_exporter_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_exporter_options.h @@ -22,6 +22,11 @@ namespace otlp struct OPENTELEMETRY_EXPORT OtlpFileExporterOptions : public OtlpFileClientOptions { OtlpFileExporterOptions(); + OtlpFileExporterOptions(const OtlpFileExporterOptions &) = default; + OtlpFileExporterOptions(OtlpFileExporterOptions &&) = default; + OtlpFileExporterOptions &operator=(const OtlpFileExporterOptions &) = default; + OtlpFileExporterOptions &operator=(OtlpFileExporterOptions &&) = default; + ~OtlpFileExporterOptions() override; }; } // namespace otlp diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_log_record_exporter_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_log_record_exporter_options.h index caeb3daaf4..cca6fc8e10 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_log_record_exporter_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_log_record_exporter_options.h @@ -22,6 +22,11 @@ namespace otlp struct OPENTELEMETRY_EXPORT OtlpFileLogRecordExporterOptions : public OtlpFileClientOptions { OtlpFileLogRecordExporterOptions(); + OtlpFileLogRecordExporterOptions(const OtlpFileLogRecordExporterOptions &) = default; + OtlpFileLogRecordExporterOptions(OtlpFileLogRecordExporterOptions &&) = default; + OtlpFileLogRecordExporterOptions &operator=(const OtlpFileLogRecordExporterOptions &) = default; + OtlpFileLogRecordExporterOptions &operator=(OtlpFileLogRecordExporterOptions &&) = default; + ~OtlpFileLogRecordExporterOptions() override; }; } // namespace otlp diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_metric_exporter_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_metric_exporter_options.h index 3e946e482b..d89dcbd3cf 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_metric_exporter_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_metric_exporter_options.h @@ -23,6 +23,11 @@ namespace otlp struct OPENTELEMETRY_EXPORT OtlpFileMetricExporterOptions : public OtlpFileClientOptions { OtlpFileMetricExporterOptions(); + OtlpFileMetricExporterOptions(const OtlpFileMetricExporterOptions &) = default; + OtlpFileMetricExporterOptions(OtlpFileMetricExporterOptions &&) = default; + OtlpFileMetricExporterOptions &operator=(const OtlpFileMetricExporterOptions &) = default; + OtlpFileMetricExporterOptions &operator=(OtlpFileMetricExporterOptions &&) = default; + ~OtlpFileMetricExporterOptions() override; PreferredAggregationTemporality aggregation_temporality; }; diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client.h index 159ac0227d..2a60a28a21 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client.h @@ -106,8 +106,11 @@ class OtlpGrpcClient { public: OtlpGrpcClient(const OtlpGrpcClientOptions &options); - ~OtlpGrpcClient(); + OtlpGrpcClient(const OtlpGrpcClient &) = delete; + OtlpGrpcClient(OtlpGrpcClient &&) = delete; + OtlpGrpcClient &operator=(const OtlpGrpcClient &) = delete; + OtlpGrpcClient &operator=(OtlpGrpcClient &&) = delete; static std::string GetGrpcTarget(const std::string &endpoint); diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client_options.h index 0ffe5ba72e..f377ef7d09 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client_options.h @@ -23,11 +23,18 @@ namespace otlp struct OtlpGrpcClientOptions { + virtual ~OtlpGrpcClientOptions() = default; + OtlpGrpcClientOptions() = default; + OtlpGrpcClientOptions(const OtlpGrpcClientOptions &) = default; + OtlpGrpcClientOptions(OtlpGrpcClientOptions &&) = default; + OtlpGrpcClientOptions &operator=(const OtlpGrpcClientOptions &) = default; + OtlpGrpcClientOptions &operator=(OtlpGrpcClientOptions &&) = default; + /** The endpoint to export to. */ std::string endpoint; /** Use SSL. */ - bool use_ssl_credentials; + bool use_ssl_credentials{}; /** CA CERT, path to a file. */ std::string ssl_credentials_cacert_path; @@ -64,14 +71,14 @@ struct OtlpGrpcClientOptions std::string user_agent; /** max number of threads that can be allocated from this */ - std::size_t max_threads; + std::size_t max_threads{}; /** Compression type. */ std::string compression; #ifdef ENABLE_ASYNC_EXPORT // Concurrent requests - std::size_t max_concurrent_requests; + std::size_t max_concurrent_requests{}; #endif /** The maximum number of call attempts, including the original attempt. */ diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_exporter.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_exporter.h index 1022b0dc8f..f698b8fb5d 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_exporter.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_exporter.h @@ -58,6 +58,10 @@ class OtlpGrpcExporter final : public opentelemetry::sdk::trace::SpanExporter explicit OtlpGrpcExporter(const OtlpGrpcExporterOptions &options); ~OtlpGrpcExporter() override; + OtlpGrpcExporter(const OtlpGrpcExporter &) = delete; + OtlpGrpcExporter(OtlpGrpcExporter &&) = delete; + OtlpGrpcExporter &operator=(const OtlpGrpcExporter &) = delete; + OtlpGrpcExporter &operator=(OtlpGrpcExporter &&) = delete; /** * Create a span recordable. diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_exporter_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_exporter_options.h index b2556f1f76..407296e251 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_exporter_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_exporter_options.h @@ -24,7 +24,11 @@ namespace otlp struct OPENTELEMETRY_EXPORT OtlpGrpcExporterOptions : public OtlpGrpcClientOptions { OtlpGrpcExporterOptions(); - ~OtlpGrpcExporterOptions(); + OtlpGrpcExporterOptions(const OtlpGrpcExporterOptions &) = default; + OtlpGrpcExporterOptions(OtlpGrpcExporterOptions &&) = default; + OtlpGrpcExporterOptions &operator=(const OtlpGrpcExporterOptions &) = default; + OtlpGrpcExporterOptions &operator=(OtlpGrpcExporterOptions &&) = default; + ~OtlpGrpcExporterOptions() override; }; } // namespace otlp diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter.h index da278ccd28..888c368b28 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter.h @@ -57,6 +57,10 @@ class OtlpGrpcLogRecordExporter : public opentelemetry::sdk::logs::LogRecordExpo OtlpGrpcLogRecordExporter(const OtlpGrpcLogRecordExporterOptions &options); ~OtlpGrpcLogRecordExporter() override; + OtlpGrpcLogRecordExporter(const OtlpGrpcLogRecordExporter &) = delete; + OtlpGrpcLogRecordExporter(OtlpGrpcLogRecordExporter &&) = delete; + OtlpGrpcLogRecordExporter &operator=(const OtlpGrpcLogRecordExporter &) = delete; + OtlpGrpcLogRecordExporter &operator=(OtlpGrpcLogRecordExporter &&) = delete; /** * Creates a recordable that stores the data in protobuf. diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter_options.h index 8438bb080d..5f5b2b0a1f 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter_options.h @@ -24,7 +24,11 @@ namespace otlp struct OPENTELEMETRY_EXPORT OtlpGrpcLogRecordExporterOptions : public OtlpGrpcClientOptions { OtlpGrpcLogRecordExporterOptions(); - ~OtlpGrpcLogRecordExporterOptions(); + OtlpGrpcLogRecordExporterOptions(const OtlpGrpcLogRecordExporterOptions &) = default; + OtlpGrpcLogRecordExporterOptions(OtlpGrpcLogRecordExporterOptions &&) = default; + OtlpGrpcLogRecordExporterOptions &operator=(const OtlpGrpcLogRecordExporterOptions &) = default; + OtlpGrpcLogRecordExporterOptions &operator=(OtlpGrpcLogRecordExporterOptions &&) = default; + ~OtlpGrpcLogRecordExporterOptions() override; }; } // namespace otlp diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter.h index d3d857b3f0..4272bf2126 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter.h @@ -55,6 +55,10 @@ class OtlpGrpcMetricExporter : public opentelemetry::sdk::metrics::PushMetricExp explicit OtlpGrpcMetricExporter(const OtlpGrpcMetricExporterOptions &options); ~OtlpGrpcMetricExporter() override; + OtlpGrpcMetricExporter(const OtlpGrpcMetricExporter &) = delete; + OtlpGrpcMetricExporter(OtlpGrpcMetricExporter &&) = delete; + OtlpGrpcMetricExporter &operator=(const OtlpGrpcMetricExporter &) = delete; + OtlpGrpcMetricExporter &operator=(OtlpGrpcMetricExporter &&) = delete; /** * Get the AggregationTemporality for exporter diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter_options.h index 22be580972..82dcab3881 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter_options.h @@ -25,7 +25,11 @@ namespace otlp struct OPENTELEMETRY_EXPORT OtlpGrpcMetricExporterOptions : public OtlpGrpcClientOptions { OtlpGrpcMetricExporterOptions(); - ~OtlpGrpcMetricExporterOptions(); + OtlpGrpcMetricExporterOptions(const OtlpGrpcMetricExporterOptions &) = default; + OtlpGrpcMetricExporterOptions(OtlpGrpcMetricExporterOptions &&) = default; + OtlpGrpcMetricExporterOptions &operator=(const OtlpGrpcMetricExporterOptions &) = default; + OtlpGrpcMetricExporterOptions &operator=(OtlpGrpcMetricExporterOptions &&) = default; + ~OtlpGrpcMetricExporterOptions() override; /** Preferred Aggregation Temporality. */ PreferredAggregationTemporality aggregation_temporality; diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_client.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_client.h index 5cb5fdfbc6..dff27d92f2 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_client.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_client.h @@ -159,6 +159,10 @@ class OtlpHttpClient explicit OtlpHttpClient(OtlpHttpClientOptions &&options); ~OtlpHttpClient(); + OtlpHttpClient(const OtlpHttpClient &) = delete; + OtlpHttpClient &operator=(const OtlpHttpClient &) = delete; + OtlpHttpClient(OtlpHttpClient &&) = delete; + OtlpHttpClient &operator=(OtlpHttpClient &&) = delete; /** * Sync export @@ -230,28 +234,13 @@ class OtlpHttpClient std::shared_ptr session; std::shared_ptr event_handle; - inline HttpSessionData() = default; + HttpSessionData() = default; - inline explicit HttpSessionData( + explicit HttpSessionData( std::shared_ptr &&input_session, std::shared_ptr &&input_handle) - { - session.swap(input_session); - event_handle.swap(input_handle); - } - - inline HttpSessionData(HttpSessionData &&other) - { - session.swap(other.session); - event_handle.swap(other.event_handle); - } - - inline HttpSessionData &operator=(HttpSessionData &&other) noexcept - { - session.swap(other.session); - event_handle.swap(other.event_handle); - return *this; - } + : session(std::move(input_session)), event_handle(std::move(input_handle)) + {} }; /** diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter_options.h index 52f2208575..251387e124 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter_options.h @@ -33,6 +33,10 @@ namespace otlp struct OPENTELEMETRY_EXPORT OtlpHttpExporterOptions { OtlpHttpExporterOptions(); + OtlpHttpExporterOptions(const OtlpHttpExporterOptions &) = default; + OtlpHttpExporterOptions(OtlpHttpExporterOptions &&) = default; + OtlpHttpExporterOptions &operator=(const OtlpHttpExporterOptions &) = default; + OtlpHttpExporterOptions &operator=(OtlpHttpExporterOptions &&) = default; ~OtlpHttpExporterOptions(); /** The endpoint to export to. */ diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter_runtime_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter_runtime_options.h index 02ec76acf9..b5e11b377e 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter_runtime_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter_runtime_options.h @@ -19,8 +19,7 @@ namespace otlp */ struct OPENTELEMETRY_EXPORT OtlpHttpExporterRuntimeOptions { - OtlpHttpExporterRuntimeOptions() = default; - ~OtlpHttpExporterRuntimeOptions() = default; + OtlpHttpExporterRuntimeOptions() = default; std::shared_ptr thread_instrumentation = std::shared_ptr(nullptr); diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_exporter_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_exporter_options.h index 78160deeb0..14c7f1a7cf 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_exporter_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_exporter_options.h @@ -33,6 +33,10 @@ namespace otlp struct OPENTELEMETRY_EXPORT OtlpHttpLogRecordExporterOptions { OtlpHttpLogRecordExporterOptions(); + OtlpHttpLogRecordExporterOptions(const OtlpHttpLogRecordExporterOptions &) = default; + OtlpHttpLogRecordExporterOptions(OtlpHttpLogRecordExporterOptions &&) = default; + OtlpHttpLogRecordExporterOptions &operator=(const OtlpHttpLogRecordExporterOptions &) = default; + OtlpHttpLogRecordExporterOptions &operator=(OtlpHttpLogRecordExporterOptions &&) = default; ~OtlpHttpLogRecordExporterOptions(); /** The endpoint to export to. */ diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_exporter_runtime_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_exporter_runtime_options.h index b5ef2ed967..09213731af 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_exporter_runtime_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_log_record_exporter_runtime_options.h @@ -19,8 +19,7 @@ namespace otlp */ struct OPENTELEMETRY_EXPORT OtlpHttpLogRecordExporterRuntimeOptions { - OtlpHttpLogRecordExporterRuntimeOptions() = default; - ~OtlpHttpLogRecordExporterRuntimeOptions() = default; + OtlpHttpLogRecordExporterRuntimeOptions() = default; std::shared_ptr thread_instrumentation = std::shared_ptr(nullptr); diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter.h index 8733a740a9..72774f3606 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter.h @@ -72,7 +72,7 @@ class OtlpHttpMetricExporter final : public opentelemetry::sdk::metrics::PushMet OtlpHttpMetricExporterRuntimeOptions runtime_options_; // Aggregation Temporality Selector - const sdk::metrics::AggregationTemporalitySelector aggregation_temporality_selector_; + sdk::metrics::AggregationTemporalitySelector aggregation_temporality_selector_; // Object that stores the HTTP sessions that have been created std::unique_ptr http_client_; diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter_options.h index 255491a39f..c0b8a39eba 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter_options.h @@ -34,6 +34,10 @@ namespace otlp struct OPENTELEMETRY_EXPORT OtlpHttpMetricExporterOptions { OtlpHttpMetricExporterOptions(); + OtlpHttpMetricExporterOptions(const OtlpHttpMetricExporterOptions &) = default; + OtlpHttpMetricExporterOptions(OtlpHttpMetricExporterOptions &&) = default; + OtlpHttpMetricExporterOptions &operator=(const OtlpHttpMetricExporterOptions &) = default; + OtlpHttpMetricExporterOptions &operator=(OtlpHttpMetricExporterOptions &&) = default; ~OtlpHttpMetricExporterOptions(); /** The endpoint to export to. */ diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter_runtime_options.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter_runtime_options.h index c0e91a342c..a26d54b9ff 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter_runtime_options.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter_runtime_options.h @@ -19,8 +19,7 @@ namespace otlp */ struct OPENTELEMETRY_EXPORT OtlpHttpMetricExporterRuntimeOptions { - OtlpHttpMetricExporterRuntimeOptions() = default; - ~OtlpHttpMetricExporterRuntimeOptions() = default; + OtlpHttpMetricExporterRuntimeOptions() = default; std::shared_ptr thread_instrumentation = std::shared_ptr(nullptr); diff --git a/exporters/otlp/src/otlp_file_exporter_options.cc b/exporters/otlp/src/otlp_file_exporter_options.cc index ddc371fdda..b5e9fa725f 100644 --- a/exporters/otlp/src/otlp_file_exporter_options.cc +++ b/exporters/otlp/src/otlp_file_exporter_options.cc @@ -27,6 +27,8 @@ OtlpFileExporterOptions::OtlpFileExporterOptions() backend_options = fs_options; } +OtlpFileExporterOptions::~OtlpFileExporterOptions() {} + } // namespace otlp } // namespace exporter OPENTELEMETRY_END_NAMESPACE diff --git a/exporters/otlp/src/otlp_file_log_record_exporter_options.cc b/exporters/otlp/src/otlp_file_log_record_exporter_options.cc index abc628dc02..be794b2872 100644 --- a/exporters/otlp/src/otlp_file_log_record_exporter_options.cc +++ b/exporters/otlp/src/otlp_file_log_record_exporter_options.cc @@ -27,6 +27,8 @@ OtlpFileLogRecordExporterOptions::OtlpFileLogRecordExporterOptions() backend_options = fs_options; } +OtlpFileLogRecordExporterOptions::~OtlpFileLogRecordExporterOptions() {} + } // namespace otlp } // namespace exporter OPENTELEMETRY_END_NAMESPACE diff --git a/exporters/otlp/src/otlp_file_metric_exporter_options.cc b/exporters/otlp/src/otlp_file_metric_exporter_options.cc index 22d2cc7c49..e1b1f5ca7a 100644 --- a/exporters/otlp/src/otlp_file_metric_exporter_options.cc +++ b/exporters/otlp/src/otlp_file_metric_exporter_options.cc @@ -28,6 +28,8 @@ OtlpFileMetricExporterOptions::OtlpFileMetricExporterOptions() backend_options = fs_options; } +OtlpFileMetricExporterOptions::~OtlpFileMetricExporterOptions() {} + } // namespace otlp } // namespace exporter OPENTELEMETRY_END_NAMESPACE diff --git a/exporters/otlp/src/otlp_grpc_client.cc b/exporters/otlp/src/otlp_grpc_client.cc index 2bc66aa739..a51740404f 100644 --- a/exporters/otlp/src/otlp_grpc_client.cc +++ b/exporters/otlp/src/otlp_grpc_client.cc @@ -238,7 +238,7 @@ static sdk::common::ExportResult InternalDelegateAsyncExport( stub->experimental_async() # endif ->Export(call_data->grpc_context.get(), call_data->request, call_data->response, - [call_data, async_data, export_data_name](::grpc::Status grpc_status) { + [call_data, async_data, export_data_name](const ::grpc::Status &grpc_status) { { std::lock_guard lock{async_data->running_calls_lock}; async_data->running_calls.erase(