Replies: 1 comment 1 reply
-
hey @mic-max do we still need this discussion? I mean, I couldn't find |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Code shown here
https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/productcatalogservice/server.go#L181
When the
reloadCatalog
bool is true the catalog fileproducts.json
will be read and unmarshalled and saved into the global variablecat
. ThereloadCatalog
bool is set to True and False by sending the signalsSIGUSR1
andSIGUSR2
respectively. This seems like some added complexity to the demo that doesn't add much value.Aside: The catalog is also being parsed on each request,
parseCatalog
is called. This could be improved. I will work on simplifying this since this service will remain in Go lang.Beta Was this translation helpful? Give feedback.
All reactions