Skip to content

[flagd-ui] Spans with error #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[flagd-ui] Spans with error #2677

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bc967d2
fix: liveSocket init and update navbar to use link component to solve…
jack5341 Oct 22, 2025
ffaa6e0
update document
jack5341 Oct 22, 2025
90693a9
feat(envoy): add timeout configuration for flagd-ui cluster
jack5341 Oct 23, 2025
021ab78
Merge branch 'main' into fix/spans-with-error
julianocosta89 Oct 24, 2025
d778a09
fix(envoy): remove timeout configuration for flagd-ui cluster; update…
jack5341 Oct 24, 2025
c7ac67f
Merge branch 'fix/spans-with-error' of https://github.com/jack5341/op…
jack5341 Oct 24, 2025
1636aab
revert: bringed back unnecessary changes.
jack5341 Oct 24, 2025
34f66ab
Merge branch 'main' into fix/spans-with-error
julianocosta89 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ the release.
* [chore] Upgrade OpenFeature and add fix deprecation warnings for dependency
injection
([#2644](https://github.com/open-telemetry/opentelemetry-demo/pull/2644))
* [chore] Fix flagd-ui span error
([#2615](https://github.com/open-telemetry/opentelemetry-demo/pull/2677))

## 2.1.3

Expand Down
3 changes: 2 additions & 1 deletion src/flagd-ui/assets/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import topbar from "../vendor/topbar"

const csrfToken = document.querySelector("meta[name='csrf-token']").getAttribute("content")
const rootPath = document.querySelector("meta[name='root-path']").getAttribute("content")
const liveSocket = new LiveSocket(rootPath === '/' ? '/live' : `${rootPath}live`, Socket, {
const livePath = rootPath === '/' ? '/live' : `${rootPath}/live`
const liveSocket = new LiveSocket(livePath, Socket, {
longPollFallbackMs: 2500,
params: {_csrf_token: csrfToken}
})
Expand Down
12 changes: 6 additions & 6 deletions src/flagd-ui/lib/flagd_ui_web/components/navbar.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@ defmodule FlagdUiWeb.Components.Navbar do
~H"""
<nav class="bg-gray-800 p-4 sm:p-6">
<div class="container mx-auto flex items-center justify-between">
<a href="/feature" class="text-xl font-bold text-white">
<.link navigate={~p"/"} class="text-xl font-bold text-white">
Flagd Configurator
</a>
</.link>
<ul class="flex space-x-2 sm:space-x-4">
<li>
<a href="/feature" class={classes("basic", @mode)}>
<.link navigate={~p"/"} class={classes("basic", @mode)}>
Basic
</a>
</.link>
</li>
<li>
<a href="/feature/advanced" class={classes("advanced", @mode)}>
<.link navigate={~p"/advanced"} class={classes("advanced", @mode)}>
Advanced
</a>
</.link>
</li>
</ul>
</div>
Expand Down
Loading