Merge branch 'main' into renovate-prep

Author: martincostello

.github/workflows/ossf-scorecard.yml

@@ -23,7 +23,7 @@ jobs:
         with:
           persist-credentials: false
 
-      - uses: ossf/scorecard-action@05b42c624433fc40578a4040d5cf5e36ddca8cde # v2.4.2
+      - uses: ossf/scorecard-action@4eaacf0543bb3f2c246792bd56e8cdeffafb205a # v2.4.3
         with:
           results_file: results.sarif
           results_format: sarif

src/OpenTelemetry.OpAmp.Client/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+* Drop reference to `System.Collections.Immutable`.
+  ([#3154](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/3154))
+
 ## 0.1.0-alpha.1
 
 Released 2025-Sep-23

src/OpenTelemetry.OpAmp.Client/Internal/FrameProcessor.cs

@@ -3,7 +3,6 @@
 
 using System.Buffers;
 using System.Collections.Concurrent;
-using System.Collections.Immutable;
 using OpAmp.Proto.V1;
 using OpenTelemetry.Internal;
 using OpenTelemetry.OpAmp.Client.Internal.Listeners;
@@ -14,7 +13,7 @@ namespace OpenTelemetry.OpAmp.Client.Internal;
 
 internal sealed class FrameProcessor
 {
-    private readonly ConcurrentDictionary<Type, ImmutableList<IOpAmpListener>> listeners = [];
+    private readonly ConcurrentDictionary<Type, IReadOnlyList<IOpAmpListener>> listeners = [];
 
     public void Subscribe<T>(IOpAmpListener<T> listener)
         where T : IOpAmpMessage
@@ -25,7 +24,13 @@ public void Subscribe<T>(IOpAmpListener<T> listener)
         this.listeners.AddOrUpdate(
             typeof(T),
             _ => [listener],
-            (_, list) => list.Add(listener));
+            (_, list) =>
+            {
+                var newList = new List<IOpAmpListener>(list.Count + 1);
+                newList.AddRange(list);
+                newList.Add(listener);
+                return newList;
+            });
     }
 
     public void Unsubscribe<T>(IOpAmpListener<T> listener)
@@ -35,15 +40,15 @@ public void Unsubscribe<T>(IOpAmpListener<T> listener)
 
         this.listeners.AddOrUpdate(
             typeof(T),
-            _ => ImmutableList<IOpAmpListener>.Empty,
+            _ => [],
             (_, list) =>
             {
                 if (list.Count == 1 && list[0] == listener)
                 {
-                    return ImmutableList<IOpAmpListener>.Empty;
+                    return [];
                 }
 
-                return list.Remove(listener);
+                return list.Where(x => x != listener).ToList();
             });
     }
 

src/OpenTelemetry.OpAmp.Client/OpenTelemetry.OpAmp.Client.csproj

@@ -21,12 +21,6 @@
   <!-- .NET Framework supporting packages -->
   <ItemGroup Condition="'$([MSBuild]::GetTargetFrameworkIdentifier(`$(TargetFramework)`))' == '.NETFramework'">
     <PackageReference Include="System.Net.Http" />
-    <PackageReference Include="System.Collections.Immutable" />
-  </ItemGroup>
-
-  <!-- .NET Standard supporting packages -->
-  <ItemGroup Condition="'$([MSBuild]::GetTargetFrameworkIdentifier(`$(TargetFramework)`))' == '.NETStandard'">
-    <PackageReference Include="System.Collections.Immutable" />
   </ItemGroup>
 
   <ItemGroup>