Skip to content

Commit 77819be

Browse files
committed
Update docs
1 parent 524f04d commit 77819be

File tree

4 files changed

+28
-24
lines changed

4 files changed

+28
-24
lines changed

src/OpenTelemetry.Instrumentation.Kusto/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22

33
## Unreleased
44

5-
* Initial implementation of Kusto instrumentation.
5+
* Initial implementation.

src/OpenTelemetry.Instrumentation.Kusto/README.md

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Kusto Instrumentation for OpenTelemetry
22

3-
| Status | |
4-
| ----------- | --------- |
3+
| Status | |
4+
| ----------- | ------------------------------ |
55
| Stability | [Alpha](../../README.md#alpha) |
66

77
[![NuGet version badge](https://img.shields.io/nuget/v/OpenTelemetry.Instrumentation.Kusto)](https://www.nuget.org/packages/OpenTelemetry.Instrumentation.Kusto)
@@ -81,12 +81,12 @@ The instrumentation is implemented based on [metrics semantic
8181
conventions](https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/database/database-metrics.md).
8282
Currently, the instrumentation supports the following metric:
8383

84-
| Name | Instrument Type | Unit | Description | Attributes |
85-
|--------------------------------|-----------------|------|-----------------------------------------|------------|
86-
| `db.client.operation.duration` | Histogram | `s` | Duration of database client operations. | `db.system`, `db.operation.name`, `db.namespace`, `db.query.summary`¹, `server.address`, `server.port`, `error.type`² |
84+
| Name | Instrument Type | Unit | Description | Attributes |
85+
|--------------------------------|-----------------|------|-----------------------------------------|----------------------------------------------------------------------------------------------------------------------------|
86+
| `db.client.operation.duration` | Histogram | `s` | Duration of database client operations. | `db.system`, `db.operation.name`, `db.namespace`, `db.query.summary` (1), `server.address`, `server.port`, `error.type`(2) |
8787

88-
¹ `db.query.summary` is only included when `RecordQuerySummary` is enabled (default: `true`)
89-
² `error.type` is only included when an error occurs
88+
1 `db.query.summary` is only included when `RecordQuerySummary` is enabled
89+
2 `error.type` is only included when an error occurs
9090

9191
## Advanced configuration
9292

@@ -142,8 +142,8 @@ using var tracerProvider = Sdk.CreateTracerProviderBuilder()
142142
.AddKustoInstrumentation(opt => opt.Enrich = (activity, record) =>
143143
{
144144
// Add custom tags based on the TraceRecord
145-
activity.SetTag("kusto.activity_id", record.Activity.ActivityId);
146-
activity.SetTag("kusto.activity_type", record.Activity.ActivityType);
145+
activity.SetTag("azure.kusto.activity_id", record.Activity.ActivityId);
146+
activity.SetTag("azure.kusto.activity_type", record.Activity.ActivityType);
147147
})
148148
.Build();
149149
```
@@ -205,7 +205,8 @@ Users
205205
| take 100
206206
```
207207

208-
Would result in an activity with the summary and display name set to `"Get active users"`.
208+
Would result in an activity with the summary and display name
209+
set to `"Get active users"`.
209210

210211
## References
211212

test/OpenTelemetry.Instrumentation.Kusto.Benchmarks/README.md

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,14 @@ Then choose the benchmark class that you want to run by entering the required
1414
option number from the list of options shown on the Console window.
1515

1616
> [!TIP]
17-
> The Profiling benchmarks are designed to run quickly and use the Visual Studio diagnosers to gather performance data.
17+
> The Profiling benchmarks are designed to run quickly and use the Visual
18+
> Studio diagnosers to gather performance data.
1819
1920
## Results
2021

2122
### Full instrumentation
2223

23-
```
24+
```plain
2425
2526
BenchmarkDotNet v0.15.6, Windows 11 (10.0.26200.7093)
2627
Intel Core Ultra 7 165H 3.80GHz, 1 CPU, 22 logical and 16 physical cores
@@ -30,19 +31,20 @@ Intel Core Ultra 7 165H 3.80GHz, 1 CPU, 22 logical and 16 physical cores
3031
3132
3233
```
34+
3335
| Method | Mean | Error | StdDev | Gen0 | Gen1 | Allocated |
3436
|------------------- |----------:|----------:|----------:|-------:|-------:|----------:|
35-
| SuccessfulQuery | 9.043 μs | 0.1183 μs | 0.1048 μs | 0.9308 | 0.0153 | 11.48 KB |
36-
| FailedQuery | 10.076 μs | 0.2007 μs | 0.3354 μs | 0.9613 | 0.0153 | 11.91 KB |
37-
| TraceListenerOnly | 9.411 μs | 0.1788 μs | 0.2325 μs | 0.9308 | 0.0153 | 11.52 KB |
38-
| MetricListenerOnly | 9.352 μs | 0.1746 μs | 0.2613 μs | 0.9308 | 0.0153 | 11.52 KB |
37+
| SuccessfulQuery | 9.043 us | 0.1183 us | 0.1048 us | 0.9308 | 0.0153 | 11.48 KB |
38+
| FailedQuery | 10.076 us | 0.2007 us | 0.3354 us | 0.9613 | 0.0153 | 11.91 KB |
39+
| TraceListenerOnly | 9.411 us | 0.1788 us | 0.2325 us | 0.9308 | 0.0153 | 11.52 KB |
40+
| MetricListenerOnly | 9.352 us | 0.1746 us | 0.2613 us | 0.9308 | 0.0153 | 11.52 KB |
3941

4042
### Summarization and sanitization processing
4143

42-
Summarization and sanitization are the most expensive parts of instrumentation, so there are benchmarks to measure their
43-
specific cost.
44+
Summarization and sanitization are the most expensive parts of instrumentation, so
45+
there are benchmarks to measure their specific cost.
4446

45-
```
47+
```plain
4648
4749
BenchmarkDotNet v0.15.6, Windows 11 (10.0.26200.7093)
4850
Intel Core Ultra 7 165H 3.80GHz, 1 CPU, 22 logical and 16 physical cores
@@ -52,9 +54,10 @@ Intel Core Ultra 7 165H 3.80GHz, 1 CPU, 22 logical and 16 physical cores
5254
5355
5456
```
57+
5558
| Method | Mean | Error | StdDev | Gen0 | Gen1 | Allocated |
5659
|---------------------------- |----------:|----------:|----------:|-------:|-------:|----------:|
57-
| ProcessSummarizeAndSanitize | 10.141 μs | 0.1926 μs | 0.2436 μs | 1.0834 | 0.0153 | 13.36 KB |
58-
| ProcessSummarizeOnly | 9.549 μs | 0.1772 μs | 0.1571 μs | 1.0071 | 0.0153 | 12.48 KB |
59-
| ProcessSanitizeOnly | 4.154 μs | 0.0827 μs | 0.1832 μs | 0.5798 | 0.0038 | 7.13 KB |
60+
| ProcessSummarizeAndSanitize | 10.141 us | 0.1926 us | 0.2436 us | 1.0834 | 0.0153 | 13.36 KB |
61+
| ProcessSummarizeOnly | 9.549 us | 0.1772 us | 0.1571 us | 1.0071 | 0.0153 | 12.48 KB |
62+
| ProcessSanitizeOnly | 4.154 us | 0.0827 us | 0.1832 us | 0.5798 | 0.0038 | 7.13 KB |
6063
| ProcessNeither | 0.0566 ns | 0.0259 ns | 0.0610 ns | - | - | - |

test/OpenTelemetry.Instrumentation.Kusto.Tests/OpenTelemetry.Instrumentation.Kusto.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<!--
3535
Verify adds an implicit using for the test framework, however because we use shared files, remove it to avoid
3636
an unnecessary using warning.
37-
-->
37+
-->
3838
<Using Remove="Xunit" />
3939
</ItemGroup>
4040

0 commit comments

Comments
 (0)