[OpenTelemetry] enable analysis - part 2 - final (#6279)

Co-authored-by: Rajkumar Rangaraj <[email protected]>

Author: Kielek

src/OpenTelemetry/BaseExportProcessor.cs

@@ -29,7 +29,9 @@ public enum ExportProcessorType
 /// Implements processor that exports telemetry objects.
 /// </summary>
 /// <typeparam name="T">The type of telemetry object to be exported.</typeparam>
+#pragma warning disable CA1708 // Identifiers should differ by more than case
 public abstract class BaseExportProcessor<T> : BaseProcessor<T>
+#pragma warning restore CA1708 // Identifiers should differ by more than case
     where T : class
 {
     /// <summary>
@@ -50,7 +52,9 @@ protected BaseExportProcessor(BaseExporter<T> exporter)
     {
         Guard.ThrowIfNull(exporter);
 
+#pragma warning disable CA1062 // Validate arguments of public methods - needed for netstandard2.1
         this.friendlyTypeName = $"{this.GetType().Name}{{{exporter.GetType().Name}}}";
+#pragma warning restore CA1062 // Validate arguments of public methods - needed for netstandard2.1
         this.exporter = exporter;
     }
 

src/OpenTelemetry/BaseProcessor.cs

@@ -9,17 +9,17 @@ namespace OpenTelemetry;
 /// Base processor base class.
 /// </summary>
 /// <typeparam name="T">The type of object to be processed.</typeparam>
+#pragma warning disable CA1012 // Abstract types should not have public constructors
 public abstract class BaseProcessor<T> : IDisposable
+#pragma warning restore CA1012 // Abstract types should not have public constructors
 {
     private readonly string typeName;
     private int shutdownCount;
 
     /// <summary>
     /// Initializes a new instance of the <see cref="BaseProcessor{T}"/> class.
     /// </summary>
-#pragma warning disable CA1012 // Abstract types should not have public constructors
     public BaseProcessor()
-#pragma warning restore CA1012 // Abstract types should not have public constructors
     {
         this.typeName = this.GetType().Name;
     }

src/OpenTelemetry/Batch.cs

@@ -29,7 +29,9 @@ namespace OpenTelemetry;
     public Batch(T[] items, int count)
     {
         Guard.ThrowIfNull(items);
+#pragma warning disable CA1062 // Validate arguments of public methods - needed for netstandard2.1
         Guard.ThrowIfOutOfRange(count, min: 0, max: items.Length);
+#pragma warning restore CA1062 // Validate arguments of public methods - needed for netstandard2.1
 
         this.items = items;
         this.Count = this.targetCount = count;

src/OpenTelemetry/BatchExportProcessor.cs

@@ -60,7 +60,9 @@ protected BatchExportProcessor(
         this.exporterThread = new Thread(this.ExporterProc)
         {
             IsBackground = true,
+#pragma warning disable CA1062 // Validate arguments of public methods - needed for netstandard2.1
             Name = $"OpenTelemetry-{nameof(BatchExportProcessor<T>)}-{exporter.GetType().Name}",
+#pragma warning restore CA1062 // Validate arguments of public methods - needed for netstandard2.1
         };
         this.exporterThread.Start();
     }

src/OpenTelemetry/CompositeProcessor.cs

@@ -24,7 +24,9 @@ public CompositeProcessor(IEnumerable<BaseProcessor<T>> processors)
     {
         Guard.ThrowIfNull(processors);
 
+#pragma warning disable CA1062 // Validate arguments of public methods - needed for netstandard2.1
         using var iter = processors.GetEnumerator();
+#pragma warning restore CA1062 // Validate arguments of public methods - needed for netstandard2.1
         if (!iter.MoveNext())
         {
             throw new ArgumentException($"'{iter}' is null or empty", nameof(processors));

src/OpenTelemetry/Internal/SelfDiagnosticsConfigRefresher.cs

@@ -35,8 +35,10 @@ internal class SelfDiagnosticsConfigRefresher : IDisposable
 
     // Once the configuration file is valid, an eventListener object will be created.
     private SelfDiagnosticsEventListener? eventListener;
+#pragma warning disable CA2213 // Disposable fields should be disposed
     private volatile FileStream? underlyingFileStreamForMemoryMappedFile;
     private volatile MemoryMappedFile? memoryMappedFile;
+#pragma warning restore CA2213 // Disposable fields should be disposed
     private string? logDirectory;  // Log directory for log files
     private int logFileSize;  // Log file size in bytes
     private long logFilePosition;  // The logger will write into the byte at this position

src/OpenTelemetry/Internal/SelfDiagnosticsEventListener.cs

@@ -249,7 +249,9 @@ internal void WriteEvent(string? eventMessage, ReadOnlyCollection<object?>? payl
 
             buffer[pos++] = (byte)'\n';
             int byteCount = pos - 0;
+#pragma warning disable CA2000 // Dispose objects before losing scope
             if (this.configRefresher.TryGetLogStream(byteCount, out Stream? stream, out int availableByteCount))
+#pragma warning restore CA2000 // Dispose objects before losing scope
             {
                 if (availableByteCount >= byteCount)
                 {
@@ -283,7 +285,9 @@ protected override void OnEventSourceCreated(EventSource eventSource)
             {
                 lock (this.lockObj)
                 {
+#pragma warning disable CA1508 // Avoid dead conditional code - see previous comment
                     if (this.eventSourcesBeforeConstructor != null)
+#pragma warning restore CA1508 // Avoid dead conditional code - see previous comment
                     {
                         this.eventSourcesBeforeConstructor.Add(eventSource);
                         return;

src/OpenTelemetry/Internal/WildcardHelper.cs

@@ -18,7 +18,11 @@ public static bool ContainsWildcard(
             return false;
         }
 
+#if NET || NETSTANDARD2_1_OR_GREATER
+        return value.Contains('*', StringComparison.Ordinal) || value.Contains('?', StringComparison.Ordinal);
+#else
         return value.Contains('*') || value.Contains('?');
+#endif
     }
 
     public static Regex GetWildcardRegex(IEnumerable<string> patterns)
@@ -27,7 +31,11 @@ public static Regex GetWildcardRegex(IEnumerable<string> patterns)
 
         var convertedPattern = string.Join(
             "|",
+#if NET || NETSTANDARD2_1_OR_GREATER
+            from p in patterns select "(?:" + Regex.Escape(p).Replace("\\*", ".*", StringComparison.Ordinal).Replace("\\?", ".", StringComparison.Ordinal) + ')');
+#else
             from p in patterns select "(?:" + Regex.Escape(p).Replace("\\*", ".*").Replace("\\?", ".") + ')');
+#endif
 
         return new Regex("^(?:" + convertedPattern + ")$", RegexOptions.Compiled | RegexOptions.IgnoreCase);
     }

src/OpenTelemetry/Logs/ILogger/OpenTelemetryLoggerProvider.cs

@@ -37,7 +37,9 @@ public OpenTelemetryLoggerProvider(IOptionsMonitor<OpenTelemetryLoggerOptions> o
     {
         Guard.ThrowIfNull(options);
 
+#pragma warning disable CA1062 // Validate arguments of public methods - needed for netstandard2.1
         var optionsInstance = options.CurrentValue;
+#pragma warning restore CA1062 // Validate arguments of public methods - needed for netstandard2.1
 
         this.Provider = Sdk
             .CreateLoggerProviderBuilder()
@@ -77,7 +79,9 @@ internal OpenTelemetryLoggerProvider(
     internal IExternalScopeProvider? ScopeProvider { get; private set; }
 
     /// <inheritdoc/>
+#pragma warning disable CA1033 // Interface methods should be callable by child types
     void ISupportExternalScope.SetScopeProvider(IExternalScopeProvider scopeProvider)
+#pragma warning restore CA1033 // Interface methods should be callable by child types
     {
         this.ScopeProvider = scopeProvider;
 

src/OpenTelemetry/Logs/ILogger/OpenTelemetryLoggingExtensions.cs

@@ -42,7 +42,9 @@ public static class OpenTelemetryLoggingExtensions
     [Obsolete("Call UseOpenTelemetry instead this method will be removed in a future version.")] */
     public static ILoggingBuilder AddOpenTelemetry(
         this ILoggingBuilder builder)
+#pragma warning disable CA1062 // Validate arguments of public methods - needed for netstandard2.1
         => AddOpenTelemetryInternal(builder, configureBuilder: null, configureOptions: null);
+#pragma warning restore CA1062 // Validate arguments of public methods - needed for netstandard2.1
 
     /// <summary>
     /// Adds an OpenTelemetry logger named 'OpenTelemetry' to the <see cref="ILoggerFactory"/>.
@@ -58,7 +60,9 @@ public static ILoggingBuilder AddOpenTelemetry(
     public static ILoggingBuilder AddOpenTelemetry(
         this ILoggingBuilder builder,
         Action<OpenTelemetryLoggerOptions>? configure)
+#pragma warning disable CA1062 // Validate arguments of public methods - needed for netstandard2.1
         => AddOpenTelemetryInternal(builder, configureBuilder: null, configureOptions: configure);
+#pragma warning restore CA1062 // Validate arguments of public methods - needed for netstandard2.1
 
 #if EXPOSE_EXPERIMENTAL_FEATURES
     /// <summary>
@@ -80,7 +84,9 @@ public static ILoggingBuilder AddOpenTelemetry(
 #endif
         static ILoggingBuilder UseOpenTelemetry(
         this ILoggingBuilder builder)
+#pragma warning disable CA1062 // Validate arguments of public methods - needed for netstandard2.1
         => AddOpenTelemetryInternal(builder, configureBuilder: null, configureOptions: null);
+#pragma warning restore CA1062 // Validate arguments of public methods - needed for netstandard2.1
 
 #if EXPOSE_EXPERIMENTAL_FEATURES
     /// <summary>
@@ -103,7 +109,9 @@ static ILoggingBuilder UseOpenTelemetry(
     {
         Guard.ThrowIfNull(configure);
 
+#pragma warning disable CA1062 // Validate arguments of public methods - needed for netstandard2.1
         return AddOpenTelemetryInternal(builder, configureBuilder: configure, configureOptions: null);
+#pragma warning restore CA1062 // Validate arguments of public methods - needed for netstandard2.1
     }
 
 #if EXPOSE_EXPERIMENTAL_FEATURES
@@ -126,7 +134,9 @@ static ILoggingBuilder UseOpenTelemetry(
         this ILoggingBuilder builder,
         Action<LoggerProviderBuilder>? configureBuilder,
         Action<OpenTelemetryLoggerOptions>? configureOptions)
+#pragma warning disable CA1062 // Validate arguments of public methods - needed for netstandard2.1
         => AddOpenTelemetryInternal(builder, configureBuilder, configureOptions);
+#pragma warning restore CA1062 // Validate arguments of public methods - needed for netstandard2.1
 
     private static ILoggingBuilder AddOpenTelemetryInternal(
         ILoggingBuilder builder,