Skip to content

Commit 68fb8a5

Browse files
committed
remove redundant empty configuration creation
1 parent ce6a46d commit 68fb8a5

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,24 +49,27 @@ public class OtlpExporterOptions : IOtlpExporterOptions
4949
/// </summary>
5050
public OtlpExporterOptions()
5151
: this(
52-
configuration: new ConfigurationBuilder().Build(),
52+
configuration: null,
5353
configurationType: OtlpExporterOptionsConfigurationType.Default,
5454
defaultBatchOptions: new())
5555
{
5656
}
5757

5858
internal OtlpExporterOptions(
59-
IConfiguration configuration,
59+
IConfiguration? configuration,
6060
OtlpExporterOptionsConfigurationType configurationType,
6161
BatchExportActivityProcessorOptions defaultBatchOptions)
6262
{
6363
Debug.Assert(defaultBatchOptions != null, "defaultBatchOptions was null");
64-
var finalConfiguration = new ConfigurationBuilder()
65-
.AddEnvironmentVariables()
66-
.AddConfiguration(configuration)
67-
.Build();
64+
var finalConfigurationBuilder = new ConfigurationBuilder()
65+
.AddEnvironmentVariables();
66+
67+
if (configuration != null)
68+
{
69+
finalConfigurationBuilder = finalConfigurationBuilder.AddConfiguration(configuration);
70+
}
6871

69-
this.ApplyConfiguration(finalConfiguration, configurationType);
72+
this.ApplyConfiguration(finalConfigurationBuilder.Build(), configurationType);
7073

7174
this.DefaultHttpClientFactory = () =>
7275
{

0 commit comments

Comments
 (0)