[OpenTracing.Tests] Remove reference to NuGet.Versioning (#6685)

Author: Kielek

Directory.Packages.props

@@ -110,7 +110,6 @@
     <PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
     <PackageVersion Include="MinVer" Version="6.0.0" />
-    <PackageVersion Include="NuGet.Versioning" Version="6.14.0" />
     <PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.13.0" />
     <PackageVersion Include="OpenTelemetry.Instrumentation.GrpcNetClient" Version="1.13.0-beta.1" />
     <PackageVersion Include="OpenTelemetry.Instrumentation.Http" Version="1.13.0" />

test/OpenTelemetry.Shims.OpenTracing.Tests/OpenTelemetry.Shims.OpenTracing.Tests.csproj

@@ -3,13 +3,8 @@
   <PropertyGroup>
     <Description>Unit test project for OpenTelemetry.Shims.OpenTracing</Description>
     <TargetFrameworks>$(TargetFrameworksForTests)</TargetFrameworks>
-    <DefineConstants Condition="'$(RunningDotNetPack)' != 'true'">$(DefineConstants);BUILDING_USING_PROJECTS</DefineConstants>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="NuGet.Versioning"/>
-  </ItemGroup>
-
   <ItemGroup>
     <ProjectReference Include="$(RepoRoot)\src\OpenTelemetry.Shims.OpenTracing\OpenTelemetry.Shims.OpenTracing.csproj" />
   </ItemGroup>

test/OpenTelemetry.Shims.OpenTracing.Tests/SpanBuilderShimTests.cs

@@ -228,15 +228,7 @@ public void WithTag_KeyIsErrorStringValue()
         Assert.NotNull(spanShim.Span.Activity);
         Assert.Equal("ERROR", spanShim.Span.Activity.GetTagValue(SpanAttributeConstants.StatusCodeKey));
 
-        if (VersionHelper.IsApiVersionGreaterThanOrEqualTo(1, 10))
-        {
-            // Activity status code should also be set
-            Assert.Equal(ActivityStatusCode.Error, spanShim.Span.Activity.Status);
-        }
-        else
-        {
-            Assert.Equal(ActivityStatusCode.Unset, spanShim.Span.Activity.Status);
-        }
+        Assert.Equal(ActivityStatusCode.Error, spanShim.Span.Activity.Status);
     }
 
     [Fact]
@@ -285,15 +277,7 @@ public void WithTag_KeyIsErrorBoolValue()
         // Legacy span status tag should be set
         Assert.NotNull(spanShim.Span.Activity);
         Assert.Equal("ERROR", spanShim.Span.Activity.GetTagValue(SpanAttributeConstants.StatusCodeKey));
-        if (VersionHelper.IsApiVersionGreaterThanOrEqualTo(1, 10))
-        {
-            // Activity status code should also be set
-            Assert.Equal(ActivityStatusCode.Error, spanShim.Span.Activity.Status);
-        }
-        else
-        {
-            Assert.Equal(ActivityStatusCode.Unset, spanShim.Span.Activity.Status);
-        }
+        Assert.Equal(ActivityStatusCode.Error, spanShim.Span.Activity.Status);
     }
 
     [Fact]

test/OpenTelemetry.Shims.OpenTracing.Tests/SpanShimTests.cs

@@ -220,31 +220,14 @@ public void SetTagBoolValue()
 
         // Legacy span status tag should be set
         Assert.Equal("ERROR", shim.Span.Activity.GetTagValue(SpanAttributeConstants.StatusCodeKey));
-
-        if (VersionHelper.IsApiVersionGreaterThanOrEqualTo(1, 10))
-        {
-            // Activity status code should also be set
-            Assert.Equal(ActivityStatusCode.Error, shim.Span.Activity.Status);
-        }
-        else
-        {
-            Assert.Equal(ActivityStatusCode.Unset, shim.Span.Activity.Status);
-        }
+        Assert.Equal(ActivityStatusCode.Error, shim.Span.Activity.Status);
 
         shim.SetTag(Tags.Error.Key, false);
 
         // Legacy span status tag should be set
         Assert.Equal("OK", shim.Span.Activity.GetTagValue(SpanAttributeConstants.StatusCodeKey));
 
-        if (VersionHelper.IsApiVersionGreaterThanOrEqualTo(1, 10))
-        {
-            // Activity status code should also be set
-            Assert.Equal(ActivityStatusCode.Ok, shim.Span.Activity.Status);
-        }
-        else
-        {
-            Assert.Equal(ActivityStatusCode.Unset, shim.Span.Activity.Status);
-        }
+        Assert.Equal(ActivityStatusCode.Ok, shim.Span.Activity.Status);
     }
 
     [Fact]