Skip to content

Commit a9c32c9

Browse files
authored
[sdk-metrics] Update Exemplars before MetricPoint CompleteUpdate fires (#5630)
1 parent 8177a39 commit a9c32c9

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

src/OpenTelemetry/Metrics/MetricPoint.cs

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -492,9 +492,9 @@ internal void UpdateWithExemplar(long number, ReadOnlySpan<KeyValuePair<string,
492492
}
493493
}
494494

495-
this.CompleteUpdate();
496-
497495
this.UpdateExemplar(number, tags, offerExemplar);
496+
497+
this.CompleteUpdate();
498498
}
499499

500500
internal void Update(double number)
@@ -608,9 +608,9 @@ internal void UpdateWithExemplar(double number, ReadOnlySpan<KeyValuePair<string
608608
}
609609
}
610610

611-
this.CompleteUpdate();
612-
613611
this.UpdateExemplar(number, tags, offerExemplar);
612+
613+
this.CompleteUpdate();
614614
}
615615

616616
internal void TakeSnapshot(bool outputDelta)
@@ -899,9 +899,9 @@ private void UpdateHistogram(double number, ReadOnlySpan<KeyValuePair<string, ob
899899

900900
this.mpComponents.ReleaseLock();
901901

902-
this.CompleteUpdate();
903-
904902
this.UpdateExemplar(number, tags, offerExemplar);
903+
904+
this.CompleteUpdate();
905905
}
906906

907907
private void UpdateHistogramWithMinMax(double number, ReadOnlySpan<KeyValuePair<string, object?>> tags = default, bool offerExemplar = false)
@@ -923,9 +923,9 @@ private void UpdateHistogramWithMinMax(double number, ReadOnlySpan<KeyValuePair<
923923

924924
this.mpComponents.ReleaseLock();
925925

926-
this.CompleteUpdate();
927-
928926
this.UpdateExemplar(number, tags, offerExemplar);
927+
928+
this.CompleteUpdate();
929929
}
930930

931931
private void UpdateHistogramWithBuckets(double number, ReadOnlySpan<KeyValuePair<string, object?>> tags = default, bool offerExemplar = false)
@@ -947,9 +947,9 @@ private void UpdateHistogramWithBuckets(double number, ReadOnlySpan<KeyValuePair
947947

948948
this.mpComponents.ReleaseLock();
949949

950-
this.CompleteUpdate();
951-
952950
this.UpdateExemplar(number, tags, offerExemplar, bucketIndex);
951+
952+
this.CompleteUpdate();
953953
}
954954

955955
private void UpdateHistogramWithBucketsAndMinMax(double number, ReadOnlySpan<KeyValuePair<string, object?>> tags = default, bool offerExemplar = false)
@@ -974,9 +974,9 @@ private void UpdateHistogramWithBucketsAndMinMax(double number, ReadOnlySpan<Key
974974

975975
this.mpComponents.ReleaseLock();
976976

977-
this.CompleteUpdate();
978-
979977
this.UpdateExemplar(number, tags, offerExemplar, bucketIndex);
978+
979+
this.CompleteUpdate();
980980
}
981981

982982
private void UpdateBase2ExponentialHistogram(double number, ReadOnlySpan<KeyValuePair<string, object?>> tags = default, bool offerExemplar = false)
@@ -1002,9 +1002,9 @@ private void UpdateBase2ExponentialHistogram(double number, ReadOnlySpan<KeyValu
10021002

10031003
this.mpComponents.ReleaseLock();
10041004

1005-
this.CompleteUpdate();
1006-
10071005
this.UpdateExemplar(number, tags, offerExemplar);
1006+
1007+
this.CompleteUpdate();
10081008
}
10091009

10101010
private void UpdateBase2ExponentialHistogramWithMinMax(double number, ReadOnlySpan<KeyValuePair<string, object?>> tags = default, bool offerExemplar = false)
@@ -1033,9 +1033,9 @@ private void UpdateBase2ExponentialHistogramWithMinMax(double number, ReadOnlySp
10331033

10341034
this.mpComponents.ReleaseLock();
10351035

1036-
this.CompleteUpdate();
1037-
10381036
this.UpdateExemplar(number, tags, offerExemplar);
1037+
1038+
this.CompleteUpdate();
10391039
}
10401040

10411041
[MethodImpl(MethodImplOptions.AggressiveInlining)]

0 commit comments

Comments
 (0)