chore: Adjust parameters ordering to avoid unnamed parameters breaking change

Author: jeromelaban

src/OpenTelemetry/.publicApi/Stable/PublicAPI.Unshipped.txt

@@ -1,4 +1,4 @@
-OpenTelemetry.BatchActivityExportProcessor.BatchActivityExportProcessor(OpenTelemetry.BaseExporter<System.Diagnostics.Activity!>! exporter, bool useThreads = true, int maxQueueSize = 2048, int scheduledDelayMilliseconds = 5000, int exporterTimeoutMilliseconds = 30000, int maxExportBatchSize = 512) -> void
-OpenTelemetry.BatchExportProcessor<T>.BatchExportProcessor(OpenTelemetry.BaseExporter<T!>! exporter, bool useThreads = true, int maxQueueSize = 2048, int scheduledDelayMilliseconds = 5000, int exporterTimeoutMilliseconds = 30000, int maxExportBatchSize = 512) -> void
-OpenTelemetry.BatchLogRecordExportProcessor.BatchLogRecordExportProcessor(OpenTelemetry.BaseExporter<OpenTelemetry.Logs.LogRecord!>! exporter, bool useThreads = true, int maxQueueSize = 2048, int scheduledDelayMilliseconds = 5000, int exporterTimeoutMilliseconds = 30000, int maxExportBatchSize = 512) -> void
-OpenTelemetry.Metrics.PeriodicExportingMetricReader.PeriodicExportingMetricReader(OpenTelemetry.BaseExporter<OpenTelemetry.Metrics.Metric!>! exporter, bool useThreads = true, int exportIntervalMilliseconds = 60000, int exportTimeoutMilliseconds = 30000) -> void
+OpenTelemetry.BatchActivityExportProcessor.BatchActivityExportProcessor(OpenTelemetry.BaseExporter<System.Diagnostics.Activity!>! exporter, int maxQueueSize = 2048, int scheduledDelayMilliseconds = 5000, int exporterTimeoutMilliseconds = 30000, int maxExportBatchSize = 512, bool useThreads = true) -> void
+OpenTelemetry.BatchExportProcessor<T>.BatchExportProcessor(OpenTelemetry.BaseExporter<T!>! exporter, int maxQueueSize = 2048, int scheduledDelayMilliseconds = 5000, int exporterTimeoutMilliseconds = 30000, int maxExportBatchSize = 512, bool useThreads = true) -> void
+OpenTelemetry.BatchLogRecordExportProcessor.BatchLogRecordExportProcessor(OpenTelemetry.BaseExporter<OpenTelemetry.Logs.LogRecord!>! exporter, int maxQueueSize = 2048, int scheduledDelayMilliseconds = 5000, int exporterTimeoutMilliseconds = 30000, int maxExportBatchSize = 512, bool useThreads = true) -> void
+OpenTelemetry.Metrics.PeriodicExportingMetricReader.PeriodicExportingMetricReader(OpenTelemetry.BaseExporter<OpenTelemetry.Metrics.Metric!>! exporter, int exportIntervalMilliseconds = 60000, int exportTimeoutMilliseconds = 30000, bool useThreads = true) -> void

src/OpenTelemetry/BatchExportProcessor.cs

@@ -43,7 +43,7 @@ protected BatchExportProcessor(
         int scheduledDelayMilliseconds,
         int exporterTimeoutMilliseconds,
         int maxExportBatchSize)
-        : this(exporter, true, maxQueueSize, scheduledDelayMilliseconds, exporterTimeoutMilliseconds, maxExportBatchSize)
+        : this(exporter, maxQueueSize, scheduledDelayMilliseconds, exporterTimeoutMilliseconds, maxExportBatchSize, true)
     {
     }
 
@@ -58,11 +58,11 @@ protected BatchExportProcessor(
     /// <param name="maxExportBatchSize">The maximum batch size of every export. It must be smaller or equal to maxQueueSize. The default value is 512.</param>
     protected BatchExportProcessor(
         BaseExporter<T> exporter,
-        bool useThreads = true,
         int maxQueueSize = DefaultMaxQueueSize,
         int scheduledDelayMilliseconds = DefaultScheduledDelayMilliseconds,
         int exporterTimeoutMilliseconds = DefaultExporterTimeoutMilliseconds,
-        int maxExportBatchSize = DefaultMaxExportBatchSize)
+        int maxExportBatchSize = DefaultMaxExportBatchSize,
+        bool useThreads = true)
         : base(exporter)
     {
         Guard.ThrowIfOutOfRange(maxQueueSize, min: 1);

src/OpenTelemetry/Logs/Processor/BatchLogRecordExportProcessor.cs

@@ -27,11 +27,11 @@ public BatchLogRecordExportProcessor(
         int maxExportBatchSize)
         : this(
             exporter,
-            true,
             maxQueueSize,
             scheduledDelayMilliseconds,
             exporterTimeoutMilliseconds,
-            maxExportBatchSize)
+            maxExportBatchSize,
+            true)
     {
     }
 
@@ -46,18 +46,18 @@ public BatchLogRecordExportProcessor(
     /// <param name="maxExportBatchSize">The maximum batch size of every export. It must be smaller or equal to maxQueueSize. The default value is 512.</param>
     public BatchLogRecordExportProcessor(
         BaseExporter<LogRecord> exporter,
-        bool useThreads = true,
         int maxQueueSize = DefaultMaxQueueSize,
         int scheduledDelayMilliseconds = DefaultScheduledDelayMilliseconds,
         int exporterTimeoutMilliseconds = DefaultExporterTimeoutMilliseconds,
-        int maxExportBatchSize = DefaultMaxExportBatchSize)
+        int maxExportBatchSize = DefaultMaxExportBatchSize,
+        bool useThreads = true)
         : base(
             exporter,
-            useThreads,
             maxQueueSize,
             scheduledDelayMilliseconds,
             exporterTimeoutMilliseconds,
-            maxExportBatchSize)
+            maxExportBatchSize,
+            useThreads)
     {
     }
 

src/OpenTelemetry/Metrics/Reader/PeriodicExportingMetricReader.cs

@@ -32,7 +32,7 @@ public PeriodicExportingMetricReader(
         BaseExporter<Metric> exporter,
         int exportIntervalMilliseconds,
         int exportTimeoutMilliseconds)
-        : this(exporter, true, exportIntervalMilliseconds, exportTimeoutMilliseconds)
+        : this(exporter, exportIntervalMilliseconds, exportTimeoutMilliseconds, true)
     {
     }
 
@@ -45,9 +45,9 @@ public PeriodicExportingMetricReader(
     /// <param name="exportTimeoutMilliseconds">How long the export can run before it is cancelled. The default value is 30000.</param>
     public PeriodicExportingMetricReader(
         BaseExporter<Metric> exporter,
-        bool useThreads = true,
         int exportIntervalMilliseconds = DefaultExportIntervalMilliseconds,
-        int exportTimeoutMilliseconds = DefaultExportTimeoutMilliseconds)
+        int exportTimeoutMilliseconds = DefaultExportTimeoutMilliseconds,
+        bool useThreads = true)
         : base(exporter)
     {
         Guard.ThrowIfInvalidTimeout(exportIntervalMilliseconds);

src/OpenTelemetry/Trace/Processor/BatchActivityExportProcessor.cs

@@ -27,37 +27,37 @@ public BatchActivityExportProcessor(
         int maxExportBatchSize)
         : this(
             exporter,
-            true,
             maxQueueSize,
             scheduledDelayMilliseconds,
             exporterTimeoutMilliseconds,
-            maxExportBatchSize)
+            maxExportBatchSize,
+            true)
     {
     }
 
     /// <summary>
     /// Initializes a new instance of the <see cref="BatchActivityExportProcessor"/> class.
     /// </summary>
-    /// <param name="exporter"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T}, bool, int, int, int, int)" path="/param[@name='exporter']"/></param>
-    /// <param name="useThreads"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T}, bool, int, int, int, int)" path="/param[@name='useThread']"/></param>
-    /// <param name="maxQueueSize"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T}, bool, int, int, int, int)" path="/param[@name='maxQueueSize']"/></param>
-    /// <param name="scheduledDelayMilliseconds"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T}, bool, int, int, int, int)" path="/param[@name='scheduledDelayMilliseconds']"/></param>
-    /// <param name="exporterTimeoutMilliseconds"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T}, bool, int, int, int, int)" path="/param[@name='exporterTimeoutMilliseconds']"/></param>
-    /// <param name="maxExportBatchSize"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T}, bool, int, int, int, int)" path="/param[@name='maxExportBatchSize']"/></param>
+    /// <param name="exporter"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T}, int, int, int, int, bool)" path="/param[@name='exporter']"/></param>
+    /// <param name="useThreads"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T},  int, int, int, int, bool)" path="/param[@name='useThread']"/></param>
+    /// <param name="maxQueueSize"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T}, int, int, int, int, bool)" path="/param[@name='maxQueueSize']"/></param>
+    /// <param name="scheduledDelayMilliseconds"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T}, int, int, int, int, bool)" path="/param[@name='scheduledDelayMilliseconds']"/></param>
+    /// <param name="exporterTimeoutMilliseconds"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T}, int, int, int, int, bool)" path="/param[@name='exporterTimeoutMilliseconds']"/></param>
+    /// <param name="maxExportBatchSize"><inheritdoc cref="BatchExportProcessor{T}.BatchExportProcessor(BaseExporter{T}, int, int, int, int, bool)" path="/param[@name='maxExportBatchSize']"/></param>
     public BatchActivityExportProcessor(
         BaseExporter<Activity> exporter,
-        bool useThreads = true,
         int maxQueueSize = DefaultMaxQueueSize,
         int scheduledDelayMilliseconds = DefaultScheduledDelayMilliseconds,
         int exporterTimeoutMilliseconds = DefaultExporterTimeoutMilliseconds,
-        int maxExportBatchSize = DefaultMaxExportBatchSize)
+        int maxExportBatchSize = DefaultMaxExportBatchSize,
+        bool useThreads = true)
         : base(
             exporter,
-            useThreads,
             maxQueueSize,
             scheduledDelayMilliseconds,
             exporterTimeoutMilliseconds,
-            maxExportBatchSize)
+            maxExportBatchSize,
+            useThreads)
     {
     }