chore: Remove early exit of the exporter

jeromelaban · jeromelaban · commit dadb37864397 · 2025-07-21T23:24:01.000-04:00
Allow for slow thread startup to process exports if the processor is shut down quickly
diff --git a/src/OpenTelemetry/Internal/BatchExportTaskWorker.cs b/src/OpenTelemetry/Internal/BatchExportTaskWorker.cs
@@ -17,7 +17,6 @@ internal sealed class BatchExportTaskWorker<T> : BatchExportWorker<T>
     private readonly TaskCompletionSource<bool> shutdownCompletionSource = new();
     private TaskCompletionSource<bool> dataExportedNotification = new();
     private Task? workerTask;
-    private volatile bool isShutdownRequested;
     private bool disposed;
 
     /// <summary>
@@ -100,7 +99,6 @@ public override bool WaitForExport(int timeoutMilliseconds)
     public override bool Shutdown(int timeoutMilliseconds)
     {
         this.SetShutdownDrainTarget(this.circularBuffer.AddedCount);
-        this.isShutdownRequested = true;
 
         try
         {
@@ -207,7 +205,7 @@ private async Task ExporterProcAsync()
 
         try
         {
-            while (!cancellationToken.IsCancellationRequested && !this.isShutdownRequested)
+            while (true)
             {
                 // only wait when the queue doesn't have enough items, otherwise keep busy and send data continuously
                 if (this.circularBuffer.Count < this.maxExportBatchSize)

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ internal sealed class BatchExportTaskWorker<T> : BatchExportWorker<T>`
`17`	`17`	`private readonly TaskCompletionSource<bool> shutdownCompletionSource = new();`
`18`	`18`	`private TaskCompletionSource<bool> dataExportedNotification = new();`
`19`	`19`	`private Task? workerTask;`
`20`		`- private volatile bool isShutdownRequested;`
`21`	`20`	`private bool disposed;`
`22`	`21`
`23`	`22`	`/// <summary>`
`@@ -100,7 +99,6 @@ public override bool WaitForExport(int timeoutMilliseconds)`
`100`	`99`	`public override bool Shutdown(int timeoutMilliseconds)`
`101`	`100`	`{`
`102`	`101`	`this.SetShutdownDrainTarget(this.circularBuffer.AddedCount);`
`103`		`- this.isShutdownRequested = true;`
`104`	`102`
`105`	`103`	`try`
`106`	`104`	`{`
`@@ -207,7 +205,7 @@ private async Task ExporterProcAsync()`
`207`	`205`
`208`	`206`	`try`
`209`	`207`	`{`
`210`		`- while (!cancellationToken.IsCancellationRequested && !this.isShutdownRequested)`
	`208`	`+ while (true)`
`211`	`209`	`{`
`212`	`210`	`// only wait when the queue doesn't have enough items, otherwise keep busy and send data continuously`
`213`	`211`	`if (this.circularBuffer.Count < this.maxExportBatchSize)`