Add OpCode for activity started and stop in OpenTelemetry-Sdk eventsource#6046
Closed
xiaomi7732 wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Add OpCode for activity started and stop in OpenTelemetry-Sdk eventsource#6046xiaomi7732 wants to merge 2 commits intoopen-telemetry:mainfrom
xiaomi7732 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
cijothomas
reviewed
Jan 7, 2025
Member
|
@xiaomi7732 Could you please check if you reviewed the previous PR #5387, where the feedback was provided for similar proposal? |
Contributor
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Author
|
@rajkumar-rangaraj Thanks for bring that up. I didn't realize there's already a discussion like that. Reading through the comments there, I am now leaning toward thinking it not a good idea to depend on internal event source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi maintainers,
OpenTelemetry-Sdkprovides activity started / stopped events. How about addingOpCodeon those events, making it easier to be discovered by the analysis tools?Changes
Add opcode for activity start / stop to
OpenTelemetry-Sdkevent source.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes