Skip to content

Add OpCode for activity started and stop in OpenTelemetry-Sdk eventsource#6046

Closed
xiaomi7732 wants to merge 2 commits intoopen-telemetry:mainfrom
xiaomi7732:dev/saars/eventsource-opcode
Closed

Add OpCode for activity started and stop in OpenTelemetry-Sdk eventsource#6046
xiaomi7732 wants to merge 2 commits intoopen-telemetry:mainfrom
xiaomi7732:dev/saars/eventsource-opcode

Conversation

@xiaomi7732
Copy link

@xiaomi7732 xiaomi7732 commented Jan 3, 2025

Hi maintainers,

OpenTelemetry-Sdk provides activity started / stopped events. How about adding OpCode on those events, making it easier to be discovered by the analysis tools?

Changes

Add opcode for activity start / stop to OpenTelemetry-Sdk event source.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@xiaomi7732 xiaomi7732 requested a review from a team as a code owner January 3, 2025 18:59
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 3, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Jan 3, 2025
@rajkumar-rangaraj
Copy link
Member

@xiaomi7732 Could you please check if you reviewed the previous PR #5387, where the feedback was provided for similar proposal?

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jan 18, 2025
@xiaomi7732
Copy link
Author

@rajkumar-rangaraj Thanks for bring that up. I didn't realize there's already a discussion like that. Reading through the comments there, I am now leaning toward thinking it not a good idea to depend on internal event source.

@xiaomi7732 xiaomi7732 closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package Stale Issues and pull requests which have been flagged for closing due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants