remove redundant ?? string.Empty in GetSampler#6078
Merged
rajkumar-rangaraj merged 7 commits intoopen-telemetry:mainfrom Feb 12, 2025
SimonCropp:remove-redundant-string.Empty-in-GetSampler
Merged
remove redundant ?? string.Empty in GetSampler#6078rajkumar-rangaraj merged 7 commits intoopen-telemetry:mainfrom SimonCropp:remove-redundant-string.Empty-in-GetSampler
rajkumar-rangaraj merged 7 commits intoopen-telemetry:mainfrom
SimonCropp:remove-redundant-string.Empty-in-GetSampler
Conversation
rajkumar-rangaraj
approved these changes
Jan 22, 2025
Contributor
Author
|
relies on #6090 being merged first |
Contributor
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
TimothyMothra
approved these changes
Feb 12, 2025
The other PR merged today. I think we're good to merge this. :) |
rajkumar-rangaraj
approved these changes
Feb 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6078 +/- ##
=======================================
Coverage 86.36% 86.37%
=======================================
Files 257 257
Lines 11579 11578 -1
=======================================
Hits 10000 10000
+ Misses 1579 1578 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
cant be null since inside a
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes