Skip to content

remove redundant ?? string.Empty in GetSampler#6078

Merged
rajkumar-rangaraj merged 7 commits intoopen-telemetry:mainfrom
SimonCropp:remove-redundant-string.Empty-in-GetSampler
Feb 12, 2025
Merged

remove redundant ?? string.Empty in GetSampler#6078
rajkumar-rangaraj merged 7 commits intoopen-telemetry:mainfrom
SimonCropp:remove-redundant-string.Empty-in-GetSampler

Conversation

@SimonCropp
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

cant be null since inside a

if (configuration.TryGetStringValue(TracesSamplerConfigKey, out var configValue))

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@SimonCropp SimonCropp requested a review from a team as a code owner January 20, 2025 12:04
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Jan 20, 2025
@SimonCropp
Copy link
Contributor Author

relies on #6090 being merged first

@rajkumar-rangaraj rajkumar-rangaraj self-requested a review January 26, 2025 19:38
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Feb 3, 2025
@github-actions github-actions bot removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Feb 7, 2025
@TimothyMothra
Copy link

relies on #6090 being merged first

The other PR merged today. I think we're good to merge this. :)

@rajkumar-rangaraj rajkumar-rangaraj merged commit 8f17a0e into open-telemetry:main Feb 12, 2025
39 checks passed
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.37%. Comparing base (41e1a59) to head (0c290c0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6078   +/-   ##
=======================================
  Coverage   86.36%   86.37%           
=======================================
  Files         257      257           
  Lines       11579    11578    -1     
=======================================
  Hits        10000    10000           
+ Misses       1579     1578    -1     
Files with missing lines Coverage Δ
src/OpenTelemetry/Trace/TracerProviderSdk.cs 100.00% <ø> (+0.34%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants