Skip to content

remove redundant instrumentations != null checks#6091

Merged
rajkumar-rangaraj merged 5 commits intoopen-telemetry:mainfrom
SimonCropp:remove-redundant-instrumentations-!=-null-checks
Feb 6, 2025
Merged

remove redundant instrumentations != null checks#6091
rajkumar-rangaraj merged 5 commits intoopen-telemetry:mainfrom
SimonCropp:remove-redundant-instrumentations-!=-null-checks

Conversation

@SimonCropp
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@SimonCropp SimonCropp requested a review from a team as a code owner January 23, 2025 05:16
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Jan 23, 2025
@TimothyMothra
Copy link

LGTM.
Need to sync with main.

@SimonCropp
Copy link
Contributor Author

Need to sync with main.

done

@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.37%. Comparing base (36b777b) to head (961e1b4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6091      +/-   ##
==========================================
- Coverage   86.39%   86.37%   -0.02%     
==========================================
  Files         257      257              
  Lines       11639    11622      -17     
==========================================
- Hits        10055    10039      -16     
+ Misses       1584     1583       -1     
Files with missing lines Coverage Δ
src/OpenTelemetry/Logs/LoggerProviderSdk.cs 92.55% <ø> (-0.31%) ⬇️
src/OpenTelemetry/Metrics/MeterProviderSdk.cs 93.19% <ø> (-0.12%) ⬇️
src/OpenTelemetry/Trace/TracerProviderSdk.cs 99.65% <ø> (+0.32%) ⬆️

@rajkumar-rangaraj rajkumar-rangaraj merged commit c99f9a1 into open-telemetry:main Feb 6, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants