Skip to content

[repo] remove redundant interpolation#6098

Merged
CodeBlanch merged 5 commits intoopen-telemetry:mainfrom
SimonCropp:remove-redundant-interpolation
Jan 24, 2025
Merged

[repo] remove redundant interpolation#6098
CodeBlanch merged 5 commits intoopen-telemetry:mainfrom
SimonCropp:remove-redundant-interpolation

Conversation

@SimonCropp
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@SimonCropp SimonCropp requested a review from a team as a code owner January 23, 2025 23:10
@github-actions github-actions bot added documentation Documentation related pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Jan 23, 2025
@TimothyMothra
Copy link

LGTM, but several build errors that need to be fixed. Looks like a type, didn't remove all the curly braces.

Copy link
Member

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek changed the title remove redundant interpolation [repo] remove redundant interpolation Jan 24, 2025
@CodeBlanch CodeBlanch merged commit 275a446 into open-telemetry:main Jan 24, 2025
34 checks passed
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (8fa00cb) to head (447ce09).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6098   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files         257      257           
  Lines       11650    11650           
=======================================
  Hits        10065    10065           
  Misses       1585     1585           

@SimonCropp SimonCropp deleted the remove-redundant-interpolation branch January 25, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation related pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants