-
Notifications
You must be signed in to change notification settings - Fork 865
[OTLP] Add TLS-only support to OTLP HTTP client factory #6799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6799 +/- ##
==========================================
+ Coverage 86.88% 86.90% +0.02%
==========================================
Files 262 263 +1
Lines 12350 12372 +22
==========================================
+ Hits 10730 10752 +22
Misses 1620 1620
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpSecureHttpClientFactory.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpSecureHttpClientFactory.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpSecureHttpClientFactory.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpCertificateManager.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpSecureHttpClientFactory.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpSecureHttpClientFactory.cs
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpTlsOptionsTests.cs
Show resolved
Hide resolved
|
@sandy2008 I have provided some important feedback. Please let me know once you have addressed these points. |
|
@rajkumar-rangaraj Please kindly review again, tyvm! And happy new year! |
Fixes #6764
Design discussion issue #6764
Changes
Add TLS-only support to the OTLP HTTP client factory while keeping mTLS behavior. Introduces
OtlpTlsOptions, updates certificate loading/validation flow for CA-only and mTLS scenarios, and expands tests to cover TLS configuration paths.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes