A better way to do this, IMHO, would be to:

1. Not set the value in the constructor
2. Let the test set the value it's interested in
3. Set it back to the original value when being disposed

You could use a similar pattern to this to implement it in a cross-cutting way, then the usage would be something like:

using (new EnvironmentVariableScope("OTEL_SDK_DISABLED", value))
{
    var builder = new LoggerProviderBuilderBase();

    using var provider = builder.Build();

    Assert.IsType(expected, provider);
}

Thanks for the suggestion, I've done that.

Is there any way I can retry the workflow without a commit? Sometimes the build fails even though I have no errors (like right now).

Not without write access to the repo, no.

2 comments:

1. Would probably be good to add a log here. Don't want support tickets raised for missing telemetry when users have shot themselves in the foot 😄

2. This won't work for hosting scenarios. See line 80. This code is only invoked for manual/detached bootstrap. Something else will need to be done for hosting style. Ideally we would have a single solution for both but I haven't looked at where that might go.

Thanks for the hint. Now it should work for both scenarios. Could you please check again?