Skip to content

Commit 5e27d1a

Browse files
committed
Add lost events TODO
1 parent 80f43a1 commit 5e27d1a

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

support/ebpf/tracemgmt.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,12 @@ static inline EBPF_INLINE void send_trace(UNUSED void *ctx, Trace *trace)
397397

398398
// We specify neither BPF_RB_NO_WAKEUP nor BPF_RB_FORCE_WAKEUP here, to allow
399399
// for an 'adaptive' notification to userspace.
400+
401+
// TODO: Unlike perf events, there's no "lost events" counter that userspace can
402+
// access. We can however capture an error here and increment an associated metric.
400403
bpf_ringbuf_output(&trace_events, trace, send_size, 0);
404+
405+
401406
}
402407

403408
// is_kernel_address checks if the given address looks like virtual address to kernel memory.

0 commit comments

Comments
 (0)