Fix Oban Plugin exception handler expecting incorrect metadata key (#392)

* fix(opentelemetry_oban): Plugin exceptions use the reason metadata key

* chore(opentelemetry_oban): Eliminate most of the Logger noise when running tests

Author: GregMefford

instrumentation/opentelemetry_oban/lib/opentelemetry_oban/plugin_handler.ex

@@ -54,14 +54,14 @@ defmodule OpentelemetryOban.PluginHandler do
   def handle_plugin_exception(
         _event,
         _measurements,
-        %{stacktrace: stacktrace, error: error} = metadata,
+        %{kind: :error, reason: exception, stacktrace: stacktrace} = metadata,
         _config
       ) do
     ctx = OpentelemetryTelemetry.set_current_telemetry_span(@tracer_id, metadata)
 
     # Record exception and mark the span as errored
-    Span.record_exception(ctx, error, stacktrace)
-    Span.set_status(ctx, OpenTelemetry.status(:error, ""))
+    Span.record_exception(ctx, exception, stacktrace)
+    Span.set_status(ctx, OpenTelemetry.status(:error, Exception.message(exception)))
 
     OpentelemetryTelemetry.end_telemetry_span(@tracer_id, metadata)
   end

instrumentation/opentelemetry_oban/test/opentelemetry_oban/plugin_handler_test.exs

@@ -71,6 +71,14 @@ defmodule OpentelemetryOban.PluginHandlerTest do
       %{plugin: Elixir.Oban.Plugins.Stager}
     )
 
+    exception = %UndefinedFunctionError{
+      arity: 0,
+      function: :error,
+      message: nil,
+      module: Some,
+      reason: nil
+    }
+
     :telemetry.execute(
       [:oban, :plugin, :exception],
       %{duration: 444},
@@ -80,17 +88,11 @@ defmodule OpentelemetryOban.PluginHandlerTest do
         stacktrace: [
           {Some, :error, [], []}
         ],
-        error: %UndefinedFunctionError{
-          arity: 0,
-          function: :error,
-          message: nil,
-          module: Some,
-          reason: nil
-        }
+        reason: exception
       }
     )
 
-    expected_status = OpenTelemetry.status(:error, "")
+    expected_status = OpenTelemetry.status(:error, Exception.message(exception))
 
     assert_receive {:span,
                     span(

instrumentation/opentelemetry_oban/test/test_helper.exs

@@ -1,4 +1,4 @@
-ExUnit.start()
+ExUnit.start(capture_log: true)
 
 TestRepo.start_link(
   database: "opentelemetry_oban_test",