Skip to content

Commit 275ebaf

Browse files
authored
Merge branch 'main' into resolve_unused_variable_warning
2 parents 05a444a + 51bbad5 commit 275ebaf

File tree

13 files changed

+25
-25
lines changed

13 files changed

+25
-25
lines changed

CHANGELOG.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
7373

7474
- [Add `instrument_unit` to view criteria](https://github.com/open-telemetry/opentelemetry-erlang/pull/604)
7575
- [Validate instrument name](https://github.com/open-telemetry/opentelemetry-erlang/pull/604)
76-
- [Handle `explict_bucket_boundaries` advisory parameter](https://github.com/open-telemetry/opentelemetry-erlang/pull/628)
77-
- [Rename `boundaries` to `explict_bucket_boundaries` in histogram explicit aggregation options](https://github.com/open-telemetry/opentelemetry-erlang/pull/628)
76+
- [Handle `explicit_bucket_boundaries` advisory parameter](https://github.com/open-telemetry/opentelemetry-erlang/pull/628)
77+
- [Rename `boundaries` to `explicit_bucket_boundaries` in histogram explicit aggregation options](https://github.com/open-telemetry/opentelemetry-erlang/pull/628)
7878
- [Allow creating wildcard views](https://github.com/open-telemetry/opentelemetry-erlang/pull/624)
7979
- [Exemplars support](https://github.com/open-telemetry/opentelemetry-erlang/pull/692)
8080
- [Metric
@@ -484,9 +484,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
484484
- Attribute values now validate against what is allowable per the specification
485485
rather than allowing anything the protobuf could encode. This may be breaking
486486
to some users who were relying on the incorrect behavior, such as allowing
487-
dictionaries or non-homogenous lists/tuples. The one exception we have
487+
dictionaries or non-homogeneous lists/tuples. The one exception we have
488488
kept is continuing to allow atoms in place of binaries for performance.
489-
- Attribute values of type list/tuple must be homogenous.
489+
- Attribute values of type list/tuple must be homogeneous.
490490
- Span start opts are now validated. Previously, opts underwent no validations.
491491
- Event and link attributes are now validated. Previously only span attributes
492492
were validated.

apps/opentelemetry/src/otel_batch_processor.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ current_tab_to_list(RegName) ->
9595
ets:tab2list(?CURRENT_TABLE(RegName)).
9696
-endif.
9797

98-
%% require a unique name to distiguish multiple batch processors while
98+
%% require a unique name to distinguish multiple batch processors while
9999
%% still having a single name, instead of a possibly changing pid, to
100100
%% communicate with the processor
101101
%% @doc Starts a Batch Span Processor.

apps/opentelemetry/src/otel_simple_processor.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
-define(DEFAULT_EXPORTER_TIMEOUT_MS, timer:minutes(5)).
6565
-define(NAME_TO_ATOM(Name, Unique), list_to_atom(lists:concat([Name, "_", Unique]))).
6666

67-
%% require a unique name to distiguish multiple simple processors while
67+
%% require a unique name to distinguish multiple simple processors while
6868
%% still having a single name, instead of a possibly changing pid, to
6969
%% communicate with the processor
7070
%% @doc Starts a Simple Span Processor.

apps/opentelemetry/src/otel_tracer_server.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ init_processor(SpanProcessorSup, ProcessorModule, Config) ->
161161
true ->
162162
try supervisor:start_child(SpanProcessorSup,
163163
[ProcessorModule,
164-
%% use a unique reference to distiguish multiple processors of the same type while
164+
%% use a unique reference to distinguish multiple processors of the same type while
165165
%% still having a single name, instead of a possibly changing pid, to
166166
%% communicate with the processor
167167
maps:merge(#{name => erlang:ref_to_list(erlang:make_ref())},

apps/opentelemetry/test/opentelemetry_SUITE.erl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,10 +1025,10 @@ too_many_attributes(Config) ->
10251025
?set_current_span(SpanCtx),
10261026

10271027
%% tuple tests cover lists, as well.
1028-
?set_attribute(attr1, {homogenous, tuple}),
1028+
?set_attribute(attr1, {homogeneous, tuple}),
10291029

1030-
%% dropped because of non-homogenous
1031-
?set_attribute(<<"attr-2-dropped">>, {non_homogenous, <<"attributes">>}),
1030+
%% dropped because of non-homogeneous
1031+
?set_attribute(<<"attr-2-dropped">>, {non_homogeneous, <<"attributes">>}),
10321032

10331033
?set_attribute(<<"attr-3">>, attr_3_value),
10341034

@@ -1045,7 +1045,7 @@ too_many_attributes(Config) ->
10451045
otel_span:end_span(SpanCtx),
10461046
[Span] = assert_exported(Tid, SpanCtx),
10471047

1048-
?assertEqual(#{attr1 => [homogenous, tuple],
1048+
?assertEqual(#{attr1 => [homogeneous, tuple],
10491049
<<"attr-3">> => 4}, otel_attributes:map(Span#span.attributes)),
10501050
?assertEqual(3, otel_attributes:dropped(Span#span.attributes)),
10511051

@@ -1055,7 +1055,7 @@ too_many_attributes(Config) ->
10551055
?set_current_span(SpanCtx2),
10561056

10571057
?set_attributes(#{<<"attr-1">> => <<"attr-value-1">>,
1058-
<<"attr-2">> => {homogenous, attribute},
1058+
<<"attr-2">> => {homogeneous, attribute},
10591059
<<"attr-3">> => attr_3_value,
10601060
<<"attr-4">> => <<"attr-value-4">>}),
10611061

apps/opentelemetry_api/include/opentelemetry.hrl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
%% limitations under the License.
1414
%%%------------------------------------------------------------------------
1515

16-
%% convert 2 strings (one meant to be like a namspace and the other a unique name)
16+
%% convert 2 strings (one meant to be like a namespace and the other a unique name)
1717
%% to an atom for use registering a process
1818
-define(REG_NAME(Name), list_to_atom(lists:concat([?MODULE, "_", Name]))).
1919
-define(GLOBAL_TRACER_PROVIDER_NAME, global).

apps/opentelemetry_api/src/opentelemetry.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ event(_, _, _) ->
437437

438438
%% @doc Creates a list of Span events from the given `List'.
439439
%%
440-
%% This is a conveneince function to create a list of Span events from a list
440+
%% This is a convenience function to create a list of Span events from a list
441441
%% of `{Time, Name, Attributes}' or `{Name, Attributes}' tuples. It's equivalent
442442
%% to calling {@link event/2} or {@link event/3} multiple times. This function
443443
%% also automatically filters out any invalid tuple.

apps/opentelemetry_api/src/otel_propagator_text_map_composite.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
%% @doc Create a new Composite TextMap Propagator.
4141
%%
42-
%% The `Propagators' list is a list of atoms that represnet the <i>suffix</i>
42+
%% The `Propagators' list is a list of atoms that represent the <i>suffix</i>
4343
%% of the module name of the TextMap Propagator to be used.
4444
-spec create([otel_propagator:builtin()]) -> otel_propagator:t().
4545
create(Propagators) ->

apps/opentelemetry_api_experimental/src/otel_meter_noop.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
record(_Meter, _Name, _Number, _Attributes) ->
3333
ok.
3434

35-
record(_Insturment, _Number, _Attributes) ->
35+
record(_Instrument, _Number, _Attributes) ->
3636
ok.
3737

3838
%%

apps/opentelemetry_experimental/src/otel_aggregation_histogram_explicit.erl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
%% since we need the Key in the MatchHead for the index to be used we
4242
%% can't use `ets:fun2ms' as it will shadow `Key' in the `fun' head
4343
-if(?OTP_RELEASE >= 26).
44-
-define(AGGREATE_MATCH_SPEC(Key, Value, BucketCounts),
44+
-define(AGGREGATE_MATCH_SPEC(Key, Value, BucketCounts),
4545
[
4646
{
4747
{explicit_histogram_aggregation,Key,'_','_','_','_','_','$1','$2','$3'},
@@ -62,7 +62,7 @@
6262
]
6363
).
6464
-else.
65-
-define(AGGREATE_MATCH_SPEC(Key, Value, BucketCounts),
65+
-define(AGGREGATE_MATCH_SPEC(Key, Value, BucketCounts),
6666
[
6767
{
6868
{explicit_histogram_aggregation,Key,'_','_','_','_','_','$1','$2','$3'},
@@ -199,7 +199,7 @@ aggregate(Ctx, Table, ExemplarsTab, #stream{name=Name,
199199
counters:add(BucketCounts, BucketIdx, 1),
200200

201201
Key = {Name, Attributes, ReaderId, Generation},
202-
MS = ?AGGREATE_MATCH_SPEC(Key, Value, BucketCounts),
202+
MS = ?AGGREGATE_MATCH_SPEC(Key, Value, BucketCounts),
203203
case ets:select_replace(Table, MS) of
204204
1 ->
205205
otel_metric_exemplar_reservoir:offer(Ctx, ExemplarReservoir, ExemplarsTab, Key, Value, DroppedAttributes),

0 commit comments

Comments
 (0)