address review: remove timed_out, update template text

Author: vyagh

issuegenerator/internal/github/client.go

@@ -53,23 +53,25 @@ const (
 	issueBodyTemplate  = `
 Auto-generated report for ${jobName} job build.
 
-Link to failed build: ${linkToBuild}
+Failing job(s): ${linkToBuild}
 Commit: ${commit}
 PR: ${prNumber}
 
 ### Component(s)
 ${component}
 
+The following tests failed:
 ${failedTests}
 
 **Note**: Information about any subsequent build failures that happen while
 this issue is open, will be added as comments with more information to this issue.
 `
 	issueCommentTemplate = `
-Link to latest failed build: ${linkToBuild}
+Failing job(s): ${linkToBuild}
 Commit: ${commit}
 PR: ${prNumber}
 
+The following tests failed:
 ${failedTests}
 `
 	prCommentTemplate = `@${prAuthor} some tests are failing on main after these changes.  
@@ -330,7 +332,7 @@ func (c *Client) getFailedJobURLs(ctx context.Context, runID int64) (map[string]
 			return nil, err
 		}
 		for _, job := range jobs.Jobs {
-			if job.GetConclusion() == "failure" || job.GetConclusion() == "timed_out" {
+			if job.GetConclusion() == "failure" {
 				failedJobs[job.GetName()] = job.GetHTMLURL()
 			}
 		}
@@ -531,7 +533,7 @@ func (c *Client) CreateIssue(ctx context.Context, r report.Report) *github.Issue
 		c.handleBadResponses(response)
 	}
 
-	// After creating the issue, also comment on the PR  with a link to the created issue
+	// After creating the issue, also comment on the PR with a link to the created issue
 	if prNumber > 0 && issue != nil && issue.HTMLURL != nil {
 		if prAuthor := c.GetPRAuthor(ctx, prNumber); prAuthor != "" {
 			_ = c.CommentOnPR(ctx, prNumber, prAuthor, *issue.HTMLURL)

issuegenerator/internal/github/client_test.go

@@ -118,13 +118,14 @@ func TestTemplateExpansion(t *testing.T) {
 			expected: `
 Auto-generated report for ` + "`test-ci`" + ` job build.
 
-Link to failed build: https://github.com/test-org/test-repo/actions/runs/555555
+Failing job(s): https://github.com/test-org/test-repo/actions/runs/555555
 Commit: abcde12
 PR: N/A
 
 ### Component(s)
 ` + "package1" + `
 
+The following tests failed:
 #### Test Failures
 -  ` + "`TestFailure`" + `
 ` + "```" + `
@@ -142,10 +143,11 @@ this issue is open, will be added as comments with more information to this issu
 			name:     "issue comment template",
 			template: issueCommentTemplate,
 			expected: `
-Link to latest failed build: https://github.com/test-org/test-repo/actions/runs/555555
+Failing job(s): https://github.com/test-org/test-repo/actions/runs/555555
 Commit: abcde12
 PR: N/A
 
+The following tests failed:
 #### Test Failures
 -  ` + "`TestFailure`" + `
 ` + "```" + `
@@ -428,15 +430,6 @@ func TestGetFailedJobURLs(t *testing.T) {
 			]}`,
 			expected: map[string]string{"Lint": "http://job/1", "Test-Linux": "http://job/2"},
 		},
-		{
-			name:  "timed_out treated as failure",
-			runID: 123,
-			mockResponse: `{"jobs": [
-				{"id": 1, "name": "Success Job", "conclusion": "success", "html_url": "http://job/1"},
-				{"id": 2, "name": "Timeout Job", "conclusion": "timed_out", "html_url": "http://job/2"}
-			]}`,
-			expected: map[string]string{"Timeout Job": "http://job/2"},
-		},
 		{
 			name:  "no failures found",
 			runID: 123,