chore: enable unused-parameter and unused-receiver rules from revive (#7645)

Signed-off-by: Matthieu MOREL <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>

Author: mmorel-35

.golangci.yml

@@ -135,6 +135,8 @@ linters:
         - name: time-equal
         - name: unconditional-recursion
         - name: unexported-return
+        - name: unused-parameter
+        - name: unused-receiver
         - name: unhandled-error
           arguments:
             - "fmt.Fprint"

bridges/otellogr/logsink.go

@@ -254,7 +254,7 @@ func (l *LogSink) Info(level int, msg string, keysAndValues ...any) {
 
 // Init receives optional information about the logr library this
 // implementation does not use it.
-func (l *LogSink) Init(logr.RuntimeInfo) {
+func (*LogSink) Init(logr.RuntimeInfo) {
 	// We don't need to do anything here.
 	// CallDepth is used to calculate the caller's PC.
 	// PC is dropped as part of the conversion to the OpenTelemetry log.Record.

bridges/otellogr/logsink_test.go

@@ -22,7 +22,7 @@ type mockLoggerProvider struct {
 	embedded.LoggerProvider
 }
 
-func (mockLoggerProvider) Logger(name string, options ...log.LoggerOption) log.Logger {
+func (mockLoggerProvider) Logger(string, ...log.LoggerOption) log.Logger {
 	return nil
 }
 
@@ -127,7 +127,7 @@ func TestLogSink(t *testing.T) {
 	}{
 		{
 			name: "no_log",
-			f:    func(l *logr.Logger) {},
+			f:    func(*logr.Logger) {},
 			want: logtest.Recording{
 				logtest.Scope{Name: name}: nil,
 			},
@@ -421,7 +421,7 @@ func TestLogSinkContext(t *testing.T) {
 }
 
 func TestLogSinkEnabled(t *testing.T) {
-	enabledFunc := func(ctx context.Context, param log.EnabledParameters) bool {
+	enabledFunc := func(_ context.Context, param log.EnabledParameters) bool {
 		return param.Severity == log.SeverityInfo
 	}
 

bridges/otellogrus/hook.go

@@ -171,7 +171,7 @@ func (h *Hook) Fire(entry *logrus.Entry) error {
 	return nil
 }
 
-func (h *Hook) convertEntry(e *logrus.Entry) log.Record {
+func (*Hook) convertEntry(e *logrus.Entry) log.Record {
 	var record log.Record
 	record.SetTimestamp(e.Time)
 	record.SetBody(log.StringValue(e.Message))

bridges/otellogrus/hook_test.go

@@ -21,7 +21,7 @@ type mockLoggerProvider struct {
 	embedded.LoggerProvider
 }
 
-func (mockLoggerProvider) Logger(name string, options ...log.LoggerOption) log.Logger {
+func (mockLoggerProvider) Logger(string, ...log.LoggerOption) log.Logger {
 	return nil
 }
 

bridges/otelslog/handler_test.go

@@ -453,10 +453,10 @@ func TestSLogHandler(t *testing.T) {
 
 func TestSlogtest(t *testing.T) {
 	r := new(recorder)
-	slogtest.Run(t, func(t *testing.T) slog.Handler {
+	slogtest.Run(t, func(*testing.T) slog.Handler {
 		r = new(recorder)
 		return NewHandler("", WithLoggerProvider(r))
-	}, func(t *testing.T) map[string]any {
+	}, func(*testing.T) map[string]any {
 		return r.Results()[0]
 	})
 }

bridges/otelzap/core.go

@@ -183,7 +183,7 @@ func (o *Core) clone() *Core {
 }
 
 // Sync flushes buffered logs (if any).
-func (o *Core) Sync() error {
+func (*Core) Sync() error {
 	return nil
 }
 

bridges/otelzap/core_test.go

@@ -225,7 +225,7 @@ func TestCoreWriteContextConcurrentSafe(t *testing.T) {
 }
 
 func TestCoreEnabled(t *testing.T) {
-	enabledFunc := func(c context.Context, param log.EnabledParameters) bool {
+	enabledFunc := func(_ context.Context, param log.EnabledParameters) bool {
 		return param.Severity >= log.SeverityInfo
 	}
 

bridges/otelzap/encoder_test.go

@@ -342,7 +342,7 @@ func TestArrayEncoder(t *testing.T) {
 
 type turducken struct{}
 
-func (t turducken) MarshalLogObject(enc zapcore.ObjectEncoder) error {
+func (turducken) MarshalLogObject(enc zapcore.ObjectEncoder) error {
 	return enc.AddArray("ducks", zapcore.ArrayMarshalerFunc(func(arr zapcore.ArrayEncoder) error {
 		for i := 0; i < 2; i++ {
 			err := arr.AppendObject(zapcore.ObjectMarshalerFunc(func(inner zapcore.ObjectEncoder) error {

detectors/autodetect/autodetect_test.go

@@ -24,7 +24,7 @@ func testFactory() func() resource.Detector {
 	return func() resource.Detector { return &testDetector{} }
 }
 
-func (d *testDetector) Detect(ctx context.Context) (*resource.Resource, error) {
+func (d *testDetector) Detect(context.Context) (*resource.Resource, error) {
 	return resource.NewWithAttributes(d.schemaURL, d.attr...), d.err
 }