chore: configure copyloopvar and intrange linters (#7675)

Author: ash2k

.golangci.yml

@@ -7,6 +7,7 @@ linters:
   enable:
     - asasalint
     - bodyclose
+    - copyloopvar
     - depguard
     - errcheck
     - errorlint
@@ -15,6 +16,7 @@ linters:
     - gosec
     - govet
     - ineffassign
+    - intrange
     - misspell
     - perfsprint
     - revive

bridges/otellogr/bench_test.go

@@ -28,7 +28,7 @@ func BenchmarkLogSink(b *testing.B) {
 
 		b.ReportAllocs()
 		b.ResetTimer()
-		for n := 0; n < b.N; n++ {
+		for n := range b.N {
 			logSinks[n].Info(0, message, keyValues...)
 		}
 	})
@@ -41,7 +41,7 @@ func BenchmarkLogSink(b *testing.B) {
 
 		b.ReportAllocs()
 		b.ResetTimer()
-		for n := 0; n < b.N; n++ {
+		for n := range b.N {
 			logSinks[n].Error(err, message, keyValues...)
 		}
 	})
@@ -54,7 +54,7 @@ func BenchmarkLogSink(b *testing.B) {
 
 		b.ReportAllocs()
 		b.ResetTimer()
-		for n := 0; n < b.N; n++ {
+		for n := range b.N {
 			logSinks[n].WithValues(keyValues...)
 		}
 	})
@@ -67,7 +67,7 @@ func BenchmarkLogSink(b *testing.B) {
 
 		b.ReportAllocs()
 		b.ResetTimer()
-		for n := 0; n < b.N; n++ {
+		for n := range b.N {
 			logSinks[n].WithName("name")
 		}
 	})
@@ -80,7 +80,7 @@ func BenchmarkLogSink(b *testing.B) {
 
 		b.ReportAllocs()
 		b.ResetTimer()
-		for n := 0; n < b.N; n++ {
+		for n := range b.N {
 			logSinks[n].WithName("name").WithValues(keyValues...)
 		}
 	})
@@ -93,7 +93,7 @@ func BenchmarkLogSink(b *testing.B) {
 
 		b.ReportAllocs()
 		b.ResetTimer()
-		for n := 0; n < b.N; n++ {
+		for n := range b.N {
 			logSinks[n].Info(0, message)
 		}
 	})

bridges/otellogrus/bench_test.go

@@ -31,7 +31,7 @@ func BenchmarkHook(b *testing.B) {
 
 		b.ReportAllocs()
 		b.ResetTimer()
-		for n := 0; n < b.N; n++ {
+		for n := range b.N {
 			_ = hooks[n].Fire(record)
 		}
 	})

bridges/otelslog/bench_test.go

@@ -40,7 +40,7 @@ func BenchmarkHandler(b *testing.B) {
 
 		b.ReportAllocs()
 		b.ResetTimer()
-		for n := 0; n < b.N; n++ {
+		for n := range b.N {
 			err = handlers[n].Handle(ctx, record)
 		}
 	})
@@ -54,7 +54,7 @@ func BenchmarkHandler(b *testing.B) {
 
 			b.ReportAllocs()
 			b.ResetTimer()
-			for n := 0; n < b.N; n++ {
+			for n := range b.N {
 				h = handlers[n].WithAttrs(attrs5)
 			}
 		})
@@ -66,7 +66,7 @@ func BenchmarkHandler(b *testing.B) {
 
 			b.ReportAllocs()
 			b.ResetTimer()
-			for n := 0; n < b.N; n++ {
+			for n := range b.N {
 				h = handlers[n].WithAttrs(attrs10)
 			}
 		})
@@ -80,7 +80,7 @@ func BenchmarkHandler(b *testing.B) {
 
 		b.ReportAllocs()
 		b.ResetTimer()
-		for n := 0; n < b.N; n++ {
+		for n := range b.N {
 			h = handlers[n].WithGroup("group")
 		}
 	})
@@ -94,7 +94,7 @@ func BenchmarkHandler(b *testing.B) {
 
 			b.ReportAllocs()
 			b.ResetTimer()
-			for n := 0; n < b.N; n++ {
+			for n := range b.N {
 				h = handlers[n].WithGroup("group").WithAttrs(attrs5)
 			}
 		})
@@ -106,7 +106,7 @@ func BenchmarkHandler(b *testing.B) {
 
 			b.ReportAllocs()
 			b.ResetTimer()
-			for n := 0; n < b.N; n++ {
+			for n := range b.N {
 				h = handlers[n].WithGroup("group").WithAttrs(attrs10)
 			}
 		})
@@ -121,7 +121,7 @@ func BenchmarkHandler(b *testing.B) {
 
 			b.ReportAllocs()
 			b.ResetTimer()
-			for n := 0; n < b.N; n++ {
+			for n := range b.N {
 				err = handlers[n].Handle(ctx, record)
 			}
 		})
@@ -133,7 +133,7 @@ func BenchmarkHandler(b *testing.B) {
 
 			b.ReportAllocs()
 			b.ResetTimer()
-			for n := 0; n < b.N; n++ {
+			for n := range b.N {
 				err = handlers[n].Handle(ctx, record)
 			}
 		})
@@ -147,7 +147,7 @@ func BenchmarkHandler(b *testing.B) {
 
 		b.ReportAllocs()
 		b.ResetTimer()
-		for n := 0; n < b.N; n++ {
+		for n := range b.N {
 			err = handlers[n].Handle(ctx, record)
 		}
 	})

bridges/otelzap/encoder_test.go

@@ -362,7 +362,7 @@ type turduckens int
 func (t turduckens) MarshalLogArray(enc zapcore.ArrayEncoder) error {
 	var err error
 	tur := turducken{}
-	for i := 0; i < int(t); i++ {
+	for range t {
 		err = errors.Join(err, enc.AppendObject(tur))
 	}
 	return err

bridges/prometheus/producer.go

@@ -230,7 +230,7 @@ func convertExponentialBuckets(bucketSpans []*dto.BucketSpan, deltas []int64) me
 			// Increase the count index by the Offset to insert Offset zeroes
 			countIndex += bs.GetOffset()
 		}
-		for j := uint32(0); j < bs.GetLength(); j++ {
+		for range bs.GetLength() {
 			// Convert deltas to the cumulative number of observations
 			count += deltas[deltaIndex]
 			deltaIndex++

instrumentation/github.com/aws/aws-lambda-go/otellambda/lambda_test.go

@@ -266,7 +266,7 @@ func BenchmarkInstrumentHandler(b *testing.B) {
 	args := []reflect.Value{ctx, payload}
 
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		wrappedCallable.Call(args)
 	}
 }
@@ -277,7 +277,7 @@ func BenchmarkWrapHandler(b *testing.B) {
 	wrapped := WrapHandler(emptyHandler{})
 
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		_, _ = wrapped.Invoke(mockContext, []byte{0})
 	}
 }