Skip to content

Commit d908fe2

Browse files
committed
fix tests
1 parent a25c28d commit d908fe2

File tree

1 file changed

+18
-18
lines changed
  • instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test

1 file changed

+18
-18
lines changed

instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test/mongo_test.go

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ func TestDBCrudOperation(t *testing.T) {
3030
return assert.Equal(t, "test-collection.insert", s.Name(), "expected %s", s.Name())
3131
},
3232
func(s sdktrace.ReadOnlySpan) bool {
33-
return assert.Contains(t, s.Attributes(), attribute.String("db.operation", "insert"))
33+
return assert.Contains(t, s.Attributes(), attribute.String("db.operation.name", "insert"))
3434
},
3535
func(s sdktrace.ReadOnlySpan) bool {
36-
return assert.Contains(t, s.Attributes(), attribute.String("db.mongodb.collection", "test-collection"))
36+
return assert.Contains(t, s.Attributes(), attribute.String("db.collection.name", "test-collection"))
3737
},
3838
func(s sdktrace.ReadOnlySpan) bool {
3939
return assert.Equal(t, codes.Unset, s.Status().Code)
@@ -56,7 +56,7 @@ func TestDBCrudOperation(t *testing.T) {
5656
excludeCommand: false,
5757
validators: append(commonValidators, func(s sdktrace.ReadOnlySpan) bool {
5858
for _, attr := range s.Attributes() {
59-
if attr.Key == "db.statement" {
59+
if attr.Key == "db.query.text" {
6060
return assert.Contains(t, attr.Value.AsString(), `"test-item":"test-value"`)
6161
}
6262
}
@@ -72,7 +72,7 @@ func TestDBCrudOperation(t *testing.T) {
7272
excludeCommand: true,
7373
validators: append(commonValidators, func(s sdktrace.ReadOnlySpan) bool {
7474
for _, attr := range s.Attributes() {
75-
if attr.Key == "db.statement" {
75+
if attr.Key == "db.query.text" {
7676
return false
7777
}
7878
}
@@ -128,11 +128,11 @@ func TestDBCrudOperation(t *testing.T) {
128128
s := spans[0]
129129
assert.Equal(mt, trace.SpanKindClient, s.SpanKind())
130130
attrs := s.Attributes()
131-
assert.Contains(mt, attrs, attribute.String("db.system", "mongodb"))
132-
assert.Contains(mt, attrs, attribute.String("net.peer.name", "<mock_connection>"))
133-
assert.Contains(mt, attrs, attribute.Int64("net.peer.port", int64(27017)))
134-
assert.Contains(mt, attrs, attribute.String("net.transport", "ip_tcp"))
135-
assert.Contains(mt, attrs, attribute.String("db.name", "test-database"))
131+
assert.Contains(mt, attrs, attribute.String("db.system.name", "mongodb"))
132+
assert.Contains(mt, attrs, attribute.String("network.peer.address", "<mock_connection>:27017"))
133+
assert.Contains(mt, attrs, attribute.Int64("network.peer.port", int64(27017)))
134+
assert.Contains(mt, attrs, attribute.String("network.transport", "tcp"))
135+
assert.Contains(mt, attrs, attribute.String("db.namespace", "test-database"))
136136
for _, v := range tc.validators {
137137
assert.True(mt, v(s))
138138
}
@@ -158,10 +158,10 @@ func TestDBCollectionAttribute(t *testing.T) {
158158
return assert.Equal(t, "test-collection.delete", s.Name())
159159
},
160160
func(s sdktrace.ReadOnlySpan) bool {
161-
return assert.Contains(t, s.Attributes(), attribute.String("db.operation", "delete"))
161+
return assert.Contains(t, s.Attributes(), attribute.String("db.operation.name", "delete"))
162162
},
163163
func(s sdktrace.ReadOnlySpan) bool {
164-
return assert.Contains(t, s.Attributes(), attribute.String("db.mongodb.collection", "test-collection"))
164+
return assert.Contains(t, s.Attributes(), attribute.String("db.collection.name", "test-collection"))
165165
},
166166
func(s sdktrace.ReadOnlySpan) bool {
167167
return assert.Equal(t, codes.Unset, s.Status().Code)
@@ -184,7 +184,7 @@ func TestDBCollectionAttribute(t *testing.T) {
184184
return assert.Equal(t, "listCollections", s.Name())
185185
},
186186
func(s sdktrace.ReadOnlySpan) bool {
187-
return assert.Contains(t, s.Attributes(), attribute.String("db.operation", "listCollections"))
187+
return assert.Contains(t, s.Attributes(), attribute.String("db.operation.name", "listCollections"))
188188
},
189189
func(s sdktrace.ReadOnlySpan) bool {
190190
return assert.Equal(t, codes.Unset, s.Status().Code)
@@ -233,11 +233,11 @@ func TestDBCollectionAttribute(t *testing.T) {
233233
s := spans[0]
234234
assert.Equal(mt, trace.SpanKindClient, s.SpanKind())
235235
attrs := s.Attributes()
236-
assert.Contains(mt, attrs, attribute.String("db.system", "mongodb"))
237-
assert.Contains(mt, attrs, attribute.String("net.peer.name", "<mock_connection>"))
238-
assert.Contains(mt, attrs, attribute.Int64("net.peer.port", int64(27017)))
239-
assert.Contains(mt, attrs, attribute.String("net.transport", "ip_tcp"))
240-
assert.Contains(mt, attrs, attribute.String("db.name", "test-database"))
236+
assert.Contains(mt, attrs, attribute.String("db.system.name", "mongodb"))
237+
assert.Contains(mt, attrs, attribute.String("network.peer.address", "<mock_connection>:27017"))
238+
assert.Contains(mt, attrs, attribute.Int64("network.peer.port", int64(27017)))
239+
assert.Contains(mt, attrs, attribute.String("network.transport", "tcp"))
240+
assert.Contains(mt, attrs, attribute.String("db.namespace", "test-database"))
241241
for _, v := range tc.validators {
242242
assert.True(mt, v(s))
243243
}
@@ -274,7 +274,7 @@ func TestSemanticConventionOptIn(t *testing.T) {
274274
{
275275
name: "default",
276276
semconvOptIn: "",
277-
assert: assertSemconv1170,
277+
assert: assertSemconv,
278278
},
279279
{
280280
name: "database",

0 commit comments

Comments
 (0)