Skip to content

Add linter checking we use the latest semconv version #8231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

Add linter checking we use the latest semconv version #8231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,14 @@ linters:
- pkg: crypto/md5
- pkg: crypto/sha1
- pkg: crypto/**/pkix
semconv:
list-mode: lax
deny:
- pkg: go.opentelemetry.io/otel/semconv
desc: Use go.opentelemetry.io/otel/semconv/v1.37.0 instead. If a newer semconv version has been released, update the depguard rule.
Copy link

@thompson-tomo thompson-tomo Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as I made on collector.

Suggested change
desc: Use go.opentelemetry.io/otel/semconv/v1.37.0 instead. If a newer semconv version has been released, update the depguard rule.
desc: Use go.opentelemetry.io/otel/semconv/v1.38.0 instead. When a newer semconv version is released, it must be added to the depguard rule.

Or

Suggested change
desc: Use go.opentelemetry.io/otel/semconv/v1.37.0 instead. If a newer semconv version has been released, update the depguard rule.
desc: Use go.opentelemetry.io/otel/semconv/v1.38.0 instead. If a newer semconv version has been released, update the depguard rule.

allow:
- go.opentelemetry.io/otel/semconv/v1.21.0 # still used by otelmongo
- go.opentelemetry.io/otel/semconv/v1.37.0
Copy link

@thompson-tomo thompson-tomo Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- go.opentelemetry.io/otel/semconv/v1.37.0
- go.opentelemetry.io/otel/semconv/v1.37.0
- go.opentelemetry.io/otel/semconv/v1.38.0

Copy link
Member Author

@dmathieu dmathieu Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading to 1.38 makes sense. But it shouldn't be within this PR.

Copy link

@thompson-tomo thompson-tomo Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree and this just adds 1.38 as an allowed version.

gocritic:
disabled-checks:
- appendAssign
Expand Down