Skip to content

Commit 678d2f1

Browse files
MrAliaspellared
andauthored
Update the required approvals policy (#6783)
Based on SIG meeting discussions today: relax requirement for two approvals from Approvers at different companies. Instead, require at least one approver or the author to not work at the same company. This means that if the author works at a different company than two Approvers who have approved and work at the same company, the PR is ready to merge. This continues the enforcement that if an author and all Approvers approving a PR work at the same company, additional qualified approvals are needed. Co-authored-by: Robert Pająk <[email protected]>
1 parent 482086a commit 678d2f1

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,9 @@ A PR is considered **ready to merge** when:
109109

110110
This is not enforced through automation, but needs to be validated by the
111111
maintainer merging.
112-
* The qualified approvals need to be from [Approver]s/[Maintainer]s
113-
affiliated with different companies. Two qualified approvals from
114-
[Approver]s or [Maintainer]s affiliated with the same company counts as a
115-
single qualified approval.
112+
* At least one of the qualified approvals need to be from an
113+
[Approver]/[Maintainer] affiliated with a different company than the author
114+
of the PR.
116115
* PRs introducing changes that have already been discussed and consensus
117116
reached only need one qualified approval. The discussion and resolution
118117
needs to be linked to the PR.

0 commit comments

Comments
 (0)