Skip to content

Commit 68bcd1b

Browse files
dashpoledashpole
committed
WIP unit tests
1 parent 1162413 commit 68bcd1b

File tree

4 files changed

+192
-0
lines changed

4 files changed

+192
-0
lines changed

‎sdk/trace/internal/test/benchmark_test.go‎

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
// Copyright The OpenTelemetry Authors
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package test
5+
6+
import (
7+
"fmt"
8+
"testing"
9+
10+
sdktrace "go.opentelemetry.io/otel/sdk/trace"
11+
"go.opentelemetry.io/otel/sdk/trace/tracetest"
12+
)
13+
14+
func BenchmarkSpanProcessorOnEndWithMetricsSDK(b *testing.B) {
15+
b.Setenv("OTEL_GO_X_SELF_OBSERVABILITY", "true")
16+
// TODO: set global meterprovider
17+
for _, bb := range []struct {
18+
batchSize int
19+
spansCount int
20+
}{
21+
{batchSize: 10, spansCount: 10},
22+
{batchSize: 10, spansCount: 100},
23+
{batchSize: 100, spansCount: 10},
24+
{batchSize: 100, spansCount: 100},
25+
} {
26+
b.Run(fmt.Sprintf("batch: %d, spans: %d", bb.batchSize, bb.spansCount), func(b *testing.B) {
27+
bsp := sdktrace.NewBatchSpanProcessor(
28+
tracetest.NewNoopExporter(),
29+
sdktrace.WithMaxExportBatchSize(bb.batchSize),
30+
)
31+
snap := tracetest.SpanStub{}.Snapshot()
32+
33+
b.ResetTimer()
34+
b.ReportAllocs()
35+
for i := 0; i < b.N; i++ {
36+
// Ensure the export happens for every run
37+
for j := 0; j < bb.spansCount; j++ {
38+
bsp.OnEnd(snap)
39+
}
40+
}
41+
})
42+
}
43+
}

‎sdk/trace/internal/test/go.mod‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
module go.opentelemetry.io/opentelemetry-go/sdk/trace/internal/test
2+
3+
go 1.23.1
4+
5+
require (
6+
github.com/stretchr/testify v1.10.0
7+
go.opentelemetry.io/otel/sdk v1.34.0
8+
)
9+
10+
require (
11+
github.com/davecgh/go-spew v1.1.1 // indirect
12+
github.com/go-logr/logr v1.4.2 // indirect
13+
github.com/go-logr/stdr v1.2.2 // indirect
14+
github.com/google/uuid v1.6.0 // indirect
15+
github.com/pmezard/go-difflib v1.0.0 // indirect
16+
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
17+
go.opentelemetry.io/otel v1.34.0 // indirect
18+
go.opentelemetry.io/otel/metric v1.34.0 // indirect
19+
go.opentelemetry.io/otel/trace v1.34.0 // indirect
20+
golang.org/x/sys v0.30.0 // indirect
21+
gopkg.in/yaml.v3 v3.0.1 // indirect
22+
)
23+
24+
replace go.opentelemetry.io/otel/trace => ../../../../trace
25+
26+
replace go.opentelemetry.io/otel/metric => ../../../../metric
27+
28+
replace go.opentelemetry.io/otel => ../../../../
29+
30+
replace go.opentelemetry.io/otel/sdk => ../../../../sdk

‎sdk/trace/internal/test/go.sum‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
2+
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
3+
github.com/go-logr/logr v1.2.2/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
4+
github.com/go-logr/logr v1.4.2 h1:6pFjapn8bFcIbiKo3XT4j/BhANplGihG6tvd+8rYgrY=
5+
github.com/go-logr/logr v1.4.2/go.mod h1:9T104GzyrTigFIr8wt5mBrctHMim0Nb2HLGrmQ40KvY=
6+
github.com/go-logr/stdr v1.2.2 h1:hSWxHoqTgW2S2qGc0LTAI563KZ5YKYRhT3MFKZMbjag=
7+
github.com/go-logr/stdr v1.2.2/go.mod h1:mMo/vtBO5dYbehREoey6XUKy/eSumjCCveDpRre4VKE=
8+
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
9+
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
10+
github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
11+
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
12+
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
13+
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
14+
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
15+
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
16+
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
17+
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
18+
github.com/rogpeppe/go-internal v1.13.1 h1:KvO1DLK/DRN07sQ1LQKScxyZJuNnedQ5/wKSR38lUII=
19+
github.com/rogpeppe/go-internal v1.13.1/go.mod h1:uMEvuHeurkdAXX61udpOXGD/AzZDWNMNyH2VO9fmH0o=
20+
github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
21+
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
22+
go.opentelemetry.io/auto/sdk v1.1.0 h1:cH53jehLUN6UFLY71z+NDOiNJqDdPRaXzTel0sJySYA=
23+
go.opentelemetry.io/auto/sdk v1.1.0/go.mod h1:3wSPjt5PWp2RhlCcmmOial7AvC4DQqZb7a7wCow3W8A=
24+
golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
25+
golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
26+
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
27+
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
28+
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=
29+
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
30+
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

‎sdk/trace/internal/test/selfobs_test.go‎

Lines changed: 89 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,89 @@
1+
// Copyright The OpenTelemetry Authors
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package test
5+
6+
import (
7+
"context"
8+
"sync"
9+
"testing"
10+
11+
"github.com/stretchr/testify/assert"
12+
13+
sdktrace "go.opentelemetry.io/otel/sdk/trace"
14+
)
15+
16+
type testBatchExporter struct {
17+
mu sync.Mutex
18+
spans []sdktrace.ReadOnlySpan
19+
sizes []int
20+
batchCount int
21+
shutdownCount int
22+
errors []error
23+
droppedCount int
24+
idx int
25+
err error
26+
}
27+
28+
func (t *testBatchExporter) ExportSpans(ctx context.Context, spans []sdktrace.ReadOnlySpan) error {
29+
t.mu.Lock()
30+
defer t.mu.Unlock()
31+
32+
if t.idx < len(t.errors) {
33+
t.droppedCount += len(spans)
34+
err := t.errors[t.idx]
35+
t.idx++
36+
return err
37+
}
38+
39+
select {
40+
case <-ctx.Done():
41+
t.err = ctx.Err()
42+
return ctx.Err()
43+
default:
44+
}
45+
46+
t.spans = append(t.spans, spans...)
47+
t.sizes = append(t.sizes, len(spans))
48+
t.batchCount++
49+
return nil
50+
}
51+
52+
func (t *testBatchExporter) Shutdown(context.Context) error {
53+
t.shutdownCount++
54+
return nil
55+
}
56+
57+
func (t *testBatchExporter) len() int {
58+
t.mu.Lock()
59+
defer t.mu.Unlock()
60+
return len(t.spans)
61+
}
62+
63+
func (t *testBatchExporter) getBatchCount() int {
64+
t.mu.Lock()
65+
defer t.mu.Unlock()
66+
return t.batchCount
67+
}
68+
69+
var _ sdktrace.SpanExporter = (*testBatchExporter)(nil)
70+
71+
func TestBatchSpanProcessorShutdownSelfObs(t *testing.T) {
72+
t.Setenv("OTEL_GO_X_SELF_OBSERVABILITY", "true")
73+
// TODO: setup meterprovider and verify metrics produced
74+
var bp testBatchExporter
75+
bsp := sdktrace.NewBatchSpanProcessor(&bp)
76+
77+
err := bsp.Shutdown(context.Background())
78+
if err != nil {
79+
t.Error("Error shutting the BatchSpanProcessor down\n")
80+
}
81+
assert.Equal(t, 1, bp.shutdownCount, "shutdown from span exporter not called")
82+
83+
// Multiple call to Shutdown() should not panic.
84+
err = bsp.Shutdown(context.Background())
85+
if err != nil {
86+
t.Error("Error shutting the BatchSpanProcessor down\n")
87+
}
88+
assert.Equal(t, 1, bp.shutdownCount)
89+
}

0 commit comments

Comments
 (0)