address comments

Author: dashpole

sdk/trace/batch_span_processor.go

@@ -139,12 +139,12 @@ func NewBatchSpanProcessor(exporter SpanExporter, options ...BatchSpanProcessorO
 	return bsp
 }
 
-var processorID atomic.Int64
+var processorIDCounter atomic.Int64
 
-// nextProcessorID returns an identifier for this batch span processor,
+// nextprocessorIDCounter returns an identifier for this batch span processor,
 // starting with 0 and incrementing by 1 each time it is called.
-func nextProcessorID() int64 {
-	return processorID.Add(1) - 1
+func nextprocessorIDCounter() int64 {
+	return processorIDCounter.Add(1) - 1
 }
 
 // configureSelfObservability configures metrics for the batch span processor.
@@ -154,7 +154,7 @@ func (bsp *batchSpanProcessor) configureSelfObservability() {
 	}
 	bsp.selfObservabilityEnabled = true
 	bsp.componentNameAttr = semconv.OTelComponentName(
-		fmt.Sprintf("%s/%d", otelconv.ComponentTypeBatchingSpanProcessor, nextProcessorID()))
+		fmt.Sprintf("%s/%d", otelconv.ComponentTypeBatchingSpanProcessor, nextprocessorIDCounter()))
 	meter := otel.GetMeterProvider().Meter(
 		selfObsScopeName,
 		metric.WithInstrumentationVersion(sdk.Version()),

sdk/trace/batch_span_processor_test.go

@@ -8,6 +8,7 @@ import (
 	"encoding/binary"
 	"errors"
 	"fmt"
+	"runtime"
 	"sync"
 	"sync/atomic"
 	"testing"
@@ -872,7 +873,7 @@ func (e *blockingExporter) ExportSpans(ctx context.Context, s []ReadOnlySpan) er
 
 func (e *blockingExporter) waitForSpans(n int32) {
 	// Wait for all n spans to reach the export call
-	// nolint: revive // intentionally empty block
 	for e.total.Load() < n {
+		runtime.Gosched()
 	}
 }