chore: enable gocritic linter (#7095)

#### Description

Enable and fixes several rules from
[gocritic](https://golangci-lint.run/usage/linters/#gocritic) linter

---------

Signed-off-by: Matthieu MOREL <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>

Author: mmorel-35

.golangci.yml

@@ -10,6 +10,7 @@ linters:
     - depguard
     - errcheck
     - errorlint
+    - gocritic
     - godot
     - gosec
     - govet
@@ -86,6 +87,20 @@ linters:
           deny:
             - pkg: go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal
               desc: Do not use cross-module internal packages.
+    gocritic:
+      disabled-checks:
+        - appendAssign
+        - commentedOutCode
+        - dupArg
+        - hugeParam
+        - importShadow
+        - paramTypeCombine
+        - ptrToRefParam
+        - preferDecodeRune
+        - rangeValCopy
+        - unnamedResult
+        - whyNoLint
+      enable-all: true
     godot:
       exclude:
         # Exclude links.
@@ -225,10 +240,6 @@ linters:
       - linters:
           - gosec
         text: 'G402: TLS MinVersion too low.'
-    paths:
-      - third_party$
-      - builtin$
-      - examples$
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0
@@ -245,7 +256,3 @@ formatters:
       max-len: 120
   exclusions:
     generated: lax
-    paths:
-      - third_party$
-      - builtin$
-      - examples$

attribute/encoder.go

@@ -96,11 +96,11 @@ func (d *defaultAttrEncoder) Encode(iter Iterator) string {
 	for iter.Next() {
 		i, keyValue := iter.IndexedAttribute()
 		if i > 0 {
-			_, _ = buf.WriteRune(',')
+			_ = buf.WriteByte(',')
 		}
 		copyAndEscape(buf, string(keyValue.Key))
 
-		_, _ = buf.WriteRune('=')
+		_ = buf.WriteByte('=')
 
 		if keyValue.Value.Type() == STRING {
 			copyAndEscape(buf, keyValue.Value.AsString())
@@ -122,7 +122,7 @@ func copyAndEscape(buf *bytes.Buffer, val string) {
 	for _, ch := range val {
 		switch ch {
 		case '=', ',', escapeChar:
-			_, _ = buf.WriteRune(escapeChar)
+			_ = buf.WriteByte(escapeChar)
 		}
 		_, _ = buf.WriteRune(ch)
 	}

attribute/filter.go

@@ -15,7 +15,7 @@ type Filter func(KeyValue) bool
 //
 // If keys is empty a deny-all filter is returned.
 func NewAllowKeysFilter(keys ...Key) Filter {
-	if len(keys) <= 0 {
+	if len(keys) == 0 {
 		return func(kv KeyValue) bool { return false }
 	}
 
@@ -34,7 +34,7 @@ func NewAllowKeysFilter(keys ...Key) Filter {
 //
 // If keys is empty an allow-all filter is returned.
 func NewDenyKeysFilter(keys ...Key) Filter {
-	if len(keys) <= 0 {
+	if len(keys) == 0 {
 		return func(kv KeyValue) bool { return true }
 	}
 

baggage/baggage.go

@@ -812,7 +812,7 @@ var safeKeyCharset = [utf8.RuneSelf]bool{
 // validateBaggageName checks if the string is a valid OpenTelemetry Baggage name.
 // Baggage name is a valid, non-empty UTF-8 string.
 func validateBaggageName(s string) bool {
-	if len(s) == 0 {
+	if s == "" {
 		return false
 	}
 
@@ -828,7 +828,7 @@ func validateBaggageValue(s string) bool {
 
 // validateKey checks if the string is a valid W3C Baggage key.
 func validateKey(s string) bool {
-	if len(s) == 0 {
+	if s == "" {
 		return false
 	}
 

bridge/opencensus/trace_test.go

@@ -134,12 +134,10 @@ func TestOTelSpanContextToOC(t *testing.T) {
 					gotTraceState = strings.Join(gotTraceStateEntries, ",")
 				}
 				assert.Equal(t, expectedTraceState, gotTraceState, "Tracestate should preserve entries")
-			} else {
+			} else if got.Tracestate != nil {
 				// For empty tracestate cases, ensure the field is properly handled
-				if got.Tracestate != nil {
-					entries := got.Tracestate.Entries()
-					assert.Empty(t, entries, "Empty tracestate should result in empty entries")
-				}
+				entries := got.Tracestate.Entries()
+				assert.Empty(t, entries, "Empty tracestate should result in empty entries")
 			}
 		})
 	}

bridge/opentracing/bridge_test.go

@@ -135,7 +135,7 @@ var (
 type testTextMapPropagator struct{}
 
 func (t testTextMapPropagator) Inject(ctx context.Context, carrier propagation.TextMapCarrier) {
-	carrier.Set(testHeader, strings.Join([]string{traceID.String(), spanID.String()}, ":"))
+	carrier.Set(testHeader, traceID.String()+":"+spanID.String())
 
 	// Test for panic
 	_ = carrier.Get("test")

exporters/otlp/otlplog/otlploggrpc/client.go

@@ -86,11 +86,12 @@ func newGRPCDialOptions(cfg config) []grpc.DialOption {
 		dialOpts = append(dialOpts, grpc.WithDefaultServiceConfig(cfg.serviceConfig.Value))
 	}
 	// Prioritize GRPCCredentials over Insecure (passing both is an error).
-	if cfg.gRPCCredentials.Value != nil {
+	switch {
+	case cfg.gRPCCredentials.Value != nil:
 		dialOpts = append(dialOpts, grpc.WithTransportCredentials(cfg.gRPCCredentials.Value))
-	} else if cfg.insecure.Value {
+	case cfg.insecure.Value:
 		dialOpts = append(dialOpts, grpc.WithTransportCredentials(insecure.NewCredentials()))
-	} else {
+	default:
 		// Default to using the host's root CA.
 		dialOpts = append(dialOpts, grpc.WithTransportCredentials(
 			credentials.NewTLS(nil),

exporters/otlp/otlplog/otlploggrpc/config.go

@@ -563,7 +563,7 @@ func loadCertificates(certPath, keyPath string) ([]tls.Certificate, error) {
 func insecureFromScheme(prev setting[bool], scheme string) setting[bool] {
 	if scheme == "https" {
 		return newSetting(false)
-	} else if len(scheme) > 0 {
+	} else if scheme != "" {
 		return newSetting(true)
 	}
 

exporters/otlp/otlplog/otlploggrpc/config_test.go

@@ -525,10 +525,8 @@ func assertTLSConfig(t *testing.T, want, got setting[*tls.Config]) {
 
 	if want.Value.RootCAs == nil {
 		assert.Nil(t, got.Value.RootCAs, "*tls.Config.RootCAs")
-	} else {
-		if assert.NotNil(t, got.Value.RootCAs, "RootCAs") {
-			assert.True(t, want.Value.RootCAs.Equal(got.Value.RootCAs), "RootCAs equal")
-		}
+	} else if assert.NotNil(t, got.Value.RootCAs, "RootCAs") {
+		assert.True(t, want.Value.RootCAs.Equal(got.Value.RootCAs), "RootCAs equal")
 	}
 	assert.Equal(t, want.Value.Certificates, got.Value.Certificates, "Certificates")
 }

exporters/otlp/otlplog/otlploghttp/client.go

@@ -200,7 +200,7 @@ func (c *httpClient) uploadLogs(ctx context.Context, data []*logpb.ResourceLogs)
 			return err
 		}
 		respStr := strings.TrimSpace(respData.String())
-		if len(respStr) == 0 {
+		if respStr == "" {
 			respStr = "(empty)"
 		}
 		bodyErr := fmt.Errorf("body: %s", respStr)
@@ -232,7 +232,7 @@ func (c *httpClient) newRequest(ctx context.Context, body []byte) (request, erro
 
 	switch c.compression {
 	case NoCompression:
-		r.ContentLength = (int64)(len(body))
+		r.ContentLength = int64(len(body))
 		req.bodyReader = bodyReader(body)
 	case GzipCompression:
 		// Ensure the content length is not used.