Skip to content

Commit 9e4e348

Browse files
committed
optimise when bVals is empty as suggested -- also add test case for empty bVals
1 parent a63c63a commit 9e4e348

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

propagation/baggage.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@ func extractSingleBaggage(parent context.Context, carrier TextMapCarrier) contex
5656

5757
func extractMultiBaggage(parent context.Context, carrier MultiTextMapCarrier) context.Context {
5858
bVals := carrier.Values(baggageHeader)
59+
if len(bVals) == 0 {
60+
return parent
61+
}
5962
members := make([]baggage.Member, 0)
6063
for _, bStr := range bVals {
6164
currBag, err := baggage.Parse(bStr)

propagation/baggage_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,11 @@ func TestExtractValidMultipleBaggageHeaders(t *testing.T) {
162162
headers: []string{"", ""},
163163
want: members{},
164164
},
165+
{
166+
name: "none",
167+
headers: []string{},
168+
want: members{},
169+
},
165170
}
166171

167172
for _, tt := range tests {

0 commit comments

Comments
 (0)