Skip to content

Commit c4b8e91

Browse files
matoouspellared
andauthored
chore(semconv): follow weaver folder structure (#6998)
(this PR is a suggestion, feel free to close if it doesn't align with the vision for this repo) Moves jinja templates for semantic conventions from the root of `semconv/` into `semconv/templates/registry/go/`, making them easier to consume. While this wasn't impeding development in `opentelemetry-go` it makes it easier to consume the templates from other packages via: ```bash weaver registry generate --templates https://github.com/open-telemetry/opentelemetry-go.git[semconv/templates] go . ``` which was previously impossible. Specific use-case would be using [weaver](https://github.com/open-telemetry/weaver) to maintain private registry of semantic conventions for companies/projects in which case it's more convenient to be able to rely on the upstream opentelemetry-go templates as opposed to having to copy them over. Tested by running: ```bash TAG='v1.34.0' make semconv-generate ``` which results into empty diff. ## Open questions Does the changelog deserve an entry for this even without changes to the API? Co-authored-by: Robert Pająk <[email protected]>
1 parent e6ba1eb commit c4b8e91

File tree

5 files changed

+1
-1
lines changed

5 files changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ semconv-generate: $(SEMCONVKIT)
281281
docker run --rm \
282282
-u $(DOCKER_USER) \
283283
--env HOME=/tmp/weaver \
284-
--mount 'type=bind,source=$(PWD)/semconv,target=/home/weaver/templates/registry/go,readonly' \
284+
--mount 'type=bind,source=$(PWD)/semconv/templates,target=/home/weaver/templates,readonly' \
285285
--mount 'type=bind,source=$(PWD)/semconv/${TAG},target=/home/weaver/target' \
286286
--mount 'type=bind,source=$(HOME)/.weaver,target=/tmp/weaver/.weaver' \
287287
$(WEAVER_IMAGE) registry generate \
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)