Skip to content

Conversation

@yumosx
Copy link
Member

@yumosx yumosx commented Oct 29, 2025

ref #7016

goarch: amd64
pkg: go.opentelemetry.io/otel/sdk/log
cpu: Intel(R) Core(TM) i7-14700
                                                │ before.txt  │  .\after_res.txt   │
                                                │   sec/op    │   sec/op     vs base   │
SimpleProcessorObservability/NoObservability-28   27.68n ± 4%
SimpleProcessorObservability/Observability-28                   27.39n ± 5%
geomean                                           27.68n        27.38n       ? ¹ ²
¹ benchmark set differs from baseline; geomeans may not be comparable
² ratios must be >0 to compute geomean

                                                │  before.txt  │   .\after_res.txt   │
                                                │     B/op     │    B/op     vs base │
SimpleProcessorObservability/NoObservability-28   0.000 ± 0%
SimpleProcessorObservability/Observability-28                    0.000 ± 0%
geomean                                                      ¹               ? ² ¹ ³
¹ summaries must be >0 to compute geomean
² benchmark set differs from baseline; geomeans may not be comparable
³ ratios must be >0 to compute geomean

                                                │  before.txt  │   .\after_res.txt   │
                                                │  allocs/op   │ allocs/op   vs base │
SimpleProcessorObservability/NoObservability-28   0.000 ± 0%
SimpleProcessorObservability/Observability-28                    0.000 ± 0%
geomean                                                      ¹               ? ² ¹ ³
¹ summaries must be >0 to compute geomean
² benchmark set differs from baseline; geomeans may not be comparable
³ ratios must be >0 to compute geomean

@yumosx yumosx marked this pull request as draft October 29, 2025 01:06
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.1%. Comparing base (a0a0acd) to head (d5d3232).

Files with missing lines Patch % Lines
sdk/log/simple.go 83.3% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7548     +/-   ##
=======================================
- Coverage   86.1%   86.1%   -0.1%     
=======================================
  Files        298     298             
  Lines      21694   21709     +15     
=======================================
+ Hits       18695   18705     +10     
- Misses      2623    2627      +4     
- Partials     376     377      +1     
Files with missing lines Coverage Δ
sdk/log/internal/observ/simple_log_processor.go 100.0% <100.0%> (ø)
sdk/log/simple.go 94.2% <83.3%> (-5.8%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yumosx yumosx marked this pull request as ready for review November 3, 2025 09:17
@yumosx yumosx marked this pull request as draft November 3, 2025 09:20
@yumosx yumosx marked this pull request as ready for review November 3, 2025 13:05
Copy link
Member

@flc1125 flc1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining two issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants