Skip to content

Conversation

@nicohertz
Copy link

@nicohertz nicohertz commented Nov 23, 2025

Instead of blindly creating a "runtime/trace".Task for every span, add config flags to control task and region creation

  • for root local spans, keep creating a task
  • for child local spans, do nothing unless explicitly asked to create a task or a region

Slack thread: https://cloud-native.slack.com/archives/C01NPAXACKT/p1763590922506999

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@nicohertz nicohertz marked this pull request as draft November 23, 2025 08:05
@nicohertz nicohertz marked this pull request as ready for review November 23, 2025 09:21
@nicohertz nicohertz changed the title Create "runtime/trace".Region for spans with local parent Add config flags to tell the tracer to create "runtime/trace" Task or Region Nov 23, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.1%. Comparing base (7323fc7) to head (efd7924).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
sdk/trace/runtime_trace.go 25.0% 6 Missing ⚠️
trace/config.go 75.0% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7628   +/-   ##
=====================================
  Coverage   86.1%   86.1%           
=====================================
  Files        298     299    +1     
  Lines      21694   21732   +38     
=====================================
+ Hits       18692   18727   +35     
- Misses      2626    2629    +3     
  Partials     376     376           
Files with missing lines Coverage Δ
sdk/trace/span.go 87.2% <100.0%> (+1.7%) ⬆️
sdk/trace/tracer.go 100.0% <100.0%> (ø)
trace/config.go 94.2% <75.0%> (-2.6%) ⬇️
sdk/trace/runtime_trace.go 25.0% <25.0%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu
Copy link
Member

This PR is getting out of hand in terms of size. If you want us to be able to review this, you need to keep it small/atomic.
Also, this makes changes to the API with no related specification. So I think an RFC would be a better first step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants